From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id 8BDF6AF8A for ; Mon, 14 Apr 2014 16:19:34 +0200 (CEST) Received: by mail-wi0-f172.google.com with SMTP id hi2so4100688wib.5 for ; Mon, 14 Apr 2014 07:19:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=9y4jE4T4gfYlXwVM5vMXn0pLlAHderJRXjY6yVkJLoI=; b=W5VazolFRiDufp0vMCj+B0ir7hDOtR3R52z+IcMQu4XxDZfplO2h+gCY1oQIXq9C8A fyxZy2GjFqxL0cbOEp+5+RuVly15zBnsYlpSYtT9SkkBSCtd9w0YGJ1cPPpceJP1JOSs rPASSOZ0nCq0foSkgp/oDKvCdpaNjP34b5Ad0KfaV2JEtCAnbKkcGMy0h5hWhlib/sg2 7/XTPb6c/ljd31FWOdDWG5p4PZqn5/qEOY6ZwRmvrdDiw/3SpXU75LH+JnMiYchnAZNf Q42Qpp6xvoeMg7NwwnWU0MrFZLtVfxek42ngMRbf2PapvUO/WMedK7e1gzn6FPxHQJ/N YU7A== X-Gm-Message-State: ALoCoQn41GK/UpLtyEMRJO9m58NMS1b2lUyvsGD+S1EeNdFrYAwwMsiOlWKFKUIYOrNWisTEOK8Q X-Received: by 10.180.11.239 with SMTP id t15mr9945186wib.25.1397485173423; Mon, 14 Apr 2014 07:19:33 -0700 (PDT) Received: from alcyon.dev.6wind.com (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id u1sm25243071wjx.16.2014.04.14.07.19.32 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 14 Apr 2014 07:19:32 -0700 (PDT) Message-ID: <534BEE72.4070205@6wind.com> Date: Mon, 14 Apr 2014 16:19:30 +0200 From: David Marchand User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 MIME-Version: 1.0 To: "Burakov, Anatoly" References: <1397479912-4906-1-git-send-email-david.marchand@6wind.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 0/3] remove RTE_EAL_UNBIND_PORTS related code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Apr 2014 14:19:34 -0000 On 04/14/2014 03:12 PM, Burakov, Anatoly wrote: >> For now, I have a problem with your patch as it breaks drivers that use >> RTE_PCI_DRV_FORCE_UNBIND flag, since it removes the part where this flag >> is handled. Besides, I can see some remaining parts mentioning >> pci_switch_module() in comments. > > I wonder if this functionality is needed at all. I couldn't find any drivers using that flag, and the unbinding can be done using the included Python script as well. Given that we're getting rid of unbinding and binding in the EAL, it's only logical that we get rid of the force-unbinding as well, don't you think? This functionality is at least used by virtio-net-pmd. So we cannot remove this without a fix for virtio-net-pmd. Besides, if we remove this functionality, then headers and documentation should be updated accordingly. Yet, even if we remove this from the eal, I think we should provide a proper api to bind/unbind devices to kernel drivers. This way PMDs can use this api and forget about OS dependencies (linux/bsd). By the way, there is also a cleanup to be done inside bsd implementation as I found references to linux code inside it. $ grep -rl pci_switch_module lib/ lib/librte_eal/bsdapp/eal/eal_pci.c I am not sure BSD has a /sys filesystem. $ grep -rl eal_parse_sysfs_value lib/librte_eal/bsdapp/ lib/librte_eal/bsdapp/eal/include/eal_filesystem.h lib/librte_eal/bsdapp/eal/eal.c As a conclusion, as far as all these cleanups are concerned, I would say we should target the next major release. Regards, -- David Marchand