[dpdk-dev] [PATCH] ethdev: fix errno to have positive value

[dpdk-dev] [PATCH] ethdev: fix errno to have positive value

[Andrew Rybchenko]

rte_errno should be set to positive value from errno.h plus
few RTE-specific values.

Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation")
Fixes: 439a90b5f2a7 ("ethdev: reorder inline functions")
Cc: stable@dpdk.org

Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 lib/librte_ethdev/rte_ethdev.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index 76266ad10..a3c864a13 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -4222,7 +4222,7 @@ rte_eth_tx_prepare(uint16_t port_id, uint16_t queue_id,
 #ifdef RTE_LIBRTE_ETHDEV_DEBUG
 	if (!rte_eth_dev_is_valid_port(port_id)) {
 		RTE_ETHDEV_LOG(ERR, "Invalid TX port_id=%u\n", port_id);
-		rte_errno = -EINVAL;
+		rte_errno = EINVAL;
 		return 0;
 	}
 #endif
@@ -4232,7 +4232,7 @@ rte_eth_tx_prepare(uint16_t port_id, uint16_t queue_id,
 #ifdef RTE_LIBRTE_ETHDEV_DEBUG
 	if (queue_id >= dev->data->nb_tx_queues) {
 		RTE_ETHDEV_LOG(ERR, "Invalid TX queue_id=%u\n", queue_id);
-		rte_errno = -EINVAL;
+		rte_errno = EINVAL;
 		return 0;
 	}
 #endif
-- 
2.17.1

Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: fix errno to have positive value

[Thomas Monjalon]

21/01/2019 17:18, Andrew Rybchenko:
> rte_errno should be set to positive value from errno.h plus
> few RTE-specific values.
> 
> Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation")
> Fixes: 439a90b5f2a7 ("ethdev: reorder inline functions")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>

Applied, thanks

There are other occurrences in drivers:
	git grep 'rte_errno = -E'

Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: fix errno to have positive value

[Burakov, Anatoly]

On 22-Jan-19 4:03 PM, Thomas Monjalon wrote:
> 21/01/2019 17:18, Andrew Rybchenko:
>> rte_errno should be set to positive value from errno.h plus
>> few RTE-specific values.
>>
>> Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation")
>> Fixes: 439a90b5f2a7 ("ethdev: reorder inline functions")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> 
> Applied, thanks
> 
> There are other occurrences in drivers:
> 	git grep 'rte_errno = -E'
> 

There could also possibly be rte_errno = -value; type assignments. I 
imagine most of them are correct (since the value itself was negative in 
the first place, so additional '-' flips the sign again), but it doesn't 
hurt to check :)

-- 
Thanks,
Anatoly