From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 29E4771B5; Fri, 12 Jan 2018 19:05:36 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jan 2018 10:05:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,350,1511856000"; d="scan'208";a="9157039" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.145]) ([10.237.220.145]) by fmsmga007.fm.intel.com with ESMTP; 12 Jan 2018 10:05:34 -0800 To: Thomas Monjalon Cc: dev@dpdk.org, maryam.tahhan@intel.com, stable@dpdk.org References: <4a54e295890a75b513176c62f83f87b67817baa4.1515777134.git.anatoly.burakov@intel.com> <2386533.Y8nkdzO727@xps> From: "Burakov, Anatoly" Message-ID: <5359a290-5437-3d9c-0ed7-02fd98de8291@intel.com> Date: Fri, 12 Jan 2018 18:05:33 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <2386533.Y8nkdzO727@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] app/procinfo: add compilation option in config file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jan 2018 18:05:37 -0000 On 12-Jan-18 6:02 PM, Thomas Monjalon wrote: > 12/01/2018 18:49, Anatoly Burakov: >> Unlike every other DPDK application's compilation, proc_info's >> compilation cannot be turned off on Linux. Fix it by adding a >> config option to base linuxapp config. >> >> Fixes: 22561383ea17 ("app: replace dump_cfg by proc_info") >> Cc: maryam.tahhan@intel.com >> Cc: stable@dpdk.org >> Signed-off-by: Anatoly Burakov >> --- >> app/Makefile | 2 +- >> config/common_linuxapp | 1 + > > You should also add the option in common_base (as disabled), > so we keep the list of almost every options in one place. > Right, will fix. -- Thanks, Anatoly