From: Thomas Monjalon <thomas@monjalon.net>
To: Wenzhuo Lu <wenzhuo.lu@intel.com>
Cc: dev@dpdk.org, olivier.matz@6wind.com
Subject: Re: [dpdk-dev] [RFC] lib/librte_ether: add a return value for MAC set ops
Date: Wed, 23 May 2018 00:47:36 +0200 [thread overview]
Message-ID: <5363348.Zb8vDSmybQ@xps> (raw)
In-Reply-To: <1516848417-77912-1-git-send-email-wenzhuo.lu@intel.com>
25/01/2018 03:46, Wenzhuo Lu:
> Setting the default MAC address may fail on many NICs.
> But the ops return void. So, even it failed, RTE changes
> the MAC address and APP doesn't know the failure.
>
> It's not real patch, just show the idea to add a return
> value for the ops.
>
> BTW,
> Seems we should do the same thing for
> rte_eth_dev_mac_addr_remove as it also has chance to fail
> in PMD layer.
>
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Superseded by "ethdev: return diagnostic when setting MAC address"
http://dpdk.org/commit/caccf8b318
prev parent reply other threads:[~2018-05-22 22:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 2:46 Wenzhuo Lu
2018-01-25 10:40 ` Olivier Matz
2018-01-26 2:19 ` Lu, Wenzhuo
2018-01-26 16:54 ` Ferruh Yigit
2018-01-29 8:25 ` Olivier Matz
2018-05-22 22:47 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5363348.Zb8vDSmybQ@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).