From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 7F4F420BD for ; Wed, 23 May 2018 00:47:38 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 15D4E21AF5; Tue, 22 May 2018 18:47:38 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 22 May 2018 18:47:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=KwpXflOluTbVZ2t/0KkexnRfdU 1FFnhBjswYVpoPHMw=; b=CvCs7whNd6MQrR36834jdhDQgkkQ3pu65h8a6KaHPw 4e+EPun07X6C7DLDF+uUCEbH/qQFm1wZhAsUh425AxoBFYfRgTovGKCgGQkHqy7P gb51AfTNN+dqvt/fwJva+n4HGSf91+IL24bpcQaD0VZFfo7Bj5mQQPl6yY+mLxgQ A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=KwpXfl OluTbVZ2t/0KkexnRfdU1FFnhBjswYVpoPHMw=; b=SP/tW8O8Ig13Z3L3Yl2wcp EcuhkBdSTnPgGLEAV7yXEEMHP/NQP+XunW8nzkXDNVLtd/jkcKrW57WX3uK7CMKX /oFX27xmm8k8+CjuSHM6KLssjVgPciDQl074mrtG5WDmeICs+//J71+Y7qDkomVW mWLEe9E5tszjldwUaGdMD1haTj+/aaxTtTyzZQJ3vjibC/DDNifpwAgry2F9KkVb dFHggwRgXbs7PQJJxmxNUknOXlrRjBRiTRM6fVKUJfntf78MXe39qMSH/KzswSyw IaHG2z6SOseULMP7CXNfL1w6BqeB4PRpRzN79nWjQ14d1MtHxC55V3SHm3oOGosA == X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 65E9BE465C; Tue, 22 May 2018 18:47:37 -0400 (EDT) From: Thomas Monjalon To: Wenzhuo Lu Cc: dev@dpdk.org, olivier.matz@6wind.com Date: Wed, 23 May 2018 00:47:36 +0200 Message-ID: <5363348.Zb8vDSmybQ@xps> In-Reply-To: <1516848417-77912-1-git-send-email-wenzhuo.lu@intel.com> References: <1516848417-77912-1-git-send-email-wenzhuo.lu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [RFC] lib/librte_ether: add a return value for MAC set ops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2018 22:47:38 -0000 25/01/2018 03:46, Wenzhuo Lu: > Setting the default MAC address may fail on many NICs. > But the ops return void. So, even it failed, RTE changes > the MAC address and APP doesn't know the failure. > > It's not real patch, just show the idea to add a return > value for the ops. > > BTW, > Seems we should do the same thing for > rte_eth_dev_mac_addr_remove as it also has chance to fail > in PMD layer. > > Signed-off-by: Wenzhuo Lu Superseded by "ethdev: return diagnostic when setting MAC address" http://dpdk.org/commit/caccf8b318