DPDK patches and discussions
 help / color / mirror / Atom feed
From: Yong Wang <yongwang@vmware.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 11/11] net/vmxnet3: fix Tx prepare to set positive rte_errno
Date: Wed, 5 Jun 2019 22:45:30 +0000	[thread overview]
Message-ID: <5367CB44-70FA-49D8-BC5F-E4A69D4C76C6@vmware.com> (raw)
In-Reply-To: <1559722565-25992-12-git-send-email-arybchenko@solarflare.com>

-----Original Message-----
From: Andrew Rybchenko <arybchenko@solarflare.com>
Date: Wednesday, June 5, 2019 at 1:17 AM
To: Yong Wang <yongwang@vmware.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: [PATCH 11/11] net/vmxnet3: fix Tx prepare to set positive rte_errno

    Fixes: baf3bbae5556 ("net/vmxnet3: add Tx preparation")
    Cc: stable@dpdk.org
    
    Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
    ---

Acked-by: Yong Wang <yongwang@vmware.com>

     drivers/net/vmxnet3/vmxnet3_rxtx.c | 8 ++++----
     1 file changed, 4 insertions(+), 4 deletions(-)
    
    diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c
    index 6644cde..7794d74 100644
    --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
    +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
    @@ -361,7 +361,7 @@
     		 */
     		if ((ol_flags & PKT_TX_TCP_SEG) == 0 &&
     				m->nb_segs > VMXNET3_MAX_TXD_PER_PKT) {
    -			rte_errno = -EINVAL;
    +			rte_errno = EINVAL;
     			return i;
     		}
     
    @@ -369,20 +369,20 @@
     		if ((ol_flags & VMXNET3_TX_OFFLOAD_NOTSUP_MASK) != 0 ||
     				(ol_flags & PKT_TX_L4_MASK) ==
     				PKT_TX_SCTP_CKSUM) {
    -			rte_errno = -ENOTSUP;
    +			rte_errno = ENOTSUP;
     			return i;
     		}
     
     #ifdef RTE_LIBRTE_ETHDEV_DEBUG
     		ret = rte_validate_tx_offload(m);
     		if (ret != 0) {
    -			rte_errno = ret;
    +			rte_errno = -ret;
     			return i;
     		}
     #endif
     		ret = rte_net_intel_cksum_prepare(m);
     		if (ret != 0) {
    -			rte_errno = ret;
    +			rte_errno = -ret;
     			return i;
     		}
     	}
    -- 
    1.8.3.1
    
    


  reply	other threads:[~2019-06-05 22:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-05  8:15 [dpdk-dev] [PATCH 00/11] ethdev: " Andrew Rybchenko
2019-06-05  8:15 ` [dpdk-dev] [PATCH 01/11] ethdev: fix Tx prepare documentation to use positive errno Andrew Rybchenko
2019-06-05  8:15 ` [dpdk-dev] [PATCH 02/11] net/atlantic: fix Tx prepare to set positive rte_errno Andrew Rybchenko
2019-06-05  8:15 ` [dpdk-dev] [PATCH 03/11] net/e1000: " Andrew Rybchenko
2019-06-05  8:15 ` [dpdk-dev] [PATCH 04/11] net/enic: " Andrew Rybchenko
2019-06-05  8:15 ` [dpdk-dev] [PATCH 05/11] net/fm10k: " Andrew Rybchenko
2019-06-10  2:05   ` Wang, Xiao W
2019-06-05  8:15 ` [dpdk-dev] [PATCH 06/11] net/i40e: " Andrew Rybchenko
2019-06-05  8:16 ` [dpdk-dev] [PATCH 07/11] net/iavf: " Andrew Rybchenko
2019-06-05  8:16 ` [dpdk-dev] [PATCH 08/11] net/ice: " Andrew Rybchenko
2019-06-05  8:16 ` [dpdk-dev] [PATCH 09/11] net/ixgbe: " Andrew Rybchenko
2019-06-05  8:16 ` [dpdk-dev] [PATCH 10/11] net/qede: " Andrew Rybchenko
2019-06-05  8:16 ` [dpdk-dev] [PATCH 11/11] net/vmxnet3: " Andrew Rybchenko
2019-06-05 22:45   ` Yong Wang [this message]
2019-06-11 14:44 ` [dpdk-dev] [PATCH 00/11] ethdev: " Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5367CB44-70FA-49D8-BC5F-E4A69D4C76C6@vmware.com \
    --to=yongwang@vmware.com \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).