From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ivan.boule@6wind.com>
Received: from mail-we0-f181.google.com (mail-we0-f181.google.com
 [74.125.82.181]) by dpdk.org (Postfix) with ESMTP id 0010E595A
 for <dev@dpdk.org>; Wed,  7 May 2014 15:12:10 +0200 (CEST)
Received: by mail-we0-f181.google.com with SMTP id w61so953264wes.40
 for <dev@dpdk.org>; Wed, 07 May 2014 06:12:16 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to
 :cc:subject:references:in-reply-to:content-type
 :content-transfer-encoding;
 bh=XkIRYjqoj8pVof14n38UFaBjHDdqljaCWMG5NgHhWqI=;
 b=GnRWEd223Hl+g6f1JK8Sr7QGTIu2Q0guS2PzY+8LePRhDpMpi9aVNug2dKsZn7ITWP
 o6fDoKgawgRRbdnDgUOAfzVCxs2RmybmTsBFuyO5z5OjABozQ4k1GW9bSQCQNhXcC78h
 gDYVhoIH/ObO7auCUNtLSslg5i/bm7We0ZYBIDeQJ1X57xDihCQ4GRWgwOyaad8Ucm3a
 HD4CKerEs3jNMb5nMwIkple7Lk4Xwffs4+dUDztoK6O/ObiVx0duX/GncAeNWJQaFF1f
 ni1juJB6Dbb+XxHRmAclV/BKygiNUd17aij1xyI5BS+tn4yjRup9qwMETs1mX5rQwhId
 nCqA==
X-Gm-Message-State: ALoCoQlBlgHwf9zrzFdpEyOElRANLVg74oTXEDns2WYyMv9ps8FjOHnnUJSPlA4LGz8Y2OLQnm4W
X-Received: by 10.194.193.74 with SMTP id hm10mr8364343wjc.13.1399468336696;
 Wed, 07 May 2014 06:12:16 -0700 (PDT)
Received: from [10.16.0.189] (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id h19sm31553454wiw.17.2014.05.07.06.12.14
 for <multiple recipients>
 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Wed, 07 May 2014 06:12:15 -0700 (PDT)
Message-ID: <536A312E.6010708@6wind.com>
Date: Wed, 07 May 2014 15:12:14 +0200
From: Ivan Boule <ivan.boule@6wind.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:24.0) Gecko/20100101 Icedove/24.4.0
MIME-Version: 1.0
To: Konstantin Ananyev <konstantin.ananyev@intel.com>
References: <1399386781-10788-1-git-send-email-konstantin.ananyev@intel.com>
In-Reply-To: <1399386781-10788-1-git-send-email-konstantin.ananyev@intel.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] Use proper mac type for 82576 VF
 e1000_vfadapt type corresponds to 82576 VF devices,
 check e1000_set_mac_type() for more details.
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 07 May 2014 13:12:11 -0000

On 05/06/2014 04:33 PM, Konstantin Ananyev wrote:
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> ---
>   lib/librte_pmd_e1000/igb_rxtx.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lib/librte_pmd_e1000/igb_rxtx.c b/lib/librte_pmd_e1000/igb_rxtx.c
> index 6b454a5..7fe1780 100644
> --- a/lib/librte_pmd_e1000/igb_rxtx.c
> +++ b/lib/librte_pmd_e1000/igb_rxtx.c
> @@ -2154,7 +2154,7 @@ eth_igbvf_rx_init(struct rte_eth_dev *dev)
>   		rxdctl &= 0xFFF00000;
>   		rxdctl |= (rxq->pthresh & 0x1F);
>   		rxdctl |= ((rxq->hthresh & 0x1F) << 8);
> -		if (hw->mac.type == e1000_82576) {
> +		if (hw->mac.type == e1000_vfadapt) {
>   			/*
>   			 * Workaround of 82576 VF Erratum
>   			 * force set WTHRESH to 1

Acked.

Thanks.

-- 
Ivan Boule
6WIND Development Engineer