From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id E9AC75593 for ; Wed, 25 Apr 2018 12:29:47 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4CD3C21BF0; Wed, 25 Apr 2018 06:29:47 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 25 Apr 2018 06:29:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=9y3fJJ+ILuNiIucyARop4W6hog m4erywj79efhe9PnI=; b=kgSrdpgk62uyRoqCdEJdQ6SCrNbozB4khg6k/wS03X qr3V6owIhrq6tLVEtN2ZLyDCpdniK2pBQ1X75z3J8sbcD3f2HHSnrEUmLFXv363+ 3a7G48sx7mh86vv1VRdSOvDYv+5cN1tiM49b6Kq8aUsVBd8srC/R0Z72P9uNpEKY s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=9y3fJJ +ILuNiIucyARop4W6hogm4erywj79efhe9PnI=; b=dQ+h+Rp17bdgg4p06AGeWm AUBAh3g5MQZ6px19VB8DURjlj8UK6d2Mt1pKwvlTHddw+SJEtV3ta9YZS0tS91ln rqQPI1B92P642lScyUeJ5mDpEprS0BFeUPrq5honfybGLfjHHRe/Q4YqnIwkJc6g f/+957uc2wRuGb7NT7m8aPOY2u9AiYynPuCXnvUm2F9jKGNciDaD34T388iUWCl8 aBR54445h02x2eWak7ljMXo4GKjHbARsfY2x6erx18x9JoVR+yBjHYza75Y6VP73 WeQ3Ajop3/qTX/vhuP7/qep6YTIDxVFTsN9WWKVh9/fNTyx5Y3DpabhilQggOcZg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AAA3EE5098; Wed, 25 Apr 2018 06:29:46 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org Date: Wed, 25 Apr 2018 12:29:45 +0200 Message-ID: <5375928.IW2qTYUPX7@xps> In-Reply-To: <8341c868-bab3-44b7-a870-bc07af9828db@intel.com> References: <20180424021511.17430-1-thomas@monjalon.net> <8341c868-bab3-44b7-a870-bc07af9828db@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] ethdev: remove experimental flag of ports enumeration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 10:29:48 -0000 25/04/2018 12:21, Ferruh Yigit: > On 4/24/2018 3:15 AM, Thomas Monjalon wrote: > > The basic operations for ports enumeration should not be > > considered as experimental in DPDK 18.05. > >=20 > > The iterator RTE_ETH_FOREACH_DEV was introduced in DPDK 17.05. > > It uses the function the rte_eth_find_next_owned_by() to get > > only ownerless ports. Its API can be considered stable. > > So the flag experimental is removed from rte_eth_find_next_owned_by(). > >=20 > > The flag experimental is removed from rte_eth_dev_count_avail() > > which is the new name of the old function rte_eth_dev_count(). > >=20 > > The flag experimental is set to rte_eth_dev_count_total() > > in the .c file for consistency with the declaration in the .h file. > >=20 > > A lot of internal applications are fixed to not allow experimental API. > >=20 > > Fixes: 8728ccf37615 ("fix ethdev ports enumeration") > > Fixes: d9a42a69febf ("ethdev: deprecate port count function") > > Fixes: e70e26861eaf ("net/mvpp2: fix build") > >=20 > > Signed-off-by: Thomas Monjalon >=20 > Getting some build errors [1], it seems some samples are using some other > experimental APIs so that we can't remove the flag for them. >=20 >=20 > [1] > .../dpdk/examples/tep_termination/main.c: In function =E2=80=98main=E2=80= =99: > .../dpdk/examples/tep_termination/main.c:1209:3: error: =E2=80=98rte_ctrl= _thread_create=E2=80=99 > is deprecated: Symbol is not yet part of stable ABI > [-Werror=3Ddeprecated-declarations] > ret =3D rte_ctrl_thread_create(&tid, "print-stats", NULL, > ^~~ >=20 > .../dpdk/examples/vhost/main.c: In function =E2=80=98main=E2=80=99: > .../dpdk/examples/vhost/main.c:1497:3: error: =E2=80=98rte_ctrl_thread_cr= eate=E2=80=99 is > deprecated: Symbol is not yet part of stable ABI [-Werror=3Ddeprecated-de= clarations] > ret =3D rte_ctrl_thread_create(&tid, "print-stats", NULL, > ^~~ Ah sorry, I think it is due to a change in next-net. I have prepared this patch on master. Please can you fix it when applying?