From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 9C3301B316 for <dev@dpdk.org>; Tue, 10 Oct 2017 17:48:09 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0B46520A6F; Tue, 10 Oct 2017 11:48:09 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Tue, 10 Oct 2017 11:48:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=M1D6498NmPe62R7 EMuT3Am7PN3l35mB9rSOFNM1xm4Q=; b=oX1tolzNS+0y0jOV2PEsq6sc2Ut1auR 1NEurt7JmgiQf8xjz2XIV11a3lAt64cgM9rgUA3jW6D4E8u5fWV/7XkJgK7pgmjn y1aaqYu1kCcTCDNgyFcUR90NO6TcOd3I1lSaLaFSxkLVFghQ44rtE0IbioqYLzfo nDk5YUSXxeQE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=M1D6498NmPe62R7EMuT3Am7PN3l35mB9rSOFNM1xm4Q=; b=G0kWQQ3S I8ZCnFC9Aoxngj7c58xg9W3euaOLIlUMHGQYvPimPJz+gjfrf0yzWCp0nbQezqV/ KIXRFZe5JQdVw/t/1Rp9YuOVf1J2Qs3tq3YFSfxrEUkHadto5o+6L2rtomq2trJ+ kJWGC0ZxXtZlwb969vra43/VVfLPCDhJ0aSUcPj3CP3yz3oaebB6S/Xs8Cl4erUE whvRU6IKLggdZ1tbWDRgF4xl/7Xwe3c1Pyr7s1X+lC4z9g7y8Wxe4Vi0ZsGUFv7k w76hx0mkUHrQ+1JO4UlwuwZfBvaVw0vG15DYH69q7d1uv3rePbZuGvCcJn2ud6G7 0ePWBFi4KRK9ig== X-ME-Sender: <xms:uOvcWQ2sAx0AZhrAMwub2atUelPkwxpDnHqPhvM-RXT_xgO3KGoMNw> X-Sasl-enc: aEM7+3K+pdCYPWEOtfAWr5X/hFmEyPuX4Nfmm3bannY8 1507650488 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B1EBA7E3DC; Tue, 10 Oct 2017 11:48:08 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Hemant Agrawal <hemant.agrawal@nxp.com> Cc: dev@dpdk.org, ferruh.yigit@intel.com Date: Tue, 10 Oct 2017 17:48:07 +0200 Message-ID: <5377044.W38hQe7MOC@xps> In-Reply-To: <1507644941-21660-1-git-send-email-hemant.agrawal@nxp.com> References: <1507644941-21660-1-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] drivers: update DPAA2 libs ABIVER and build reproducibility X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 10 Oct 2017 15:48:09 -0000 10/10/2017 16:15, Hemant Agrawal: > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com> > --- > drivers/bus/fslmc/Makefile | 3 ++- > drivers/crypto/dpaa2_sec/Makefile | 3 ++- > drivers/event/dpaa2/Makefile | 3 ++- > drivers/mempool/dpaa2/Makefile | 3 ++- > drivers/net/dpaa2/Makefile | 3 ++- > 5 files changed, 10 insertions(+), 5 deletions(-) Why are you changing LIBABIVER in all these libs? Generally speaking, a driver should not upgrade its ABI version, because it should have no interface. The ABI version must be changed in the patch breaking the ABI. If you do it later, it must be a fix with Fixes line. This way we will have the reference to the code breaking the ABI.