From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <Santosh.Shukla@cavium.com>
Received: from NAM02-CY1-obe.outbound.protection.outlook.com
(mail-cys01nam02on0059.outbound.protection.outlook.com [104.47.37.59])
by dpdk.org (Postfix) with ESMTP id BE77A1B03C;
Thu, 1 Feb 2018 10:30:19 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
bh=sOGhMkgOg0weZmOdNfMsu0e0hL41s92NJEpzxicIP8Q=;
b=I/c//6ljPhFGQZDVhl+H9OY4+xMbI2AAvPLXwrEU9fVDnHlA/9C0mpv1SQm7idA5xESwuz2V6lb7IiogQlUMA8m7WiT+dz3yeeufNrjvAzvAQwWgoWviZzKBkexNcg44M4fa/Y/KqOgLMLuLyH1zTpf4nOSA9Z/w0XgKmm3530s=
Authentication-Results: spf=none (sender IP is )
smtp.mailfrom=Santosh.Shukla@cavium.com;
Received: from [192.168.0.105] (103.76.56.167) by
BY1PR0701MB1894.namprd07.prod.outlook.com (2a01:111:e400:51ab::23) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Thu, 1
Feb 2018 09:30:15 +0000
To: Andrew Rybchenko <arybchenko@solarflare.com>,
Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, stable@dpdk.org, jerin.jacob@caviumnetworks.com
References: <1511539591-20966-1-git-send-email-arybchenko@solarflare.com>
<1516713372-10572-1-git-send-email-arybchenko@solarflare.com>
<1516713372-10572-2-git-send-email-arybchenko@solarflare.com>
<20180131164504.cnfgfwo2x3ftxnaj@platinum>
<d68cb16b-bfe9-083b-a83e-e40b8eb5aaa0@caviumnetworks.com>
<b10db3a0-0b41-af79-279f-1a967823fe8d@solarflare.com>
<90005aad-1508-44bc-92a4-7c5d5f7b0246@caviumnetworks.com>
<ab9fde30-b9af-f838-49c9-a4b59910afa9@solarflare.com>
From: santosh <santosh.shukla@caviumnetworks.com>
Message-ID: <53796b3f-b2c2-dcfc-a10b-71ce1a68d3d2@caviumnetworks.com>
Date: Thu, 1 Feb 2018 15:00:00 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <ab9fde30-b9af-f838-49c9-a4b59910afa9@solarflare.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Language: en-US
X-Originating-IP: [103.76.56.167]
X-ClientProxiedBy: BMXPR01CA0020.INDPRD01.PROD.OUTLOOK.COM
(2603:1096:b00:d::30) To BY1PR0701MB1894.namprd07.prod.outlook.com
(2a01:111:e400:51ab::23)
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e0f9011b-5680-4fb6-120b-08d569566803
X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0;
RULEID:(7020095)(4652020)(5600026)(4604075)(2017052603307)(7153060)(7193020);
SRVR:BY1PR0701MB1894;
X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1894;
3:B0o0i1b+5/BV4d228+eTbII1Umq1heYkHDaV6SAzFa8jZ9csu2Wr4lhBHm7dCIZx575QLtLm+BLb1H6rFv49NI64VcxPev6XopJG9LwKYEs9GQ0YQrl75U/m5QssxR8J7XYEgBGiPFTG5FbVd54Lpcop91xWDYuPWPgq9lDAdfOZ2AyW6/kME9VSbuKKKOdMN/PIh5/oG+2cllxlJZbwTG37pO678U8fkOSemRjcNldKoDgbEMEgT9ZPN37oNL6J;
25:zqy2oomo8ObHbalkkl60bVum1vCwlc+/X2rjIZjvdGxxbopOorj2ptIQpb4UtVZGMhF8WQMTqSN8Jd4GSk7leFXg1rEOH5a7adRMxQU5/rdNrB2E36M+gHKe2zIEqOyoOxkDSg1VZtsOyX73k0vTGJKdPdC7vE9TIJGdd8/1B+X5DkZfAAdhXno5G2TAm0ZWB/xqztm2tnhjb08YosWORRtaLMgniYh0MmeFSyD8FPHYgJ6q2prsUGN88yO59/EabcMUp8oKnWN8Pntwir1c66MfMfvcdk32lTAuWPHkLCYuXegth0MxCBf9YA2PZG2HMdi7Xn5Z4/RJA1dqUR0zVw==;
31:WRxOeIo0DqpVA//a9Dmy/gjkKEA+xY9WqTDTxAevLQ+2FYz41hoSNgDQ7gRS6SPELbYi5NQ/glnprxdur0SnGqx8nZgeO7tpXAnTvIrw6Ni4Q5/v+OACyncpb4YR3ajkwEF3uf4g/59OgigJ+Jn1ewyxV2vwa2+PZKXTKNztH6dFuW07MfO/dhM3wb5jsDa+l7XaJq9Scy68+cSEcFajiqXiGnWV6ekSEi4h4hQ8z30=
X-MS-TrafficTypeDiagnostic: BY1PR0701MB1894:
X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1894;
20:uRly2rkgtbgPVsXLw3yzx6YqvTAIix1x49MRomuSiNzifcdnuLr3SmsxtNidl74Qf8QFbFLVhCZMzlZQrbs9wmoil8r3a/kG39Blx5dTVl5t44cK+jSuBt1BP7si5EnPNwpelJ6tcRCbKywz+DuDnxWL7A+NyJmHaC1XhC5QXEj3icvKdegb+2I7t/jkH8LuFwPEBNw3rDieJZsnSn4F7iUBBgBTkco3O5jRJJxJuhPT6TQZ+igNIkXhoaXOZYeYJD072s8fYztEERAg4O4kCwGIISmBJTwrOH07t/q40z1kC7WrqBZkTldqmZl//ND81898WdiYKfsyqLLsEBE34QdkkBL11O34T9AoKXpuKSNpGg7QTJDikxGpGQEFOqDXt8rkwduovM0J9eDnIR9wU6z/8Eo+74+Z3nc+KXySt01/+vY9+NO8H2h/aBLczrnURFDTgHv1rthQ+uhV1LKC1F9aY69ComM5KiDu4pXlYi2c9n1XEQ3nJDBg4fYV5Y6bo/ZIDh5mLDSFsVkBCyzj5ZcaJsowWSDH67/tBdT5owg4jqDoDYdz7U6FBVYjP4hz/wd+6Ikay8J7ZJLoPkXvyBL0ghvogpq8G9FppnSI2ZA=;
4:IV9Tk6MWWIsaoXkmpIFnfJdzuL5/jpY4Jztb2TNDJGAI7nl620dDkx5v+pBD9Ani6omENgz9480XkcqmzoZfqHlBqmAEFWzBOZpOnmgDUKR1KJ1V2ervgdclnr0OzD9KoJo+hKib0zgd73279EWqCGhxih0WZC3opSkRdd0NmgOdqBy7G61spJOAMq1RZyK3IUAzsMPEsxDqnN1W+zXtXKdlAYIjpiPGENO/4//8CD227LG56ovF6hicUGFXyQ62mPqX072qWlFdrbM5sBQjeA==
X-Microsoft-Antispam-PRVS: <BY1PR0701MB1894079FA14219FC50439419EAFA0@BY1PR0701MB1894.namprd07.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:;
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
RULEID:(6040501)(2401047)(8121501046)(5005006)(93006095)(3231101)(2400082)(944501161)(3002001)(10201501046)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011);
SRVR:BY1PR0701MB1894; BCL:0; PCL:0; RULEID:; SRVR:BY1PR0701MB1894;
X-Forefront-PRVS: 0570F1F193
X-Forefront-Antispam-Report: SFV:NSPM;
SFS:(10009020)(6049001)(366004)(396003)(39860400002)(376002)(39380400002)(346002)(189003)(199004)(229853002)(86152003)(77096007)(106356001)(8936002)(8676002)(50466002)(2950100002)(65826007)(42882006)(6486002)(81156014)(81166006)(31696002)(47776003)(107886003)(66066001)(65806001)(65956001)(72206003)(5660300001)(16526019)(117156002)(64126003)(93886005)(6666003)(31686004)(25786009)(97736004)(83506002)(110136005)(316002)(2870700001)(53546011)(36756003)(386003)(52146003)(68736007)(76176011)(2486003)(23676004)(52116002)(59450400001)(58126008)(26005)(3846002)(53936002)(6116002)(2906002)(105586002)(6246003)(4326008)(16576012)(7736002)(305945005)(478600001);
DIR:OUT; SFP:1101; SCL:1; SRVR:BY1PR0701MB1894; H:[192.168.0.105]; FPR:;
SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en;
Received-SPF: None (protection.outlook.com: cavium.com does not designate
permitted sender hosts)
X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTFQUjA3MDFNQjE4OTQ7MjM6czl6Y2kvSWJQSmFvUThvamNwQ21kTXh2?=
=?utf-8?B?NmxFQ3ZvbmR1bFRYdExIcGduSnlIdjRad0dnS3Bsb2FpZFAxMm14Y0FtZkRa?=
=?utf-8?B?Vk1IZzJzSU9lYWVFMDgyM3NQWHp0WXdXc1BOenF6eEN0NUpQTnJiTCs3OEFM?=
=?utf-8?B?V21OZlltWVFnU2tNTkpuQWtrTVlhSmlIYXJnUHBJSVEvM2ZEdGZ5emVIbU5T?=
=?utf-8?B?bU41Yms5R2hXYWllRld0ZWFHeEF5L0U1dDQzaVNyY3BoSXlCaDJSbjlDckRN?=
=?utf-8?B?SkJVV0ZmeG1PcDdnMTA4QWd0dzJaOVI5ZEI4UUZzelVFVDJZNU44Y0lKR1Qr?=
=?utf-8?B?RG1yOWdwK0Q4YWsvTnJIYWh3NlZwTU9sZ3pHQzNoc1ZYVlB4ajlNWm9BWlov?=
=?utf-8?B?RkIxRzQ0YmhCK0hOWUM2NGltSWh3clQxb3VhdTNkZDcxNkJvMkVNbXhpaDEr?=
=?utf-8?B?SEg4Tkg3dU5teWV1MDlXaWhJR0V3cUkyeHBGNHg5Wml5V0piT3pjN3o5bVVa?=
=?utf-8?B?ckhNTzdYZXVnQ3JvMitQVm9Xa3VNTXZBVEpkUWc1cXRrSkpuckxBbWtjWlla?=
=?utf-8?B?TXIxK2VVbE1IbW41NGYxbnNxUk9pMmtLeldMT21XdkQxaXdTVjJhYy9LcVE3?=
=?utf-8?B?aTBNdXZmWGJuSjJYengrYXJHRWlQZGE3c2JIR2VPYkd1ZkRNcU53MDB0UGdR?=
=?utf-8?B?SDRlZE1rcGVHV0h2cW9BUnNKSEhHS1NkbEovQzlIbUNpdEZtQVdIMnRQd0xQ?=
=?utf-8?B?eE9HUEZjdDdsN1AyZ1MzelFIdmxFazE4VE85dUhaRHBlcjB0UXJaT1ZlUm82?=
=?utf-8?B?TlV1c1RpQzMyWVBCUmxTVnZKejVNSFd6VTlpUG9lRVFqN1MwV1NsSG1PWXV6?=
=?utf-8?B?Nk9TNmVXeVBkTVo1RGptRjFkd2J3KzRKUzU3SWw0SnQ5bjNOMUlIcnprSVBa?=
=?utf-8?B?SStHTHZLU1FVVHhyREkwNkZybEp3amJKejFjcG5WdTJJNmk2bFhIR1dZVUN1?=
=?utf-8?B?cWkyenVQRVdyZFA0Y1JWeWQxcHl0OHl5QnBXYy94QXlKK2haKzRKV0ZQMERW?=
=?utf-8?B?WmEvNm9Jc0t2T3N4Nkg3Z1B3SUREOTY0cUtucFJzR0V6bWw1L2Y5R0xQNW15?=
=?utf-8?B?OUQ1bHl6NkdmeGluUTgrYVZUSWJKenphamR1T0ZKdWFQT2lydXFXRmlNby8z?=
=?utf-8?B?Skc1RTFseWtFRHRkeWJFZi81azE4ZzBoSDErUWR4VEVJMnZxbnJ4dWFweU1r?=
=?utf-8?B?RUV3M1dxVTNuY1h6Yjg1cXhMa3lmVXZGdXZ1MFhGSEhHTHV1b0Vra1F0S2sv?=
=?utf-8?B?ZVdaTk1aUk93Y2liV0tNNk1mbkJDRFhPY3lCbVhGaDFyU3RKRmdyMDJKN0Z0?=
=?utf-8?B?d1lrYTN3S1M2ekd3WjZ2Mk1sb2hSUGplTGZ1NWw0VzNCTk9hL1ZPaWZ6U05x?=
=?utf-8?B?OEJkWXd2cDNmTjBpdSszT0xnWGNzZGdIM2laSkV1Q3JKZjhtWDZGbmdHdTlY?=
=?utf-8?B?SHZrME1NMlMwckp5TE8zcmZpMFBGMVBGSWV4Qlk1cGxUQnFnYzQyWENrRkdS?=
=?utf-8?B?MURIOVpJaFVWTkFhS3U4MXdQUlhYejF5NHFWNUxJbWczU0tuVXI0ZzNvWnFS?=
=?utf-8?B?WkZnS0Q0bWlQMTVuOVVGdVdtQW91WnFWMXFGWnMwS294ZG1mTjFDWUtoeDJ3?=
=?utf-8?B?YjNUMG04eTZsQ0QwaFN5bnpuN2ZrZ09nRzI5SGtmbWI5TlowLzhmQW9JR2dY?=
=?utf-8?B?d3NrVDVrbUJSWGE0WG1HZjBocTNHSEZQVjFpbU12bmoxb05pMzlNSUlmVTBY?=
=?utf-8?B?c29vMDFCMGhXQklkTXlvNzMrOGh4Nkl6eVE2OGdTamRuUDJma2VqOHJTdFhH?=
=?utf-8?B?SEIyaWdkUUMvVzYrMXVoR05OYnUyeWV0VGJTUGttbkRDcU1zTmxzU3Y2d1lz?=
=?utf-8?B?VXFkWjh5RWw5Q1VpbE8wZ05ZSTZJRHZRc0phL0J6RGQ2ZUNvWGhqOUdpcHJH?=
=?utf-8?B?OTUxcUNCTGZiN2FkOTNGREVFQVRkOHBkN3NIUjJBPT0=?=
X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1894;
6:UNU8ijcTKfyXDYpgs8UzHoovlI1HyhwnozBiE98JbeZjOoPwMA69ea5+lbT9C5YLbScnXLIYNgAP8QbWufi37quaERtOe7ytaNmv+UoKwScqYMkBAAJHWoX+0jMwMQ/mdbHt7d+68syQWxU4SsxCgfxZiUvlRro7hKVLQt4CyQQ3QL7keo7QyX5FtxDxcOkBPklFMfUvUQhN5tV82LRcchmZRx/xxYuT7c2F4wCfMesD/hkwfB9fy84e/QrdiEihFzkQKmCBvGZom67R2EQO5n0dXGXy/+slsiub+ILt/4v4bz84Yi6QawF+g3d6f5FWSoiXtTkCR+W+TibtyO3BPI/OGIOLLo1EHLnPZZQwTuo=;
5:ICmiK33kaTpfqL9DkOWLWQmF1BnDPAlNJ7VdNIGGYwI0ZqGvSe045NOUiRg3xshg4F61GUoLtQGyIdzKh5vGMKeebSmautrjS8iZzOX/1DOcHVtQ1ZvQBMqzkZXR2J4V+8t+t3tW2G1ifytL78cq61u0X97WG0StAXkbD8JfKg0=;
24:H1jHdFKfwv3EgrmMIG0XYhgC748zK4xEj1eZ5NQRkYI8bLgchynsOvssBX4K8N9U03b4g8tMOhCqoM2cpVn3xnBRsu7o9pQEK0QlBsTmN0A=;
7:ifTjy8batePXZjrit7VgPNuv6/aKOUT1dMj3yqZeDpNdDKCOtxTyHImB8gO8yDnTzvEQE5JppJAQ51aN7eZF9lWUzMK3t/lspfQKc9iWs9xQnOe9DNfcsUkGqcIX2UfD8WHP/YTda+MMF49G/d9zoHqXl5/QccdSfC9I7E/0jPGVTMHFGREAQsMZAtXUa/0ag4Qa59vPglKdMnFiaGMBvdUXAEYdA1tHJx9uQyG15yxtQznf7z7xgxECg4/2qD4j
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-OriginatorOrg: caviumnetworks.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2018 09:30:15.4522 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e0f9011b-5680-4fb6-120b-08d569566803
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0701MB1894
Subject: Re: [dpdk-dev] [RFC v2 01/17] mempool: fix phys contig check if
populate default skipped
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Feb 2018 09:30:20 -0000
On Thursday 01 February 2018 02:48 PM, Andrew Rybchenko wrote:
> On 02/01/2018 12:09 PM, santosh wrote:
>> On Thursday 01 February 2018 12:24 PM, Andrew Rybchenko wrote:
>>> On 02/01/2018 08:05 AM, santosh wrote:
>>>> On Wednesday 31 January 2018 10:15 PM, Olivier Matz wrote:
>>>>> On Tue, Jan 23, 2018 at 01:15:56PM +0000, Andrew Rybchenko wrote:
>>>>>> There is not specified dependency between rte_mempool_populate_default()
>>>>>> and rte_mempool_populate_iova(). So, the second should not rely on the
>>>>>> fact that the first adds capability flags to the mempool flags.
>>>>>>
>>>>>> Fixes: 65cf769f5e6a ("mempool: detect physical contiguous objects")
>>>>>> Cc: stable@dpdk.org
>>>>>>
>>>>>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>>>>> Looks good to me. I agree it's strange that the mp->flags are
>>>>> updated with capabilities only in rte_mempool_populate_default().
>>>>> I see that this behavior is removed later in the patchset since the
>>>>> get_capa() is removed!
>>>>>
>>>>> However maybe this single patch could go in 18.02.
>>>>> +Santosh +Jerin since it's mostly about Octeon.
>>>> rte_mempool_xmem_size should return correct size if MEMPOOL_F_CAPA_BLK_ALIGNED_OBJECTS flag
>>>> is set in 'mp->flags'. Thats why _ops_get_capabilities() called in _populate_default() but not
>>>> at _populate_iova().
>>>> I think, this 'alone' patch may break octeontx mempool.
>>> The patch does not touch rte_mempool_populate_default().
>>> _ops_get_capabilities() is still called there before
>>> rte_mempool_xmem_size(). The theoretical problem which
>>> the patch tries to fix is the case when
>>> rte_mempool_populate_default() is not called at all. I.e. application
>>> calls _ops_get_capabilities() to get flags, then, together with
>>> mp->flags, calls rte_mempool_xmem_size() directly, allocates
>>> calculated amount of memory and calls _populate_iova().
>>>
>> In that case, Application does like below:
>>
>> /* Get mempool capabilities */
>> mp_flags = 0;
>> ret = rte_mempool_ops_get_capabilities(mp, &mp_flags);
>> if ((ret < 0) && (ret != -ENOTSUP))
>> return ret;
>>
>> /* update mempool capabilities */
>> mp->flags |= mp_flags;
>
> Above line is not mandatory. "mp->flags | mp_flags" could be simply
> passed to rte_mempool_xmem_size() below.
>
That depends and again upto application requirement, if app further down
wants to refer mp->flags for _align/_contig then better update to mp->flags.
But that wasn't the point of discussion, I'm trying to understand that
w/o this patch, whats could be the application level problem?