From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 422A5A0A0B; Mon, 1 Feb 2021 14:03:29 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B656B40693; Mon, 1 Feb 2021 14:03:28 +0100 (CET) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by mails.dpdk.org (Postfix) with ESMTP id 3C92F40687 for ; Mon, 1 Feb 2021 14:03:27 +0100 (CET) X-Originating-IP: 78.45.89.65 Received: from [192.168.1.23] (ip-78-45-89-65.net.upcbroadband.cz [78.45.89.65]) (Authenticated sender: i.maximets@ovn.org) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 9F85D240008; Mon, 1 Feb 2021 13:03:23 +0000 (UTC) To: Ilya Maximets , Maxime Coquelin , dev@dpdk.org, chenbo.xia@intel.com, olivier.matz@6wind.com, amorenoz@redhat.com, david.marchand@redhat.com, Ian Stokes , Kevin Traynor , Flavio Leitner References: <20210126101639.250481-1-maxime.coquelin@redhat.com> <971e37fb-3889-ee94-c45c-e05f51b036ba@ovn.org> Cc: ovs-dev From: Ilya Maximets Message-ID: <5379d25e-e33f-4dae-f53b-b57c00da3d64@ovn.org> Date: Mon, 1 Feb 2021 14:03:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <971e37fb-3889-ee94-c45c-e05f51b036ba@ovn.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 00/44] net/virtio: Virtio PMD rework X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" CC: ovs-dev On 2/1/21 2:00 PM, Ilya Maximets wrote: > On 1/26/21 11:15 AM, Maxime Coquelin wrote: >> >> Only functionnal change in this second part is making the >> Vhost-user server mode blocking at init time, as long as >> a client is not connected. The goal of this change is to >> make the Vhost-user support much more robust, as without >> blocking, the driver has to assume features that are going >> to be supported by the client, which is very fragile and >> error prone. As a side-effect, it also simplifies the >> logic nin several place of the virtio-user PMD. > > Hi, Maxime. > > I didn't actually look at the code, but I have a question. > Does above text mean that with this change OVS will hang inside > driver_register() or similar function until client is connected > to dpdkvhostuser (server mode) port? > > If so, I think, we will not be able to support server mode > in OVS anymore and will have to actually remove it. It's > deprecated for a long time now, but I think it might still be in > use by some people, especially for virtio-user usecase. > > Best regards, Ilya Maximets. >