From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2BA05A0542; Wed, 5 Oct 2022 16:22:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1694542685; Wed, 5 Oct 2022 16:22:08 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2076.outbound.protection.outlook.com [40.107.94.76]) by mails.dpdk.org (Postfix) with ESMTP id 55F5F40143 for ; Wed, 5 Oct 2022 16:22:07 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cx9CD5S50jnCfRwJzMJTZ2MQ3X9qqt0CBjeZ9u2cXndwpW5nUuMW25QTui4P2sX/kgiHEIe4S0DxV+zw5kVoFutz7KeUuZohLkz0mRuQAu48bM/AelBCB4pA0tPQHtUmAvRKW02Qrq2FbLSwwxi6O0ngtbeE+xmM1v8OODVbA/vVmwp30zfz2Z3Hww1leGHwBqV4r3myUwD4IJfBWQE6zFTI0R0KD+cW25h1fHFu8/vKuL5vr5R6IVD5XaTNrO3mS0bwpqvwHn7sVrJcUaPXheL5qUrTeo5OFAzdAjFVXJ/Yh2DxY31NOmCieLWkr6VmUaiAJQEVdOdVR8bIBs2Xlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3zgOvWRuJ2uxJJhj93Ow8kQbsusldqNMZOqPMAyymBM=; b=Umpu6eplgtMuDZwua29SnA+rg/sLv93de3/lluCMQV3/ppPS/TiogEa0TvCOpw19ZPdTLWgswgwDuKCa5AAxThpPT9zOFaoMQpyaap8in/mpSRm7khiDsbuIjRa57SkaSKNxwx7QTe2yHatyW3TjmQCXYst0OTivnCA3zeXYBDASLaADZfwmr3AFHRaR6IXw7h3yLBX1VPtKAXrLDIlL702OH92youAxuMaUMMTTrre8fdBBH8EylVVkorQHaN5UW41CXpFqgWrWXTvfxAL4dK3YIdieTTC7ou8KQ+dFccq4G0qUtWYTa4BNuhJolfCKY/oSsaNOwvuDozNN2UQsJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3zgOvWRuJ2uxJJhj93Ow8kQbsusldqNMZOqPMAyymBM=; b=H1bDKY/a5D1a3F18ud/1pHl98wYvcqcsJcWAxCOKadTgS5V3nsugxd4wS+jskjJKGWXTB3SFzb6aVWNluaos3vx0OnQjsnuksA/AuGYDyGfbx2YVNCZQ2vnoYLeSu1MZJeGiZ9enVW719butwPVy15Vni778DZeZnlFKT6gmL30= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM6PR12MB4465.namprd12.prod.outlook.com (2603:10b6:5:28f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Wed, 5 Oct 2022 14:22:05 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::d07a:463f:6f93:337f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::d07a:463f:6f93:337f%7]) with mapi id 15.20.5676.032; Wed, 5 Oct 2022 14:22:05 +0000 Message-ID: <5386c035-1114-1366-7820-f7f73b78c3f8@amd.com> Date: Wed, 5 Oct 2022 15:21:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH 11/15] bus/dpaa: pass interface name as a string instead of pointer Content-Language: en-US To: Gagandeep Singh , dev@dpdk.org Cc: Rohit Raj References: <20220928052516.1279442-1-g.singh@nxp.com> <20220928052516.1279442-12-g.singh@nxp.com> From: Ferruh Yigit In-Reply-To: <20220928052516.1279442-12-g.singh@nxp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR1P264CA0057.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:2ca::7) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM6PR12MB4465:EE_ X-MS-Office365-Filtering-Correlation-Id: c88c590c-760f-446a-c5d1-08daa6dcfa58 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dsr+HCdC2Qujs2IW0H6eqTrbKL3cWODhKxj1FtWhJ8WLTYe3AC+wOIv0p8eX+t3+GcZFTnNavg7t76npFHjDiijsdoZTGTLkhAiRjJWuoNbxxoropAlf550XpUW67fwB+Pz+hT//5fFuPoW7SL8x7TVJjhl2Z+D9viu4XGar80s54ZZC/xrrX8jMw8TKzBrs7sKXHBrl0FKQkO3pNYXXQ671yDyEW9oTap8RBlRexDKC3eixqUPJJD+p2YR/61jvlztOHI+54sSchLoRdOW6DYpi0kB09vfeAs01CQtkw+3vGYcVTtOghb/9GYPWY4bgc1t4EA2k+/EEFYpDzjF7LM38cbsYtf1u8tsiP2OO5oP8FFCSIbDY+nWuExa/8UUdDAcQU78dLk70HYVMy+Bw0WFQhlSCXVUeJfbmLUjJDjmshEQYk6+NLp3nLTNz+ZmaJC8gfv66JzZ66vZNueNpSEnGRVdAi7BenadkO7RqsnjPnRoaW6fbC6e05yjOpvX1g0f1DWnzD3qAQP9jAhQuW5HbJUOU819DuLvKePkgQzRz0yHH33s2dr6nxKa1eLk5DfZ7AT5P1Lts/V2vk+jnQqF31NnKNZBpCYOU1wvmRCEO6SJnPGN8JNO7d3wpRCbg6pcu+ay2nGm2FSG37YfFXqlU9CbQUNmIIbgKeWg6R0LAB6PnfXo2jXpih5+hWNyQYvvmL42+P+/JVMU6a5bM4+I3s34TM7ngSbqsP0Ibl1YwGWOM/RZ02G22pE58+tXhKDTfbvL4JzHvWH32zspuE8zKjkwk/krFoiqJftDfBTQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(136003)(366004)(376002)(346002)(39860400002)(396003)(451199015)(8676002)(66556008)(66476007)(4326008)(66946007)(316002)(186003)(44832011)(86362001)(8936002)(478600001)(6486002)(5660300002)(31696002)(41300700001)(38100700002)(2616005)(2906002)(6512007)(26005)(31686004)(83380400001)(36756003)(6666004)(6506007)(53546011)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dEh0UnlTNHZMMTNlM3FJT2orYW1IRlpXSmpXL3BjSjhqblN4L0sxdWY4TDU5?= =?utf-8?B?c1d4dHZkV2hCcy9qUFhBZXUzSVRWdU1aUWU1U3djWmduSExLc2lTWTN0ejJo?= =?utf-8?B?RVFZT2YzM1BCbE02c2t6Uy9JZWJlbTBUaHBNUkJoM1VMaDR3MVdUdW5rWklX?= =?utf-8?B?dTFEUjBMOUhycDVMc1JlYWR1TlVMQ2VMazdEa1FwR2psQmZKTE5tU0x4SVlP?= =?utf-8?B?Y1pBU3hyeXZJV2R2dUxmZ09yOWYwcnBycjVnZUlOSFQ0TExGL3A5TFlsaERq?= =?utf-8?B?Y0V2VG9jV1dQVXEyVWM4WXF4T08wOU12VmlObzMxYldad251c1Nha1o3aExk?= =?utf-8?B?WlVqeFBESFNZa0JFVlFBUE4zSXYwWW9hdUpUK0NkYThLR2YwU2pnZEdaN3ZP?= =?utf-8?B?bXhBSlhtVmwrV2syTFpoZ3RpSWRxazhpVncrWFpmdEtkOEF5L3VNZk9DNE1o?= =?utf-8?B?TU1DYjhVWWVUTnNQYUR1L3JhWUpmZFJxS0xmMC9qeWJqazJ4bjM2ejQwVnhH?= =?utf-8?B?d25yNzBxTys5OFhrUDhKTlI5cHo3ZEpXbkdkbmRNcVdaRTM1UTNlMFhEZkc5?= =?utf-8?B?K3RNc2ZxZVVybnVWNFo0SnhMSWdnem83UVNWWmdIbnFyai9kTlA2ZHdUNzRz?= =?utf-8?B?OXgxc1orTFN4YlhscGpPbzBpRXE2alFkazBSSkJMTlBBK1VrK3RHTDhSemJQ?= =?utf-8?B?eThuTThIOEEvZTZ5MnVlZlJEaFlaV0Ivdk1saUcwTEkzcmVmY3R6a1lCZ2g0?= =?utf-8?B?R2FkbXRSVlNWVzRTRUR3bGZDMkRkU2I0a2dFcmJDdjVLMmF5alJRSzFUQzZK?= =?utf-8?B?NXFRR0toS0R3My9HNEZTblVOcDZwdi81N1ZFWmlQY0N1RFNQVjR1TklxS21V?= =?utf-8?B?c0cyRjNRVGRNc1hrL1ZEdE5PS29tYzgxeUhMR1pFN0ZTYjk2MUh4QVFUaWo1?= =?utf-8?B?ZTI2YlNmWjZmWVNXNy8yZzNsZUpBRTJScVJVaGZGWHpqdGkyTGsydDdhdDA2?= =?utf-8?B?S0lOSHFjRWEzbnZWVSthMk9LMXd1V0NjY0M0T09zTE1LWUM5RFYrdzk4MUdY?= =?utf-8?B?V0VMdHI5bUJrNHZyWnpkN3d3TjFSanUyZVR4ZklDdE9PMjFlRG5qclJ4Y3RL?= =?utf-8?B?V2pXOVRSK3UwSENyMWQ1cDFDY1hob2V1bnIxd09LWm92RHdPV1ppUE5WSThU?= =?utf-8?B?ODdOaXp6WDZEWmJJRmcyck02NXg0eWFsa0l5R1NEWjdkZzFvN3Z2RzcvbFFW?= =?utf-8?B?SEt1S3BRZG1pU1hjWU1MOTBZbFpJRlVaUzVpUW1Db0doeDcwM3RQeE9hNjMv?= =?utf-8?B?TEhNVmpaeWRKVjN4ZzhaYXlYVnU4S04rL0phSHlmQTJiSVlKaUYrdXVZc2tO?= =?utf-8?B?K28zVWVJUmJuQlVYY1NWVm80RExpWklhOEV1OTVPWDdqMitJY3BDQWVSQ0k1?= =?utf-8?B?UDI1VlVYU1BZd2RRZmpWdXlBdGZEWmYvRWtNUzVaYkZoaUo3TDZpQzZUMGVz?= =?utf-8?B?RVh6MUtyNk1MdFdmYk5hWTNJTVkrZlNHT2tIQzJrVDZJQVp6UGhOUXZsQWta?= =?utf-8?B?Q05MeTdob0xVaTc1TWdmT3B6ZHI5SmpxZ25HMjBnUHBBUlZWajFFTFlUS2ln?= =?utf-8?B?eDIvUy9zcFBkOHMxOENRTlVBWnQvZ09Xb20wQ0FCb0N3QldpTlNzcm0rTFhN?= =?utf-8?B?NlJFVldqa2xBVXZncllQWStwRk1EUjVJdXlXZ3lUNkJXRGZYbVE1MlJqZnA4?= =?utf-8?B?OHprZWN2b1B6QkxpWk9MRDdidE5iQUpuUGFXK2JiZHg4b08rN3Judld4Ritq?= =?utf-8?B?OE9MNEV3RWo0YjRYYmNNdXdjK2lJYy9lbmcxUnp6b0lBQkRWUllEcCt6Y2p6?= =?utf-8?B?L3RQT21jakJ1aE9mSkhrQUtrc0xCZEZKQXFtdFFUakpBNWM2SHRGM2pmK2NG?= =?utf-8?B?R0JmNFAvWSt2Um1YUk53ZXFxOFB3SGF5eC9GQ1NXWGN2aVJ4Tyt1eVZ1WUZt?= =?utf-8?B?ek1taUtQVm9IUWo5ZktFWTA0elZHMGwrTllIZlZaZDRkbXU2WGRGUWRMZFYr?= =?utf-8?B?YndXZjZaVENTUzEyRTVQdmRtcEVEaVBZRGRTL0c4RTl5SS9nb3d6VVBsajFL?= =?utf-8?Q?bhtorkJw//+2wvg8a+0f09HH7?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c88c590c-760f-446a-c5d1-08daa6dcfa58 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2022 14:22:05.1202 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: amdk3AZ/9+zK3jZNLyRl0xjeWaeLH93AFTKqJUDql3n7dMBrmTlaFSgle9jMAcpj X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4465 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/28/2022 6:25 AM, Gagandeep Singh wrote: > From: Rohit Raj > > Due to change in latest kernel, passing the interface name to > kernel through IOCTL as string instead of character pointer. > This kernel component is the one that is delivered part of SDK I assume, instead of an upstreamed one. What is the way for user match kernel code and DPDK driver, like is there any matching version information documented? > Signed-off-by: Rohit Raj > --- > drivers/bus/dpaa/base/qbman/process.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/bus/dpaa/base/qbman/process.c b/drivers/bus/dpaa/base/qbman/process.c > index 9bc92681cd..3504ec97db 100644 > --- a/drivers/bus/dpaa/base/qbman/process.c > +++ b/drivers/bus/dpaa/base/qbman/process.c > @@ -302,7 +302,7 @@ int bman_free_raw_portal(struct dpaa_raw_portal *portal) > _IOW(DPAA_IOCTL_MAGIC, 0x0E, struct usdpaa_ioctl_link_status) > > #define DPAA_IOCTL_DISABLE_LINK_STATUS_INTERRUPT \ > - _IOW(DPAA_IOCTL_MAGIC, 0x0F, char*) > + _IOW(DPAA_IOCTL_MAGIC, 0x0F, char[IF_NAME_MAX_LEN]) > > int dpaa_intr_enable(char *if_name, int efd) > { > @@ -330,7 +330,7 @@ int dpaa_intr_disable(char *if_name) > if (ret) > return ret; > > - ret = ioctl(fd, DPAA_IOCTL_DISABLE_LINK_STATUS_INTERRUPT, &if_name); > + ret = ioctl(fd, DPAA_IOCTL_DISABLE_LINK_STATUS_INTERRUPT, if_name); > if (ret) { > if (errno == EINVAL) > printf("Failed to disable interrupt: Not Supported\n"); > @@ -472,7 +472,7 @@ int dpaa_update_link_speed(char *if_name, int link_speed, int link_duplex) > } > > #define DPAA_IOCTL_RESTART_LINK_AUTONEG \ > - _IOW(DPAA_IOCTL_MAGIC, 0x13, char *) > + _IOW(DPAA_IOCTL_MAGIC, 0x13, char[IF_NAME_MAX_LEN]) > > int dpaa_restart_link_autoneg(char *if_name) > { > @@ -481,7 +481,7 @@ int dpaa_restart_link_autoneg(char *if_name) > if (ret) > return ret; > > - ret = ioctl(fd, DPAA_IOCTL_RESTART_LINK_AUTONEG, &if_name); > + ret = ioctl(fd, DPAA_IOCTL_RESTART_LINK_AUTONEG, if_name); > if (ret) { > if (errno == EINVAL) > printf("Failed to restart autoneg: Not Supported\n");