[dpdk-dev] [PATCH] app/testpmd: remove function after refactoring

[dpdk-dev] [PATCH] app/testpmd: remove function after refactoring

[Bernard Iremonger]

Call the pkt_fwd_config_display function directly now,
and remove the fwd_config_display wrapper function.

This patch depends on the following patch set

[dpdk-dev,v5,1/9] app/testpmd: add new function

Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
---
 app/test-pmd/cmdline.c | 2 +-
 app/test-pmd/config.c  | 9 +--------
 app/test-pmd/testpmd.h | 2 +-
 3 files changed, 3 insertions(+), 10 deletions(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 44a56f0..73a5a47 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -5424,7 +5424,7 @@ static void cmd_showcfg_parsed(void *parsed_result,
 	else if (!strcmp(res->what, "cores"))
 		fwd_lcores_config_display();
 	else if (!strcmp(res->what, "fwd"))
-		fwd_config_display();
+		pkt_fwd_config_display(&cur_fwd_config);
 	else if (!strcmp(res->what, "txpkts"))
 		show_tx_pkt_segments();
 }
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 47acbf6..24eac3c 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -1381,7 +1381,7 @@ fwd_config_setup(void)
 		simple_fwd_config_setup();
 }
 
-static void
+void
 pkt_fwd_config_display(struct fwd_config *cfg)
 {
 	struct fwd_stream *fs;
@@ -1420,13 +1420,6 @@ pkt_fwd_config_display(struct fwd_config *cfg)
 	printf("\n");
 }
 
-
-void
-fwd_config_display(void)
-{
-	pkt_fwd_config_display(&cur_fwd_config);
-}
-
 int
 set_fwd_lcores_list(unsigned int *lcorelist, unsigned int nb_lc)
 {
diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
index 50f81d7..df66d8d 100644
--- a/app/test-pmd/testpmd.h
+++ b/app/test-pmd/testpmd.h
@@ -472,7 +472,7 @@ void port_infos_display(portid_t port_id);
 void rx_queue_infos_display(portid_t port_idi, uint16_t queue_id);
 void tx_queue_infos_display(portid_t port_idi, uint16_t queue_id);
 void fwd_lcores_config_display(void);
-void fwd_config_display(void);
+void pkt_fwd_config_display(struct fwd_config *cfg);
 void rxtx_config_display(void);
 void fwd_config_setup(void);
 void set_def_fwd_config(void);
-- 
2.6.3

Re: [dpdk-dev] [PATCH] app/testpmd: remove function after refactoring

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: Iremonger, Bernard
> Sent: Wednesday, June 15, 2016 11:20 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo; Iremonger, Bernard
> Subject: [PATCH] app/testpmd: remove function after refactoring
> 
> Call the pkt_fwd_config_display function directly now,
> and remove the fwd_config_display wrapper function.
> 
> This patch depends on the following patch set
> 
> [dpdk-dev,v5,1/9] app/testpmd: add new function
> 
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Re: [dpdk-dev] [PATCH] app/testpmd: remove function after refactoring

[Thomas Monjalon]

> > Call the pkt_fwd_config_display function directly now,
> > and remove the fwd_config_display wrapper function.
> > 
> > This patch depends on the following patch set
> > 
> > [dpdk-dev,v5,1/9] app/testpmd: add new function
> > 
> > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Applied (actually squashed in above series), thanks