From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f182.google.com (mail-we0-f182.google.com [74.125.82.182]) by dpdk.org (Postfix) with ESMTP id C508847D2 for ; Mon, 23 Jun 2014 11:26:36 +0200 (CEST) Received: by mail-we0-f182.google.com with SMTP id q59so6474061wes.41 for ; Mon, 23 Jun 2014 02:26:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=2+JkPY7rr3PtvqvANH7WFqmkplc0sD/w1kRJYEDmoBo=; b=cezYawzVrRYrhlegqdKF62oJMSfwMgyENV6mDehtiBCy9hwr7qwgOC8uaum3RsLEcJ S31kzTk/ZtvVc+x0tYjcuguqVND0tS9LRRiho5hZz+aIt5+sUb/c3Vfk13xLtwgK9WJ9 hm+ZbXZqA9agNlBLu/VaL1eLnlZ1ZFJEUg+DDG6Rg3ROrF4W5cUrC1/kmIH4b/rULuyy nhG9n6vh9UKxPDg/LLiskF5VX5jerWQdn21j7DLJHPre04CP7SbHRKMI5hB1GMFztNDb 1xAEqPbVDWvtZ7HiQL8qE4LkUEDeJBo9+0G4MxUPFKF3suJML55WchLQa5NLNDLyt5J3 YUzw== X-Gm-Message-State: ALoCoQmllQbucuoACgWFHoZtGNzx5nqAgW0s6cBSvO0opfzDJEc4/oMIA+cEDr6UUOVYPpaiGQtr X-Received: by 10.194.223.67 with SMTP id qs3mr26412882wjc.66.1403515614814; Mon, 23 Jun 2014 02:26:54 -0700 (PDT) Received: from alcyon.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id vp5sm35043368wjc.31.2014.06.23.02.26.53 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 23 Jun 2014 02:26:54 -0700 (PDT) Message-ID: <53A7F2D6.50803@6wind.com> Date: Mon, 23 Jun 2014 11:26:46 +0200 From: David Marchand User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.6.0 MIME-Version: 1.0 To: "Liu, Jijiang" References: <1403028572-24794-1-git-send-email-david.marchand@6wind.com> <1403028572-24794-3-git-send-email-david.marchand@6wind.com> <1ED644BD7E0A5F4091CF203DAFB8E4CC01D3B9A6@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <1ED644BD7E0A5F4091CF203DAFB8E4CC01D3B9A6@SHSMSX101.ccr.corp.intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 2/7] ethdev: add autoneg parameter in flow ctrl accessors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jun 2014 09:26:36 -0000 Hello, On 06/23/2014 05:35 AM, Liu, Jijiang wrote: > There was an error when we used the following test command to test latest master branch for 10G NIC flow control > test command: > ./x86_64-native-linuxapp-gcc/app/testpmd -c f -n 4-- -i --burst=1 --txpt=32 --txht=8 --txwt=0 --txfreet=0 --rxfreet=64 --mbcache=250 --portmask=f > testpmd> set flow_ctrl rx off tx off 300 50 10 1 mac_ctrl_frame_fwd on 0 > bad flow contrl parameter, return code = -95 > > And the reason is that autoneg check failed in ixgbe_flow_ctrl_set() function. > if (fc_conf->autoneg != !hw->fc.disable_fc_autoneg) > return -ENOTSUP; Ok, indeed, there is a problem with the autoneg field I added. I will try to send a fix, but I am a bit short on time (and I will be offline for a week starting thursday), so if you have a fix before me, feel free to send it. -- David Marchand