From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 1AAD22C60; Fri, 24 Aug 2018 14:28:28 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Aug 2018 05:28:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,281,1531810800"; d="scan'208";a="67564704" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.56]) ([10.237.221.56]) by orsmga007.jf.intel.com with ESMTP; 24 Aug 2018 05:27:38 -0700 To: Alejandro Lucero , dev@dpdk.org Cc: stable@dpdk.org References: <1535109359-48584-1-git-send-email-alejandro.lucero@netronome.com> <1535109359-48584-2-git-send-email-alejandro.lucero@netronome.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <53aa42d1-0c1c-e2e6-643c-be50e1c9873d@intel.com> Date: Fri, 24 Aug 2018 13:27:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1535109359-48584-2-git-send-email-alejandro.lucero@netronome.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/3] ethdev: fix MAC changes when live change not supported X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2018 12:28:29 -0000 On 8/24/2018 12:15 PM, Alejandro Lucero wrote: > Current code assumes a MAC change can occur when the port has been > started. In fact, there are some NICs which require this port state > for being successful, but other NICs not always support MAC change > in that case. > > This patch supports a new device flag for a device advertising this > limitation, and if the flag is set, the MAC is changed before the > port starts. > > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org > > Signed-off-by: Alejandro Lucero <...> > @@ -2839,6 +2841,10 @@ int rte_eth_dev_mac_addr_add(uint16_t port_id, struct ether_addr *mac_addr, > /** > * Set the default MAC address. > * > + * A NIC not supporting MAC change after started should set > + * RTE_ETH_DEV_NOLIVE_MAC_ADDR and this function should check such a flag > + * and NIC state. > + * Only rte_eth_dev_start() API effected from this change, API behavior changes based on if PMD provides this flag or not, I was thinking to document this in rte_eth_dev_start(), something like: "Driver RTE_ETH_DEV_NOLIVE_MAC_ADDR flag cause MAC address to be set before start dev_ops" As you mentioned in cover letter, rte_eth_dev_mac_addr_add() will return an error if not supported, this is not changed with RTE_ETH_DEV_NOLIVE_MAC_ADDR flag, so I think no need to add this comment.