DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
	Beilei Xing <beilei.xing@intel.com>,
	Qi Zhang <qi.z.zhang@intel.com>
Cc: dev@dpdk.org, konstantin.ananyev@intel.com
Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix Tx fn selection when using new ethdev offloads
Date: Tue, 1 May 2018 16:48:26 +0100	[thread overview]
Message-ID: <53ab5a81-b9ac-ea49-733c-20d39398afbd@intel.com> (raw)
In-Reply-To: <33c051c4-a338-ba1e-749c-e0b12bd1414d@intel.com>

On 5/1/2018 3:37 PM, Ferruh Yigit wrote:
> On 5/1/2018 3:16 PM, Bruce Richardson wrote:
>> On Tue, May 01, 2018 at 03:13:54PM +0100, Bruce Richardson wrote:
>>> The Tx function selection code in the driver only used the older txq
>>> flags values to check whether the scalar or vector functions should be
>>> used. This caused performance regressions with testpmd io-fwd as the
>>> scalar path rather than the vector one was being used in the default
>>> case. Fix this by changing the code to take account of new offloads and
>>> deleting the defines used for the old ones.
>>>
>>> Fixes: 7497d3e2f777 ("net/i40e: convert to new Tx offloads API")
>>>
>>> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>>> ---
>> Apologies: forgot to add:
>>
>> v2: eliminate mask for offload flags, and use vector path only if 
>>     offloads == 0
>>
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.

  reply	other threads:[~2018-05-01 15:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-01 13:03 [dpdk-dev] [PATCH] " Bruce Richardson
2018-05-01 13:24 ` Ananyev, Konstantin
2018-05-01 13:28   ` Bruce Richardson
2018-05-01 13:52   ` Bruce Richardson
2018-05-01 14:11     ` Ananyev, Konstantin
2018-05-01 14:13 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
2018-05-01 14:16   ` Bruce Richardson
2018-05-01 14:37     ` Ferruh Yigit
2018-05-01 15:48       ` Ferruh Yigit [this message]
2018-05-01 17:52   ` Ananyev, Konstantin
2018-05-02  8:24     ` Bruce Richardson
2018-05-02  8:30       ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53ab5a81-b9ac-ea49-733c-20d39398afbd@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=qi.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).