From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58EE842B47; Fri, 19 May 2023 11:01:48 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 47B2D41148; Fri, 19 May 2023 11:01:48 +0200 (CEST) Received: from agw.arknetworks.am (agw.arknetworks.am [79.141.165.80]) by mails.dpdk.org (Postfix) with ESMTP id C92AB40F16; Fri, 19 May 2023 11:01:47 +0200 (CEST) Received: from debian (unknown [78.109.70.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by agw.arknetworks.am (Postfix) with ESMTPSA id 244A6E003C; Fri, 19 May 2023 13:01:47 +0400 (+04) Date: Fri, 19 May 2023 13:01:42 +0400 (+04) From: Ivan Malov To: Ferruh Yigit cc: dev@dpdk.org, Andrew Rybchenko , stable@dpdk.org, Andy Moreton , Denis Pryazhennikov Subject: Re: [PATCH 1/2] common/sfc_efx/base: add API to drop MAE action resource IDs In-Reply-To: <9b77c98f-222f-566e-ec5a-8cf256d98d62@amd.com> Message-ID: <53d49ef-1370-b51d-4b67-3757718cedc6@arknetworks.am> References: <20230424143046.6487-1-ivan.malov@arknetworks.am> <18f3e3aa-1fc1-24a8-50c5-90e45e9cd688@amd.com> <9b77c98f-222f-566e-ec5a-8cf256d98d62@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Ferruh, On Fri, 19 May 2023, Ferruh Yigit wrote: > On 5/18/2023 6:21 PM, Ivan Malov wrote: >> Hi Ferruh, >> >> Thanks for reviewing this. PSB. >> >> On Thu, 18 May 2023, Ferruh Yigit wrote: >> >>> On 4/24/2023 3:30 PM, Ivan Malov wrote: >>>> When the client driver (the DPDK one, for instance) parses user flow >>>> actions, it ends up with an action set specification. Next, in case >>>> there are any FW resource-backed actions, like COUNT or SET_DST_MAC, >>>> the driver allocates these resources and indicates their IDs in the >>>> action set specification. The API used to set these IDs checks that >>>> the current value of the target ID is INVALID, prior to the call. >>>> >>>> The latter check, however, prevents the driver from updating the >>>> IDs on port restart. When the port goes down, the driver frees >>>> the resources. When the port goes up, the driver reallocates >>>> them, tries to set the IDs in the specification and fails. >>>> >>>> In order to address the problem, add an API to drop the >>>> current resource IDs in the actions set specification. >>>> >>>> Fixes: 3907defa5bf0 ("common/sfc_efx/base: support adding encap >>>> action to a set") >>>> Cc: stable@dpdk.org> >>> >>> Hi Ivan, >>> >>> As far as I understand this patch extracts some code into a function, so >>> I expect no functional change in this patch. So not clear what this >>> patch is fixing? >>> >>> And I can see this new API is used in next patch and it fixes an issue. >>> But while backporting this fix to LTS we want both patch to backport >>> because there is a dependency. >>> >>> If there is no functional change in this patch, what about merging these >>> two patches, and explain what is fixed? This also helps backporting. >>> >> >> As far as I know, changes to different trees (common/sfc_efx/base on the >> one hand and drivers/net/sfc on the other) belong in separate patches. >> Please correct me in case I've got that wrong. >> >> Anyway, if it's not that hard to backport the two patches in their >> current state, I vote for keeping them like that. I don't insist. >> > > I think changes are simple and can go into single patch to help > dependency between two. > > Thanks for perseverance. Now you mention it, what prefix in the summary should I use? Just "drivers: "? For the unified patch, that is. Ivan