From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 4FEDC1B010 for ; Mon, 8 Jan 2018 14:23:04 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jan 2018 05:23:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,330,1511856000"; d="scan'208";a="8725475" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48]) ([10.237.220.48]) by orsmga007.jf.intel.com with ESMTP; 08 Jan 2018 05:23:01 -0800 To: Wei Dai , jingjing.wu@intel.com, beilei.xing@intel.com, helin.zhang@intel.com Cc: dev@dpdk.org References: <1514202309-56359-1-git-send-email-wei.dai@intel.com> <1514301894-58374-1-git-send-email-wei.dai@intel.com> From: Ferruh Yigit Message-ID: <53f0e811-d0e1-7b23-1a81-f8d9639c6f09@intel.com> Date: Mon, 8 Jan 2018 13:23:01 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1514301894-58374-1-git-send-email-wei.dai@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v9] net/i40e: determine number of queues per VF during run time X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jan 2018 13:23:04 -0000 On 12/26/2017 3:24 PM, Wei Dai wrote: > Without this patch, the number of queues per i40e VF is defined as 4 > by CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF=4 in config/common_base. > It is fixed value determined in building time and can't be changed > during run time. > With this patch, the number of queues per i40e VF can be determinated > during run time. For example, if the PCI address of an i40e PF is > aaaa:bb.cc, with the EAL parameter -w aaaa:bb.cc,queue-num-per-vf=8 , > the number of queues per VF created from this PF is 8. > If there is no "queue-num-per-vf" setting in EAL parameters, it is 4 > by default as before. And if the value after the "queue-num-per-vf" > is invalid, it is set as 4 forcibly. The valid values include 1, 2, 4, > 8, 16 . > > Signed-off-by: Wei Dai > Acked-by: Konstantin Ananyev > --- > v9: > v9 = v8+v7, is a complete version for maintainer's convenience. > v8: > As v7 patch has been accepted into dpdk-next-net-intel, this patch > is based on v7 patch. > add description in i40e document > fix the last member of valid_keys[] for rte_kvargs_parse( ) > add RTE_PMD_REGISTER_PARAM_STRING for this feature > v7: > use the macro instead of natural number > correct git log message as the EAL parameter is only valid for PF > v6: > fix a small bug when detecting end character of strtoul > v5: > fix git log message and WARNING of coding stype > v4: > use rte_kvargs instead of pervious parsing function; > use malloc/free instead of rte_zmalloc/rte_free. > v3: > fix WARNING of coding style issues from checkpatch@dpdk.org > v2: > fix WARNING of coding style issues from checkpatch@dpdk.org > --- > config/common_base | 1 - > doc/guides/nics/i40e.rst | 12 ++++--- > drivers/net/i40e/i40e_ethdev.c | 75 +++++++++++++++++++++++++++++++++++++++--- > 3 files changed, 78 insertions(+), 10 deletions(-) > > diff --git a/config/common_base b/config/common_base > index e74febe..4e20389 100644 > --- a/config/common_base > +++ b/config/common_base > @@ -208,7 +208,6 @@ CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC=y > CONFIG_RTE_LIBRTE_I40E_INC_VECTOR=y > CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC=n > CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_PF=64 > -CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF=4 > CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_VM=4 > # interval up to 8160 us, aligned to 2 (or default value) > CONFIG_RTE_LIBRTE_I40E_ITR_INTERVAL=-1 > diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst > index cd46874..abb20da 100644 > --- a/doc/guides/nics/i40e.rst > +++ b/doc/guides/nics/i40e.rst > @@ -115,10 +115,6 @@ Please note that enabling debugging options may affect system performance. > > Number of queues reserved for PF. > > -- ``CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF`` (default ``4``) > - > - Number of queues reserved for each SR-IOV VF. > - > - ``CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_VM`` (default ``4``) > Hi Wei, What do you think creating a section for "Runtime config options" in same level for "Config File Options" and explain new "queue-num-per-vf" option there? Thanks, ferruh