From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 4AF9D2C35 for ; Wed, 15 Mar 2017 14:43:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1489585436; x=1521121436; h=subject:to:references:cc:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=XVnBOQtzf+Vqg7OBqtF6it+ULl12Ex9O1SBUGtH9OTw=; b=uzL4F53kvKaiANpDaSkeJX8HltnIAlRjVbm/wa8sdrQOpD1G2EsTIkN5 K+Z3aH3R0PJ71Zoa93xBJZU+ATQ/Lg==; Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Mar 2017 06:43:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,168,1486454400"; d="scan'208";a="1122854502" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by fmsmga001.fm.intel.com with ESMTP; 15 Mar 2017 06:43:53 -0700 To: Pascal Mazon , keith.wiles@intel.com References: <1488904298-31395-1-git-send-email-pascal.mazon@6wind.com> Cc: dev@dpdk.org From: Ferruh Yigit Message-ID: <54080ea9-8257-9e83-78ea-9797d60f8643@intel.com> Date: Wed, 15 Mar 2017 13:43:52 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 0/8] net/tap: add additional management ops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Mar 2017 13:43:56 -0000 On 3/14/2017 8:22 AM, Pascal Mazon wrote: > Add a few eth_dev ops to the tap PMD for completeness. > We want it to behave as much as possible as a standard PMD. > > v2 change: > - use snprintf in tap_mtu set > > v3 change: > - call tap_mac_set() only once in tap_setup_queue() > > v4 changes: > - use new tap_ioctl function for shared behavior between ops > - update supported packet types > - remove IFF_NOARP flag from link status change > - sync desired MTU to both remote and tap netdevices > - remove support for mac_add and mac_remove ops > > Pascal Mazon (8): > net/tap: remove wrong IFF_NOARP flags > net/tap: refactor ioctl calls > net/tap: add MAC address management > net/tap: add MTU management > net/tap: add speed capabilities > net/tap: add multicast addresses management > net/tap: add packet type management > net/tap: add flow control management Except from missing librte_net dependency, patchset looks good to me, Series Reviewed-by: Ferruh Yigit