From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 105AE6886 for ; Mon, 8 Sep 2014 12:12:23 +0200 (CEST) Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214] helo=[192.168.0.10]) by mail.droids-corp.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XQw38-0007gy-Rx; Mon, 08 Sep 2014 12:19:58 +0200 Message-ID: <540D8228.809@6wind.com> Date: Mon, 08 Sep 2014 12:17:12 +0200 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0 MIME-Version: 1.0 To: Bruce Richardson , dev@dpdk.org References: <1409759378-10113-1-git-send-email-bruce.richardson@intel.com> <1409759378-10113-4-git-send-email-bruce.richardson@intel.com> In-Reply-To: <1409759378-10113-4-git-send-email-bruce.richardson@intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 03/13] mbuf: add packet_type field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Sep 2014 10:12:23 -0000 Hi Bruce, On 09/03/2014 05:49 PM, Bruce Richardson wrote: > Replace a reserved slot with the new packet type field used to identify > the type of the packet, i.e. what protocols are used. > > Signed-off-by: Bruce Richardson > --- > lib/librte_mbuf/rte_mbuf.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > index f136d37..8d0c6fb 100644 > --- a/lib/librte_mbuf/rte_mbuf.h > +++ b/lib/librte_mbuf/rte_mbuf.h > @@ -146,7 +146,7 @@ struct rte_mbuf { > uint32_t reserved1; /**< Unused field. Required for padding */ > > /* remaining bytes are set on RX when pulling packet from descriptor */ > - uint16_t reserved2; /**< Unused field. Required for padding */ > + uint16_t packet_type; /**< Type of packet, e.g. protocols used */ > uint16_t data_len; /**< Amount of data in segment buffer. */ > uint32_t pkt_len; /**< Total pkt len: sum of all segments. */ > uint16_t l3_len:9; /**< L3 (IP) Header Length. */ > This patch adds a new fields that nobody uses. So why should we add it ?