From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 9ACA6B399 for ; Mon, 8 Sep 2014 14:05:55 +0200 (CEST) Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214] helo=[192.168.0.10]) by mail.droids-corp.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XQxp2-0007jo-6V; Mon, 08 Sep 2014 14:13:31 +0200 Message-ID: <540D9CC6.7020202@6wind.com> Date: Mon, 08 Sep 2014 14:10:46 +0200 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0 MIME-Version: 1.0 To: Bruce Richardson , dev@dpdk.org References: <1409759378-10113-1-git-send-email-bruce.richardson@intel.com> <1409759378-10113-11-git-send-email-bruce.richardson@intel.com> In-Reply-To: <1409759378-10113-11-git-send-email-bruce.richardson@intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 10/13] mbuf: split mbuf across two cache lines. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Sep 2014 12:05:55 -0000 Hi Bruce, On 09/03/2014 05:49 PM, Bruce Richardson wrote: > This change splits the mbuf in two to move the pool and next pointers to > the second cache line. This frees up 16 bytes in first cache line. > > Signed-off-by: Bruce Richardson I think you should provide more explanation in the commit log about why this change is needed. I remeber you already provided the arguments on the mailing list, but it could be interesting to have them in the log. Regards, Olivier