From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B8D97A04B5; Mon, 16 Nov 2020 15:44:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 95FC3C8B0; Mon, 16 Nov 2020 15:44:39 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id A9FB4323E for ; Mon, 16 Nov 2020 15:44:37 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 008C65C011D; Mon, 16 Nov 2020 09:44:36 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 16 Nov 2020 09:44:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= iKFlJGR0ZGXicT9VfYqZ/h3L3s5cQ6J4sNV/BU5HYPw=; b=bfhqOFK/lXEgLAT2 aH+8eJ1tdXU39z2xcsj0/6eMgpUHB7Xpit3p4IzcmlueU+TXcj/i+NrWy6OrZ3eK wjBMznheAvIngq48biFboBv4n/nFIFrAOv0U/aM+0sdwC6850vilBEFycZhUTb5V /tJx3xvT0sAteiLGJuk3kb5Zi0N42aqy/P4Xoma5iUTihZqI7eZABuuRTrWlf5wR a0Cgk7v+Aal99ic8DKcjzYRES6Kxkb5Pt7Quxh1USicf6/d16VK8k+fIHrinwKWj 7AMugdcdfSz+i0Gyym5HFs77cEFBysQvcqFnE2RSoAFSQl9dgnDe/YR0alNaaJVM Pklidg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=iKFlJGR0ZGXicT9VfYqZ/h3L3s5cQ6J4sNV/BU5HY Pw=; b=WqULYa2RbpeijfMt0I+M2Fn7qAtDhu3fRdLINSqW93Z9lOBEI/JhhwvB8 0/Kl6oCreX4KAjot+G+7aiMDeUOn8KqObUGFLQ31uRATDafu+/fquKE95ZCxMyg4 quPp2V5CHyQzU7bvv7JiICMuzPf8h53uIfDjCIgrIy98nGZVInEnsUejzkUzn6td vXkM3XaRZQIUkvWViflZStXcztuw/yPocf08EXpyDgfIf0TneUgUre1kHKCDyorb rBF9diUPhpxAzQPsuK0znDSEDAk77sMl7CvzlSBoZkNGjW1P/PGJ4HH8x1vBw9cR aMDSb4+etPqXdBitn2S2EE5WryqlA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudefuddgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1BCB83280059; Mon, 16 Nov 2020 09:44:35 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson , David Marchand Cc: dev Date: Mon, 16 Nov 2020 15:44:33 +0100 Message-ID: <5412819.EXT4iZhqdP@thomas> In-Reply-To: References: <20201112163901.1728959-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/1] devtools: rename build test verbosity variables X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/11/2020 15:27, David Marchand: > On Thu, Nov 12, 2020 at 5:39 PM Thomas Monjalon wrote: > > > > For consistency with other variables which can be set from the env, > > TEST_MESON_BUILD_VERBOSE and TEST_MESON_BUILD_VERY_VERBOSE > > are renamed > > DPDK_BUILD_TEST_VERBOSE and DPDK_BUILD_TEST_VERY_VERBOSE. > > It seems a bit odd to take inputs from both the script parameters and > the env to control something. > Those TEST_MESON_BUILD* vars seem internal stuff that should not be exposed. I have the same opinion. I cannot find a good reason for controlling verbosity with environment variables instead of parameters. Bruce is there a reason we are missing? See the commit 4bcb9b7686043f: " When running ninja, the commands are, by default, always printed on top of each other. For those who want more detail in the output, two levels of verbose output has been added to the test-meson-builds script. When "-v" is passed, or the "TEST_MESON_BUILD_VERBOSE" flag is set in the environment, then the output of ninja is passed through "cat" to prevent each line overwriting the next. If "-vv" is passed, or "TEST_MESON_BUILD_VERY_VERBOSE" is set in the environment, then ninja is called with the "-v" flag to print out each command in full as it is executing. "