From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17F89A04B9; Mon, 7 Sep 2020 11:44:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8D4771C0BE; Mon, 7 Sep 2020 11:44:05 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 6559C1BEE1 for ; Mon, 7 Sep 2020 11:44:03 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id E5B555C0115; Mon, 7 Sep 2020 05:44:01 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 07 Sep 2020 05:44:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= He5lLGap+Dx4AgHPaAonOAa/g5iAA7y2KqmK2oxJz/k=; b=KBQ2POHCpFLR2771 pgdJXLZJQyXTJfCVpmAeVTXxVGckxnEZdxRtdltsFWsJnG8jyf0B8+4MJcRTh/GF WsnQtlWEECkACuDXKljqhOLAdnBKI/wflHbNxpvqHcoGgKIHc/tK6GcgNANHe4gz tYEt2Qf5E+jtGw1Y7LG4vpmLNDWLojI77yzjA0sa3/J6UujRV12fNsFLcwEXDqOu ESRXUg1S5lQktmHoH9z9JkqUzfuZ11W6ITcfI6kAjXnmqa1lJkmVaje6aJcRFnzQ HSlhC6p3oA4AfXh5r7H/JcjArcoXTxjtedN/0dT9BV1nDdREbSFBcf8+fzAbvEkP dfeoVg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=He5lLGap+Dx4AgHPaAonOAa/g5iAA7y2KqmK2oxJz /k=; b=TMYVAI6/AV3xdnylRL2SaXNjnOK0EFUZn44CymW6D4bCLCKzJLcxF+blt 5a5IDVl3kqP19Gog4wwCwCzrKTcKtmCOBHtuX1wxpJ9YDohKCPUWOWxQ3VnGBpDW YOlnv2gSQUsyki8zCRwz5Mpdj6CyP18DZAeJsGwLldSoA72sJE7zQ740ZZJSHjU0 WKuE5m+kmOoXhu5k5+OjII8qOl1RlFxXzG/zETKnhVjaQAWQ56xrLRKNX/3SDBDJ JtPnMXimk6qVuCvSNLGcaPOFLTyinnu28gLHM34YwXxKqhpHdUnKMapxuD1Jzftf CAUZ4IkUyy8ouyVA//QmqFwV9drvA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudehtddgudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B07FE3064674; Mon, 7 Sep 2020 05:44:00 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: Ciara Power , dev@dpdk.org, Anatoly Burakov , Beilei Xing , Jeff Guo Date: Mon, 07 Sep 2020 11:43:58 +0200 Message-ID: <5423098.A2vqu1mSju@thomas> In-Reply-To: <20200907081828.GA312@bricha3-MOBL.ger.corp.intel.com> References: <20200903152717.42095-17-ciara.power@intel.com> <20200907081828.GA312@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 16/37] drivers: remove references to make config options X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 07/09/2020 10:18, Bruce Richardson: > On Sun, Sep 06, 2020 at 12:24:49PM +0200, Thomas Monjalon wrote: > > On Thu Sep 3, 2020 at 6:26 PM CEST, Ciara Power wrote: > > > Make is no longer supported for compiling DPDK, references are now > > > removed in code comments. > > > > It should be squashed with the patch removing the config options. > > > > In general, I feel this patchset would benefit a bit more squashing. > > Yes, but that makes it harder to review and work with. For example, for > removing the config options each document needs to be modified to remove > references to those, and once make itself is removed again all docs need to > be modified. To review properly, the doc needs to be scanned to check no > references, especially indirect references, are missed. Given that e.g. the > NIC guide doc is 55 chapters, that's a whole lot of reviewing you want to > minimize, so having all changes to that one doc in one patch is much more > feasible. > > Really, removing the whole build system could all be done in one patch, as > removing parts a bit at a time doesn't really make sense as it's all broken > once one part is gone. However, the resulting patch would be enormous, so I > suggest keeping the parts separate for review and then squash on merge if > so desired. I will keep doc patches separate because it's too big and requires more reviews. The separation between makefiles and configs is also fine.