From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45])
 by dpdk.org (Postfix) with ESMTP id CF9E3C44A
 for <dev@dpdk.org>; Wed, 15 Jun 2016 11:27:09 +0200 (CEST)
Received: by mail-wm0-f45.google.com with SMTP id a66so14983842wme.0
 for <dev@dpdk.org>; Wed, 15 Jun 2016 02:27:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=QYjKO5qygzR0sVu2rqyWOFB57/DBuiax7kE54rCkbsA=;
 b=qCO4dhtdOe18DchBrazu0ehnIOSAP+1DKAsvMPByNe5b4y/CeawhNcRZ9QTv+6zUJV
 a1Varzw8QE8tclqEOhEyR4UnH75eWz1FLq82xV8DewlZwplkRa28LoW9htvnkGZ25pWB
 oRwYl+egIfOmyLtiuUI8IW1l142dHnFBhfgLUAteu5Jb6+XGU0qU7UeQwTIpqbLES6rE
 SvX0Ftx8mb7o7Y8BMfztcEthHVwJGHu9uD8F4GqaW0ItHeu8FlyzYk32kyAp/LMzp8Nw
 xrpDwTdVMUqwiw+m2/P/V0TmW4bvmpk3j3xz9aU/WEk2KkWJnYiEY9tnh2p7+cvec7MT
 KP/w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=QYjKO5qygzR0sVu2rqyWOFB57/DBuiax7kE54rCkbsA=;
 b=RzPPbMY2CXHIEko97Q2NOEbMDFx3wuc1NPtkX167IRe1d2LV+HU4TfRzwQwkfA3UFd
 zebR2iqj/n8lAHnJxqE0d6atoJ9ukOtca+MUCdCimkieO73y6SWmSN9+ZSjmwTFs08CU
 qw7vkWO+xPD3XNxpVg5HrNaiWOTsVkqG4nUrj6nDWGZgMhzm39Xd/33JtSTIjuILjVFN
 0fmcZMZa+65V9NxctI6KZOOqcTE1Xj6EzVhdxkOQ8oQhLpWxN1XOse3RAJUkuJX94ySQ
 UYGPK6scKi88h/G8/h2/RCpeuvNZyP3hC3CuEzZzrBudFkW7goEAWFaqLptzHyrlTpwb
 FqPQ==
X-Gm-Message-State: ALyK8tI75O2hxIw6kjtTayMRa2RJIGyQhuaQKmyDBSwdvyCMoavF9aQ+StWYlAlwVIT7Kav8
X-Received: by 10.194.177.201 with SMTP id cs9mr10309499wjc.139.1465982829446; 
 Wed, 15 Jun 2016 02:27:09 -0700 (PDT)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id w188sm3104792wmw.11.2016.06.15.02.27.08
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 15 Jun 2016 02:27:08 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Remy Horton <remy.horton@intel.com>
Cc: dev@dpdk.org
Date: Wed, 15 Jun 2016 11:27:07 +0200
Message-ID: <54322711.BUndy8Ap0U@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1465982245-1162-2-git-send-email-remy.horton@intel.com>
References: <1465982245-1162-1-git-send-email-remy.horton@intel.com>
 <1465982245-1162-2-git-send-email-remy.horton@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v3 1/3] eal: export keepalive state
	enumerations
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Jun 2016 09:27:10 -0000

2016-06-15 10:17, Remy Horton:
> +enum rte_keepalive_state {
> +	RTE_UNUSED = 0,
> +	RTE_ALIVE = 1,
> +	RTE_MISSING = 4,
> +	RTE_DEAD = 2,
> +	RTE_GONE = 3,
> +	RTE_DOZING = 5,
> +	RTE_SLEEP = 6
> +};

I'm concerned about the namespace here.
RTE_UNUSED and others have a chance to not be unique enough.
Is it possible to have a longer prefix like RTE_KA_ or RTE_STATE_
or RTE_KA_STATE_?