From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6200542A5E; Thu, 4 May 2023 17:29:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 072BF41144; Thu, 4 May 2023 17:29:02 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2077.outbound.protection.outlook.com [40.107.237.77]) by mails.dpdk.org (Postfix) with ESMTP id 7829F410DC for ; Thu, 4 May 2023 17:29:00 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PRyvWhIbvHgk2/I6xzJh8ok84Oy1enp9XSdD7nxoTKjyVDuf9LZW33NYNE1IVaW2Yv/nb8Bhk8IFeeLCab6qnwAbk9ym+A+/AzEoBq1yQk5gpYLui+56ZP6fh+kyJjti/kML/AERhcJDsNLFwiGF0ZaWaPsyfM35UCeboQ51C6pYnbRSfNWIxwXn/RtrAgDED5mNXxGz1QLYkK/V407/VZBvgqE0uwzy2oDCt+TbJ+s8LgGu12fhQriUfE5/bogEmX6ciTQEEwuvkHxGa5uFsXkPmKX5GqrUiiLWpZeIutZaaQed9tF9LOvpuRtO5qEVegLOU2kuTC8Au4QYylMKIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T69JTY2NdM+UFuApWNpK/sfm6C332kodzJhV5hxWAoU=; b=B3JqavTRQ4c8UBfptfRbMVKym4T06BtyHi4p7QJseol0bGVXv3jBlTYe4tlnipTNQPHCSwbbR8YhkY1DJ4s+HKuC0rS1rTdRdRVramuRM4dF1A5jeQ7quhUJ5qFHgG4HyPrqzwtxnFZOhVdYsuGL9vtUt9Er4n/B6Gt29AW+UrSQmQ2AkY3AaVc+UiH6bu0MA323pZZ8NleMK5n5tjj1bFBa7iyKX2sXuO1sT4kWZpil7lXAbFyRBIQdSAfWD3Z+lOlSDbuKPfcdTclSxCKwSaB7IcfcTfBn9tTmwuEgFVisl5mGWowSRqZWOrzKVjRncTlW13JPmNgD0NTtGuTguA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T69JTY2NdM+UFuApWNpK/sfm6C332kodzJhV5hxWAoU=; b=EKRPsmOjLEibOyvQVjhM8mzHFsTrHWmAMbQwL27T5dIGxUy8aIk+yg6W7Z/yduDT+AGlu4QYGZ/u2HSIr81ULAzRU3x93BiEfRsBv/5/2lFaDuyZr06jfTxDBunpRg27N8YI/BBNyM8Ld3B2uwiMTwdn72AYoNhD/d4+DUS+lv8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA0PR12MB4510.namprd12.prod.outlook.com (2603:10b6:806:94::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Thu, 4 May 2023 15:28:58 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::e818:77ea:75b5:f8cc]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::e818:77ea:75b5:f8cc%5]) with mapi id 15.20.6363.022; Thu, 4 May 2023 15:28:58 +0000 Message-ID: <54328b0c-584e-dc58-2559-9d30e089a66a@amd.com> Date: Thu, 4 May 2023 16:28:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3 5/5] config/arm: add AMD CDX Content-Language: en-US To: Nipun Gupta , dev@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com Cc: harpreet.anand@amd.com, nikhil.agarwal@amd.com References: <20230124140746.594066-1-nipun.gupta@amd.com> <20230421145406.12831-1-nipun.gupta@amd.com> <20230421145406.12831-6-nipun.gupta@amd.com> From: Ferruh Yigit In-Reply-To: <20230421145406.12831-6-nipun.gupta@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0625.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:294::23) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA0PR12MB4510:EE_ X-MS-Office365-Filtering-Correlation-Id: 203c7587-67e6-4922-760a-08db4cb44785 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3XnnEJ3pEtUiALzaVyzKzyp/wtSyVhxcdZyD8NDdWKwFJVM5nrRUC+5NOyOIB+K9TwsNcf4GtyVrXT6TcljWFp5UxKTNDuzCrLD8T0sdUvNa9H+/KhWxiVazUao/Nmxk8fhrtN1e+1oMGVofhhCB8UoFN8H3G1zV4a9YEehhNK39QPO2T3XDP2avG9Iaw6bPzLKq8/6DcLaTDp9uXrxyBgh+gNOmmsMqWcur91T+NYcx9f59hTN0c7C6jBeZV4XZ4/FjmtBc25RjnkBOaXYDoAlxUvJaNqzBOZGMTF91OrASrPvecPyxuP/7DSQgJnSTe20BQbD+GB9Y00dhUlQ0z3dZKDCrWdaJd2iSOdRsp04IJ61Cc7DVG4LiEBLt0Yw6sJ1UQzzWJrsxweVqja3cmzcGx95Xv+5VdyKXU9On5nbJEcJ+/GiDvugMH7SuaQzaGpB1iQxVsm/5iVzw9ULP+KR6I0Bl/YrWGByXJ0UIntnm497X9HP6gwIP1uBiD8ejWuoJHHEzOZAqZRA9u4H3HeQvwwgwqOE6Bv17SVRG+QmhDKFD7JJ6GV1pWqO1NGDs1NW4Cyum4ZCm9K2aE5Mnbxa/Y0deWngqCMpE684cSIpgLiKW26OvQ/8K1hmSicqAsuRYomJktsebJtksBhZ6Xw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(366004)(396003)(136003)(376002)(346002)(451199021)(36756003)(478600001)(44832011)(5660300002)(8676002)(8936002)(38100700002)(2616005)(86362001)(6666004)(6506007)(31696002)(6512007)(66946007)(66556008)(66476007)(6486002)(4326008)(316002)(186003)(53546011)(41300700001)(31686004)(2906002)(26005)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QkpScWpaaGw4dFNJVjRmMnRVQXRVUU01U3R0a3gyRkpDcWpsZnVWQWJmbVNW?= =?utf-8?B?WXkzTVVaTjIway9TZy9JdFdvTkN1VjNQdStQckFMQ21zYVFZTi9kUHR2KzJX?= =?utf-8?B?V29yS3M1TUJjY2RJbVE0dkF4YUtKSDN1b29PdHpPNFVYdURUK2NRZkpxZS9q?= =?utf-8?B?SldDMGE1R20yZHQwYkhsclZLMUhPd2VZQndISTRNL1lnY041MUZkZGlBV0lW?= =?utf-8?B?TVVmc25UbHdCZFF2V2JhK3NwdEtVcFNRM2xvNnlSZTNuc3lmTWxZUVdtTjM4?= =?utf-8?B?c3pWRTRZSGlXZ1hEazVuQzBtNE9UbHlQVlJ2TG02cENFdzhJb01WQ3F4Rnha?= =?utf-8?B?eTBPdjRzVGNaNjIwNGF6aDd3UHpWTUM4NUZDMWxiU25ISzdPcDQ2bkRIa2hq?= =?utf-8?B?RUF1a2Z4QU54cHp4bjhzM1RDNEQyY1U1ZjIyeDFuRVFzZDRaVXdFZkR4blo1?= =?utf-8?B?NWhBYjlrbndPNjlNZ2FlRVFCRno4ekd1RW5SVjhuSFNBL2RidHNOYUtaalJD?= =?utf-8?B?eUY3K3Z3eFBFMTRTY3UrOEZJMm1lK1ZNRTVTSWF4dDFlVDBXZ3lQWjlzYlQ0?= =?utf-8?B?aVUzVXloYmV1aENJS0ZNaWNJSDJEckdwQzBuVzE2MWU0UWZDWGlxZDNVZ2lP?= =?utf-8?B?MDd5U0xvbEhSWkU5a1VNMFpESG5zWUYySTVpWG9jQ3FUa3Bza2piWmpRSzMz?= =?utf-8?B?Z0t6bFB6VFVRUlVzbFU5VmJEdFZCZTJ0NXNiZjVKVE83NlNNMWZWOTluOFo3?= =?utf-8?B?WjRzV1NvRzAyVnlyRnRhMGZTMUJCWGNPRjkvUElvTXdWbDBmS3A2OUhsL3ky?= =?utf-8?B?RUd1b1ovR01RdWQ4eGs0UTM1bmF6TkU3QnBuV2pCWm5ncldSSG81RTViOXZE?= =?utf-8?B?UmoxZE1VQVpCZVdaV1ZoZ29CSFd5WDg5dXhrN3dERjZvMkFJVkhyemhKejU5?= =?utf-8?B?cDJSZ0dxdmFuNVk1aHdoZDY1N05JVDhtL0V2ZmNrdUpxYXg2R1FKL1phM29x?= =?utf-8?B?dWNOZVplbmtNaUNFcWJrNWwvck5hN21PcUtBamR1dENkT2E3UmpaenZFTmkx?= =?utf-8?B?alJKclNOS1lxTWtpdXFSRzJZZk16QTd3VlJjczVONWxDN2h2YkRzVDlFNjU1?= =?utf-8?B?QlkyZ3hlaXdKbHZ4eDhINnZmRE9pd3NzM3d3TjF6MkZFUHpUakQzT0NmZFRN?= =?utf-8?B?UU56MVlCbmo5MnU2N1FEcVFpOFVxankyVDBFQXRpWGFNUnpsL0JtR0NwRGkv?= =?utf-8?B?blFFLzVLQkliQzdjQzhZaWxpelB6NmJIYWM0d2JqdW5COG5qSFk1aVlLZ0Ew?= =?utf-8?B?SW1qbnRxS3RYZ25kS0VtU2dJQkdLcEU5cFhlQWhWcSt3U2phTW9aQUFRWlVD?= =?utf-8?B?c01vY3dGWlRUWDFTdGpkcFRrWWlXdGlLU1U2MzdhckVBbkJybnEvT3VGMVRY?= =?utf-8?B?OWh0dVJwTVdWeGFEL1dyUUN1T2ljRnpmSFBZcUdOUU1RekVwK0lMc0xvNDRL?= =?utf-8?B?d2pmSC9mencvckNxeVVrVUl2emFaa01XckZtak9WKzlHY3V0K0FVMHp0UGhN?= =?utf-8?B?Mkx6cFc0Nm15ekJFN1l1M2dFdloyT1VsV0xtTkxjRGlkZWZZeXNPeVYxMUY2?= =?utf-8?B?NGJ1SitmVkRwTmlGWXZsMEtZMmFwaWJ6MW8vcjNIRVh3RVd0SEx6RkhZTk9t?= =?utf-8?B?c0FEdjZIU1lUNnRUeVNVa1pKK2V0aGZrNEI1a3hUYzRtVGUzU1ptT1h5cGdE?= =?utf-8?B?aTNtdUNqM2tYSnBPMndiVzJpSVlueENJRWxGR0JQZldRMndOOTVkbDlLL281?= =?utf-8?B?NWdJcVRkQ1M4NFR4aVFrdkxJRkJXelRUMXpVWkYwOWUvUmo4S1dJVHNTaUVh?= =?utf-8?B?d1phZjNaczVNRk93b0ZyY0I4TGVFMXZxQWNHMm80SGxRVHB1dHlYZGE0cysy?= =?utf-8?B?dTArMlRnTisxZ1BzTUhGN1daSWVWdkdjMWx4YlljOUw3MlRxTUptbWd2My90?= =?utf-8?B?SVF4VXBPYlRMV2xBSjl0MUxKM2RIcXptOU15ZzVBTTNod0hhdVlzaE4zbG41?= =?utf-8?B?bUo5TE4rOHBVdlpNY1hmamtNelVMTVpNNW1BRUdOUjJ6anJLYjFDeWVySHBy?= =?utf-8?Q?m/ojKJjJhcb7w6rIPQsdjVi9D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 203c7587-67e6-4922-760a-08db4cb44785 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 15:28:58.3389 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MA76k00ZKiIdx34u7PxpNERjdZLozeMpYhDXAVPz9EXEhZts0LACpP/f4uEz7hw3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4510 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/21/2023 3:54 PM, Nipun Gupta wrote: > Adding support for AMD CDX devices > > Signed-off-by: Nipun Gupta > --- > config/arm/arm64_cdx_linux_gcc | 17 +++++++++++++++++ > config/arm/meson.build | 14 ++++++++++++++ > 2 files changed, 31 insertions(+) > create mode 100644 config/arm/arm64_cdx_linux_gcc > > diff --git a/config/arm/arm64_cdx_linux_gcc b/config/arm/arm64_cdx_linux_gcc > new file mode 100644 > index 0000000000..8e6d619dae > --- /dev/null > +++ b/config/arm/arm64_cdx_linux_gcc > @@ -0,0 +1,17 @@ > +[binaries] > +c = ['ccache', 'aarch64-linux-gnu-gcc'] > +cpp = ['ccache', 'aarch64-linux-gnu-g++'] > +ar = 'aarch64-linux-gnu-ar' > +as = 'aarch64-linux-gnu-as' > +strip = 'aarch64-linux-gnu-strip' > +pkgconfig = 'aarch64-linux-gnu-pkg-config' > +pcap-config = '' > + > +[host_machine] > +system = 'linux' > +cpu_family = 'aarch64' > +cpu = 'armv8-a' > +endian = 'little' > + > +[properties] > +platform = 'cdx' > diff --git a/config/arm/meson.build b/config/arm/meson.build > index 5213434ca4..39b8929534 100644 > --- a/config/arm/meson.build > +++ b/config/arm/meson.build > @@ -305,6 +305,18 @@ soc_bluefield = { > 'numa': false > } > > +soc_cdx = { > + 'description': 'AMD CDX', > + 'implementer': '0x41', > + 'part_number': '0xd42', > + 'flags': [ > + ['RTE_MACHINE', '"cdx"'], > + ['RTE_MAX_LCORE', 16], > + ['RTE_MAX_NUMA_NODES', 1] > + ], > + 'numa': false > +} Hi Nipun, Why we need a new arm platform/config? Is it because of above flags? If it can work with default values, I think we can drop this patch.