From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0059.outbound.protection.outlook.com [104.47.32.59]) by dpdk.org (Postfix) with ESMTP id AF8DADE0 for ; Mon, 3 Apr 2017 11:27:46 +0200 (CEST) Received: from BN3PR0301CA0042.namprd03.prod.outlook.com (10.160.180.180) by BY2PR03MB394.namprd03.prod.outlook.com (10.141.141.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1005.10; Mon, 3 Apr 2017 09:27:45 +0000 Received: from BN1AFFO11FD025.protection.gbl (2a01:111:f400:7c10::144) by BN3PR0301CA0042.outlook.office365.com (2a01:111:e400:4000::52) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1005.10 via Frontend Transport; Mon, 3 Apr 2017 09:27:45 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; caviumnetworks.com; dkim=none (message not signed) header.d=none; caviumnetworks.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11FD025.mail.protection.outlook.com (10.58.52.85) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1005.5 via Frontend Transport; Mon, 3 Apr 2017 09:27:44 +0000 Received: from [127.0.0.1] ([10.232.133.65]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v339Rco6010987; Mon, 3 Apr 2017 02:27:42 -0700 To: Santosh Shukla , Shreyansh Jain References: <1490955469-16216-1-git-send-email-shreyansh.jain@nxp.com> <20170331151100.GA11069@santosh-Latitude-E5530-non-vPro> CC: , From: Hemant Agrawal Message-ID: <543931bb-20b7-1257-4257-8e3116e2a8d6@nxp.com> Date: Mon, 3 Apr 2017 14:57:38 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170331151100.GA11069@santosh-Latitude-E5530-non-vPro> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131356852649049956; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39400400002)(39860400002)(39380400002)(39410400002)(39840400002)(39450400003)(39850400002)(2980300002)(1109001)(1110001)(339900001)(199003)(189002)(24454002)(377454003)(9170700003)(230700001)(7246003)(86362001)(7126002)(50466002)(8656002)(31696002)(53936002)(54906002)(64126003)(5660300001)(65826007)(23746002)(36756003)(38730400002)(2950100002)(8676002)(81166006)(6246003)(6666003)(106466001)(104016004)(31686004)(53546009)(8936002)(4326008)(105606002)(6636002)(33646002)(229853002)(120886001)(65956001)(65806001)(2906002)(47776003)(77096006)(305945005)(85426001)(4001350100001)(189998001)(356003)(50986999)(54356999)(83506001)(76176999); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR03MB394; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; MLV:ovrnspm; A:1; MX:1; PTR:InfoDomainNonexistent; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD025; 1:KUxjex0A3k0amNcR9diJnyMepLP/Qzz9hgRRHwubkvKI8yJ/o0oU+1i8oHaa4fVmyVlpj5jX1RBUTnq4dfMJnYmRdBGOaNgYJtmlejKeBQndok6YINBwhfeRGRQrC7NCjrXE04JT8OxumDtgd+Wy/1Jz0E0vRNRtaPl90tKR5OMcrK7aMAk6cfxtjPgunORPPPuTxlVerbZMiJFv2zdSo9fRR9TOet98emQFRG3/54uWkCmVHSCTGRC1R2+zBGiPM9qNSCOxxCyc8jQy3sZbux2+Z7j/XOF9GI16P26NMkA93Y89WSVv/ggJuIxkORhzcmgslrzmPJlW0SPaX3L6Pu5ID2uQmFU8vHLZF5QI/1BZ8GV7hJISY8hLPQ1eAvgthPfhlWRgld5nZEWtdi/sTNjNtzjjB/qPbDRUtvIbfcMh8q9jiA9cT+L/bNQmnxTJXclmF15932AdF//n2ky6WojAiHi/oqmQXpGdWFutTF/mkeY336jtB+kXgXCVziFjOF9mOT7bloiZYpIgAEVZ7PjPN8Pjog/ccf+QNrPqQ8h5xB4oTp86vOHzSGQE4S/1VCS8nLEBpN67xwEWUX0Xyne+dAZMPxOYWrZE1TRBU88= X-MS-Office365-Filtering-Correlation-Id: ca938177-3123-4c5b-b45c-08d47a73af59 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030255075)(201703131430075)(201703131517081); SRVR:BY2PR03MB394; X-Microsoft-Exchange-Diagnostics: 1; BY2PR03MB394; 3:QktjvQgcbzCTEuQeRO+3ZpAtw2R1x7qDDU/4A9N59j9l1SgPGevwukTzSTpWeDnENkkyBzb4YT5DT1B+ZpMMx6caaG3ggfPPcBW+e5s68Vv0HxCUOIka57u6jJf90PB/06v2Lfy/S0D86+uBfP2C2S8bvfsMXsHxR28KGajKLdE+1lBz9lR6+n5HXii63SPD1+NmjXTQsZhgRcBVnCBGVJE/551bSfcIPI6ZR70SlGXMGmCLElU+5kv6b4MjOn4lL5c4qmDdBJ7u1YSmcjZf6sD5ZC3mgJjOa7NSq8HB7r1YmUiOeN+5nVkJmZsrCkGVr1jjpwBjKGhqno85LQa0iTWP6p0Ltyz1bbsg2AXJ7NJuR85bB1yLfxmdMg2uQcFcNdaq9JRSC1edYIH/MdN2GGTxNEUyPu1HYy7Uw/iAT2C3ZCuuxYBAMi+aS4nSjb/6faSOjBpxMxBT1LZ1rTmQdA==; 25:+9Bi6IlHrDQomwlbuuzhaKSTDdFCvHVBYgjJbC8ImHywfsFVcGQaw/bT80zfvw7X3oJti3dIDp7bQccjl5GY6+Ngyd8t3c1KYYln9MAItotMCFIxdxyHACUoZnt0xYqQIPb0nNnLeGhFrgBp6qCkuBikzQC6w5sH9bLXnHtQGbL/sGDCeFFT5OZj4kpAVyNj+IeMoJMGTkAv5fhMIonCtGeIkRpQCLVICCG+QNRDpD8hBCAWz+AQnLPOm9j3kuFQATtv/5OQJBcGbBrB8kxQDWc/5xFA72yKeX5MucbNJRYfDb7u426VeskBTKAO9M4VJjRzjdj/DYj9hq0/Xp4xRHgql32UTYv+e8WXLPhO+/SIO6BUPjKbCPalBqH/nDFFqbVyvmCnc2Kz2W73WT/eJhAgDu0Nfg+3bVUbDmit4QFnHCNGaCvuo+L18yPJd8A90hsokxeJaWeqfc2Ids4j9g== X-Microsoft-Exchange-Diagnostics: 1; BY2PR03MB394; 31:DfHS6JXGwKmEnva3GAjRMyecMOHcmcbmpIAdhkLsmPCrcykBp3abirCOoNSUrwsX/eSPoPY+WlvW5v84BzMc+KgKxnibi9MRYYYzkix42zrDvWcG4tRuzPAI6BC9A3uKFSHczHICrnQGYbkVkoEEjGbMqxWcPSZ9Ikamb6MoZhziy3WVI+d47mX8kEOcBW9gkoDyRFlS8mSLt2awnE6qLB9wxyGcXj5b8nYQJ5CPrHY2b9IIqJ7VLK8Xti/dWkmXruGYO40qboYyAyGQM1Yb6w== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(278428928389397)(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(601004)(2401047)(8121501046)(5005006)(13017025)(13015025)(13018025)(13024025)(13023025)(93006095)(93001095)(10201501046)(3002001)(6055026)(6096035)(20161123563025)(20161123556025)(201703131430075)(201703131448075)(201703131433075)(201703161259075)(20161123561025)(20161123565025); SRVR:BY2PR03MB394; BCL:0; PCL:0; RULEID:(400006); SRVR:BY2PR03MB394; X-Microsoft-Exchange-Diagnostics: 1; BY2PR03MB394; 4:cMekQwWSsxdd01kQAmSOQn+9IF12mIxvDNxed+wv7/r8ZkK4OvHalR7bQ5aNA5Coh4nSIBGPdg5GBPMKK41yo89TwtZOYNsZxolTpDErEb5zuYjZrtBjxuScETmsfJ1IQ8Zx8ur7zlZF5aCbViIjdRrl3kQnwT3tajNzD1kbfTgAoYhW3l64KT3mAvVp+WO3MmMy9/Z8G//U+QCMxAffoa/N5kSrGvPAxX84eEZktq+uNRdzkU9jiPP8nPeyx75LLQb+x1HXtRavOHpggzGYX0XsoYEU07dBQbftcGQc5e3vp89YxEIsAbyvsGrjKLtfTIddBaJCpY9Nbr23lD0txwSLPKSvhCqFflvVHjR2DIZD87kQpZKj7EUJ+dg4ou8F6eInsN+YG+WLLlViyx/IvPYjSKrW/LKpNbR5jqlvi8fjIXf0HBpRsUwC9s/zuKwceXI6vTWbo/yVzXnXuyU9HFeKBppQcfj/GZDO1DDTeN56zGmuYqYenfAnXsBLxDhDcEEQrMhW6cqTe6l0TZcUJ+bzSzGLEi0bF2X/TSVWjksHdINB38bwfKS9i/gGFmf52Qm79nByyOEw7+0AzjfDf/6RVpDX4ZF+EKXW36jTZPoRhKPGim7C8Y09N6EMKJE69dS0EOtghuWEzNI03Df4FEIIgjNVvKx7GL96KULDYt5zB/JZo1CVzysuDZQpr1qH9f0598qfwKqqkCVP0cmGtnhUkvmxQKFjmumFafmc1kyp/jIGwI0VrIJHnXvZQdAyC2mU7QLgWhfwAsKMODFF3f3pu7ILPi0og/uzpflCHq8HXTIMsPb86gvIpIk+2r65RQPi2y2xA+yQMbS7FiWXfakG5laK84tDEcWWP/gUp3xl2nXpx7/JP9C9MKRR7NfJfZyKcPCvib2nouQrrhI/4EbtGV5NuNSf+B+o63pSShA= X-Forefront-PRVS: 0266491E90 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BY2PR03MB394; 23:z/lOAmO8P2cqbcj4tcO1U8sia5ehUdRJGCa8oA?= =?Windows-1252?Q?qB9PyL4AuA+AQh+z401kmT8zpm64vtnevlaRFkgonxmFM2AGtmx6bBgp?= =?Windows-1252?Q?zfKNzxIjGHaPR6BowUOoa21cEIcJmlFp2FsqqS3D6/GxGTyQ+Tm7ULvN?= =?Windows-1252?Q?E9uDtAiXpNIqpCVbPG0Li5C1dgix7Odpldsq9DNndwwXb696JmutA156?= =?Windows-1252?Q?LTap3kHufv6+4VdNWTh8btIb29WIS7y2L6ggTjgYbxLcKceeQQ7IAaJm?= =?Windows-1252?Q?3T5Nwwleza8dfPxkUOJQXTa4K+ZsTDm7H0wVTWe9CtC0F2i8YAQMtIt8?= =?Windows-1252?Q?z9lNBqIc9rvYdcIPNiAtjsgA/AnbPmscApwIxr17Yxm4xcPoWTlDZ3Qx?= =?Windows-1252?Q?xrGNGFTE8JJIbE78n/v72rSWb0F9HTqCY4cdZbkW5NZmzHHhlx/1DLXu?= =?Windows-1252?Q?PRq0PdIu/cdEt+rpdnbqWaNc2kLcZbPVRdV3y899xiaFfJvUFAWsfM6a?= =?Windows-1252?Q?s6djrTDm+hTINLyMzwJ6S4xxcotzoHpRsp/HUrE2h+9CbWBb2nIntp+d?= =?Windows-1252?Q?Ck69+Z99A9G643DQrHFuLrSppWdvf+o7xESZVaYwjAkIAKswinFB96NL?= =?Windows-1252?Q?fPo1EL7UEIYIi+000OyoejSG0JFUr6JzUh5KieMN7D+Tzb0TqEwFIzs/?= =?Windows-1252?Q?ON5KMpyQGdIwVdTcMf7abxUFup5Maq+ADW/O2vpBokz5jJjuPG7jQR3P?= =?Windows-1252?Q?JL1LryjZFG/CUayGvW3jqAeBAmU0GyK8kJzLpq2om+g6chSsJJY8Qt1V?= =?Windows-1252?Q?RuCtqxMU9aTP8E8/Hzc+XvsMGKNQ2lOCVKl9PeruM/+/v30xFcXEF032?= =?Windows-1252?Q?F0c1PZ1ZZ+8sZnaGnKdPKf/q21C8IzdpJXhGJC90FZa9OvvDw1kzcIvO?= =?Windows-1252?Q?jicQOU5IK9BKNjPTmhP7MHU64viwjkGV9zcp2JNLPlFrrMVbn8k78PMK?= =?Windows-1252?Q?frTIKziYNv0/pXxznnxMpVI+9A8b7s1yAwW2Z3iioW/406gSlziRoeZN?= =?Windows-1252?Q?6Xkk95ptCtKw0QWWMmK+ydiJnOWqoXAZrcT8c7nWkT2Hy82QQGUokwM+?= =?Windows-1252?Q?tQq2Ou4VbN2ElpCjiiKVEIoWQiGbLUggPzv4u4hJ2mMnKoYft81DAa3u?= =?Windows-1252?Q?858xaO6W+wDZwDd5mRKBvyk8JJIAcSoeDcuKHqQujBqxiaTCZE1RIx0R?= =?Windows-1252?Q?ODiDGJ+tgkra+8ZbK6v1QSDRlqT+7wyRwNJ1fyepO9OyGnQUJD2McSiQ?= =?Windows-1252?Q?kUHY3pkLFc8//NO40cCc5FaXO6Owjzh5Ng/fPclkD1nMTXSrtolHLlrc?= =?Windows-1252?Q?81Gpk4HNvqgvqudhTexox6GybgTyv5szdbqYBz2Z4toO7eGmPxQgft6q?= =?Windows-1252?Q?v8ZjCosyEAykqF1cJ4UUKQ/qD6E4g1Fx+7FoI4G4GoDN1GWpVikkuWFr?= =?Windows-1252?Q?Bhk9HOv5OGZ12PhB8pP1WUz3zG41YUy0QAIeLOYQ/YOa3V5cExLjXCHK?= =?Windows-1252?Q?T+M2B43KArwxKCy0VihwWY49m0Bsz+xsJFDed5N9hXqDIOszzfnRir0D?= =?Windows-1252?Q?Yf77YifEkS2/SI5l2iBTU=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR03MB394; 6:1g/nGseqo0KSfa6TZgHogSKKG+YkGgaOSIOSdcx12mL12aIwnyfjHiTvd1CRnpeuhYOF4IVJ+7HVfFk3AHW8y6m+g5Lv6Nsb7VoDXO+BfdTHIyOknQDfV8eftapwzWJMRJvXYUfWmXYTrG6Dzpsd4epHtSXu2Zc57/AA9Heodvhm7ukbAq7r6VsH8suovwFXyAXahD8SHGmhTyXTKREsSoghTdVGGb21DP5l/C5LrE9tpnPnkmqP20QzyLyOpBEvCdNUkMxQags5SGUK4lEgLRHUVvBjSeeQL9tvLJ73b2oKQDlAmMGWIFQyqk3xOJIl7Ca1j4Vxu6iKUsme/x2Vapuz5LbcoBw22EGZ/iRf6mscCqQgXi6SGXMR6ZgfctdVnWhR8F+7tkIG+rhQxuxyEA==; 5:uCbVGQG4P3ZHsa5s1SaRPwFwXZ63CM+oRabCXXk0jqnJCdAadlp8kRdLtDPo0hbOQUpuOA0hN03a0QJ1ToBojEuWWywF+jYXcHB7Mhc79F8kggL/LdMPMwEse93g7f8pOEWjQv3wlha5eNY9o4ucEq1C3iJXaBWFsw8AHehRpdzW3T0kyNYj09MR3JdQWJZw; 24:A+1pw1XX8iq7s8oq+1cehjCl9wslOwKSVIopXY03HpVSuGMmMZ6pdToy5qHgEqmwLhnkd3DiFA2G22R7+BjSvJse4Asksiyyb+U8JWiAWto= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY2PR03MB394; 7:+cU6BFQsSS79bLhQ/J34nXBLdJlm6cTpeiUiC/cAiE1sma6NDVrQeMvKA5f+F9Oz7pmZbxaCQhyqYaRrh1ilnndYfhkok07Arl5bB2UdqdQZBMS23J8RUjs8BiDObRf6Zet2FWXryp0GX3cL5Qdqi4C/wfG++ii+fKEeM32lEq1eb3s+6cqvvsIAXesyVwhx8+ALD6ddI5Y/eHmm1Czo4472mAwGCj22CECdc3bYWJXpgbJVYl6kbjigTF1G8Zn891HbxzmNRU8X/s2ajACCxi1tNLVQN4GM3Q/5XVgBRd5Gq2SvrtOMEXP3ObBxoyic3QEBRpNFfYyw5Pr7ssvbHA== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2017 09:27:44.6085 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR03MB394 Subject: Re: [dpdk-dev] [RFC PATCH] test/test: support default mempool autotest X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Apr 2017 09:27:47 -0000 On 3/31/2017 8:41 PM, Santosh Shukla wrote: > On Fri, Mar 31, 2017 at 03:47:49PM +0530, Shreyansh Jain wrote: >> Mempool test currently supports: >> * ring_mp_mc >> * stack >> >> In case a new mempool handler is added, there are multiple options >> for supporting that in the mempool autotest: >> 1. Like the patch below, adding a new default pool options >> So, ring* + stack + default (which can be 'stack' or 'ring') >> * This way, whatever the value of RTE_MBUF_DEFAULT_MEMPOOL_OPS is set, >> it would be verified. >> * even if that means duplicating some test (for example when "stack" is >> set as default and it already part of standard test) >> >> 2. Removing stack handler as standard, and moving only to one specified >> by RTE_MBUF_DEFAULT_MEMPOOL_OPS (+ existing ring*) >> * It still leaves space for duplication of ring_mp_mc in case that is >> set to default (as in case of master tree) >> >> 3. Iterating over the list of mempool handlers and performing a set >> or predefined tests >> * reqiures quite a lot of rewrite of mempool autotest >> * specially, allowing some special tests (cache/no-cache) cases when >> a set of variables in loop are being used, would be tricky >> >> 4. only checking the default pool set by RTE_* macro >> * In case a user has build DPDK using a configured value, probably it >> expected that application (or custom applications) would use that >> default handler. >> * would also mean that non-default (non RTE_* value) would not be tested >> even though they are being used. >> >> The decision above would impact how new mempool handlers are added and >> how their testing (API verification) can be done without impacting the >> mempool_autotest file everytime. >> >> Signed-off-by: Shreyansh Jain >> >> --- >> test/test/test_mempool.c | 35 +++++++++++++++++++++++++++++++++-- >> 1 file changed, 33 insertions(+), 2 deletions(-) >> > > I am too using option-2) for my ext-mempool driver and Yes, there is a chance > of 'ring_mp_mc' duplication if left as default. > > BTW: we need similar changes at mempool_perf test too, right? > Are you planning to send, if not then I will propose one. Let me know. Please propose patch for mempool_perf. > > Thanks. > >> diff --git a/test/test/test_mempool.c b/test/test/test_mempool.c >> index b9880b3..aefbf80 100644 >> --- a/test/test/test_mempool.c >> +++ b/test/test/test_mempool.c >> @@ -509,9 +509,11 @@ walk_cb(struct rte_mempool *mp, void *userdata __rte_unused) >> static int >> test_mempool(void) >> { >> + int ret = -1; >> struct rte_mempool *mp_cache = NULL; >> struct rte_mempool *mp_nocache = NULL; >> struct rte_mempool *mp_stack = NULL; >> + struct rte_mempool *default_pool = NULL; >> >> rte_atomic32_init(&synchro); >> >> @@ -561,6 +563,30 @@ test_mempool(void) >> } >> rte_mempool_obj_iter(mp_stack, my_obj_init, NULL); >> >> + /* Create a mempool based on Default handler, if not "stack" */ >> + printf("Testing %s mempool handler\n", >> + RTE_MBUF_DEFAULT_MEMPOOL_OPS); >> + default_pool = rte_mempool_create_empty("default_pool", >> + MEMPOOL_SIZE, >> + MEMPOOL_ELT_SIZE, >> + RTE_MEMPOOL_CACHE_MAX_SIZE, 0, >> + SOCKET_ID_ANY, 0); >> + >> + if (default_pool == NULL) { >> + printf("cannot allocate default mempool\n"); >> + goto err; >> + } >> + if (rte_mempool_set_ops_byname(default_pool, >> + RTE_MBUF_DEFAULT_MEMPOOL_OPS, NULL) < 0) { >> + printf("cannot set default handler\n"); >> + goto err; >> + } >> + if (rte_mempool_populate_default(default_pool) < 0) { >> + printf("cannot populate default mempool\n"); >> + goto err; >> + } >> + rte_mempool_obj_iter(default_pool, my_obj_init, NULL); >> + >> /* retrieve the mempool from its name */ >> if (rte_mempool_lookup("test_nocache") != mp_nocache) { >> printf("Cannot lookup mempool from its name\n"); >> @@ -605,15 +631,20 @@ test_mempool(void) >> if (test_mempool_basic(mp_stack, 1) < 0) >> goto err; >> >> + if (test_mempool_basic(default_pool, 1) < 0) >> + goto err; >> + >> rte_mempool_list_dump(stdout); >> >> - return 0; >> + ret = 0; >> >> err: >> rte_mempool_free(mp_nocache); >> rte_mempool_free(mp_cache); >> rte_mempool_free(mp_stack); >> - return -1; >> + rte_mempool_free(default_pool); >> + >> + return ret; >> } >> >> REGISTER_TEST_COMMAND(mempool_autotest, test_mempool); >> -- >> 2.7.4 >> >