Re: [dpdk-dev] [PATCH 7/7] eal/mem: use DMA mask check for legacy memory

["Burakov, Anatoly" <anatoly.burakov@intel.com>]

On 01-Nov-18 1:39 PM, Alejandro Lucero wrote:
> 
> 
> On Thu, Nov 1, 2018 at 10:40 AM Burakov, Anatoly 
> <anatoly.burakov@intel.com <mailto:anatoly.burakov@intel.com>> wrote:
> 
>     On 31-Oct-18 5:29 PM, Alejandro Lucero wrote:
>      > If a device reports addressing limitations through a dma mask,
>      > the IOVAs for mapped memory needs to be checked out for ensuring
>      > correct functionality.
>      >
>      > Previous patches introduced this DMA check for main memory code
>      > currently being used but other options like legacy memory and the
>      > no hugepages one need to be also considered.
>      >
>      > This patch adds the DMA check for those cases.
>      >
>      > Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com
>     <mailto:alejandro.lucero@netronome.com>>
>      > ---
> 
>     IMO this needs to be integrated with patch 5.
> 
> 
> Not sure about this. patch 5 is a follow-up of patch 4, and this is to 
> add support for other EAL supported memory options.
> 

So it's a followup of patch 5, adding pretty much the same functionality 
(only in a different place). It's pretty safe to say these should be in 
the same patch, or at the very least one after the other.

-- 
Thanks,
Anatoly