From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <anatoly.burakov@intel.com> Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 01BA4683E for <dev@dpdk.org>; Thu, 1 Nov 2018 15:28:23 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Nov 2018 07:28:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,452,1534834800"; d="scan'208";a="246202956" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.72]) ([10.237.220.72]) by orsmga004.jf.intel.com with ESMTP; 01 Nov 2018 07:28:22 -0700 To: Alejandro Lucero <alejandro.lucero@netronome.com> Cc: dev <dev@dpdk.org> References: <20181031172931.11894-1-alejandro.lucero@netronome.com> <20181031172931.11894-8-alejandro.lucero@netronome.com> <545549d1-ba39-96e3-6bf9-219f9f5cba54@intel.com> <CAD+H993m3HstkbiGnDqL7NEzCCxvQD9g1hJ11KcmQRaRL659Kw@mail.gmail.com> From: "Burakov, Anatoly" <anatoly.burakov@intel.com> Message-ID: <543d1d8c-5dd5-e88f-3b9a-8aefe0add6d9@intel.com> Date: Thu, 1 Nov 2018 14:28:20 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <CAD+H993m3HstkbiGnDqL7NEzCCxvQD9g1hJ11KcmQRaRL659Kw@mail.gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 7/7] eal/mem: use DMA mask check for legacy memory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 01 Nov 2018 14:28:24 -0000 On 01-Nov-18 1:39 PM, Alejandro Lucero wrote: > > > On Thu, Nov 1, 2018 at 10:40 AM Burakov, Anatoly > <anatoly.burakov@intel.com <mailto:anatoly.burakov@intel.com>> wrote: > > On 31-Oct-18 5:29 PM, Alejandro Lucero wrote: > > If a device reports addressing limitations through a dma mask, > > the IOVAs for mapped memory needs to be checked out for ensuring > > correct functionality. > > > > Previous patches introduced this DMA check for main memory code > > currently being used but other options like legacy memory and the > > no hugepages one need to be also considered. > > > > This patch adds the DMA check for those cases. > > > > Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com > <mailto:alejandro.lucero@netronome.com>> > > --- > > IMO this needs to be integrated with patch 5. > > > Not sure about this. patch 5 is a follow-up of patch 4, and this is to > add support for other EAL supported memory options. > So it's a followup of patch 5, adding pretty much the same functionality (only in a different place). It's pretty safe to say these should be in the same patch, or at the very least one after the other. -- Thanks, Anatoly