From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B267BA00C5; Thu, 7 May 2020 22:08:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1E3551D9EA; Thu, 7 May 2020 22:08:09 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 8E2521D979 for ; Thu, 7 May 2020 22:08:07 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 34CBD5C012F; Thu, 7 May 2020 16:08:07 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 07 May 2020 16:08:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 0M3FuPmd/En3IChLQfBrtBudEQFig2WV9Tr/X83zpuw=; b=YW/BJe/MekdqMR9e E0LBv1bUea88kZW95b7omkUvAaKMzRm/cf/xSoW58a8G4sk59cQLkRxakaP27qv6 zRevuRhTQ2DnkPopYKbYhY4wQk47Ip36YYGSMWdqhT3Wby4vlORvIWub2Mty9GvQ 1c+eIe+PKSIfQRHpTuJK8f23JtURljZeVQxbffXO979VDMCzZ4LTgyVoIB7AL8tc YB/rFNsYOM8wbdF7sTslQx3v9BgsSDwjCBYRt6DCfU/hCMstnpEL0xPZxTwsZqip EZS4ixlDsgEOKW1btmJWKQrjU/QqnK2FfS4JrM5A0PoBzzFosXVOW6FNWhhqUS6u zqAmhw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=0M3FuPmd/En3IChLQfBrtBudEQFig2WV9Tr/X83zp uw=; b=ig2CHn42aQPpRXiYOz5cN7ZPWVJar/zGzlfXUkBQsNHX21xWggEKNMfvm i87l0GUrY1xKbVAH7vA57wfiPCc3Av8z2IQug/hwBE/rhqLHd+xU+esUTLuUUnRn IPHIJpE5/qcKUm9t4HweGPZMZN2kT/UyL60W1f8IwSZH64iCHJKhqv1adfEQhpNZ GllfOEydQKqB7I2jM/9g/PBsJWYhjn27ijmoz2hTAhMD/gmapwqiW71eDwh/lvFY Wxpi66uofJjjGnHgYzuIvvJPuUDdf7EuwNYxR+IZfpU4ONA715Gt9IdvBaVpiNFX BTK+ty0KHv1NWvQokftemqmAAhVRQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrkedtgddugeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4C9C030661D4; Thu, 7 May 2020 16:08:06 -0400 (EDT) From: Thomas Monjalon To: Ophir Munk Cc: "dev@dpdk.org" , David Marchand , Ray Kinsella , Matan Azrad , Raslan Darawsheh Date: Thu, 07 May 2020 22:08:05 +0200 Message-ID: <5442514.zQ0Gbyo6oJ@thomas> In-Reply-To: References: <20200507073702.4047-2-ophirmu@mellanox.com> <2189631.BjyWNHgNrj@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 1/2] common/mlx5: add rte internal tag and avoid comparison X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 07/05/2020 13:41, Ophir Munk: > From: Thomas Monjalon > > 07/05/2020 10:56, Ophir Munk: > > > Move mlx5 symbols in the map file to the INTERNAL section and add > > > __internal tags to their definitions. > > > Those symbols were exported in 20.02 and now (20.05) they are removed. > > [...] > > > --- a/drivers/common/mlx5/rte_common_mlx5_version.map > > > +++ b/drivers/common/mlx5/rte_common_mlx5_version.map > > > @@ -1,8 +1,10 @@ > > > -DPDK_21 { > > > +INTERNAL { > > > > I think you forgot the EXPERIMENTAL section. > > In my opinion, everything should be in INTERNAL and marked with > > __rte_internal in source code. > > > > I moved all EXPERIMENTAL to INTERNAL and sent V4. > A general question: what is the difference between EXPERIMENTAL and INTERNAL functionalities? > In the end both indicate to skip ABI check. Regarding ABI check, yes the result is the same. Regarding API, it is different: INTERNAL is forbidden to applications, while EXPERIMENTAL is to be used with cautious as compatibility is not guaranteed.