From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id EEFE9A034F;
Wed, 6 May 2020 16:26:14 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 723DC1D705;
Wed, 6 May 2020 16:26:14 +0200 (CEST)
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 2F6BB1D6D4
for <dev@dpdk.org>; Wed, 6 May 2020 16:26:13 +0200 (CEST)
Received: from mx1-us1.ppe-hosted.com (unknown [10.110.50.137])
by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id
CC5DA200B3; Wed, 6 May 2020 14:26:12 +0000 (UTC)
Received: from us4-mdac16-18.at1.mdlocal (unknown [10.110.49.200])
by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id C9C7F6009B;
Wed, 6 May 2020 14:26:12 +0000 (UTC)
X-Virus-Scanned: Proofpoint Essentials engine
Received: from mx1-us1.ppe-hosted.com (unknown [10.110.48.236])
by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 46461220078;
Wed, 6 May 2020 14:26:12 +0000 (UTC)
Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))
(No client certificate requested)
by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id CF72B400059;
Wed, 6 May 2020 14:26:11 +0000 (UTC)
Received: from [192.168.38.17] (10.17.10.39) by ukex01.SolarFlarecom.com
(10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 6 May 2020
15:25:55 +0100
To: Wisam Jaddo <wisamm@mellanox.com>, <dev@dpdk.org>, <jackmin@mellanox.com>,
<thomas@monjalon.net>, <jerinjacobk@gmail.com>, <gerlitz.or@gmail.com>,
<l.yan@epfl.ch>, <ajit.khaparde@broadcom.com>
References: <20200430103341.1845-2-wisamm@mellanox.com>
<20200506123627.22340-1-wisamm@mellanox.com>
<20200506123627.22340-2-wisamm@mellanox.com>
From: Andrew Rybchenko <arybchenko@solarflare.com>
Autocrypt: addr=arybchenko@solarflare.com; keydata=
mQINBF2681gBEACbdTxu8eLL3UX2oAelsnK9GkeaJeUYSOHPJQpV7RL/iaIskqTwBRnhjXt7
j9UEwGA+omnOmqQMpeQTb/F9Ma2dYE+Hw4/t/1KVjxr3ehFaASvwR4fWJfO4e2l/Rk4rG6Yi
5r6CWU2y8su2654Fr8KFc+cMGOAgKoZTZHZsRy5lHpMlemeF+VZkv8L5sYJWPnsypgqlCG3h
v6lbtfZs+QqYbFH6bqoZwBAl5irmxywGR7ZJr1GLUZZ1lfdazSY8r6Vz0/Ip/KVxGu2uxo81
QCsAj0ZsQtwji9Sds/prTiPrIjx8Fc/tfbnAuVuPcnPbczwCJACzQr4q26XATL3kVuZhSBWh
4XfO/EAUuEq5AemUG5DDTM87g7Lp4eT9gMZB6P+rJwWPNWTiV3L7Cn+fO+l9mTPnOqdzBgDe
OaulKiNSft1o0DY4bGzOmM2ad2cZt0jfnbMPMTE9zsr6+RFa+M8Ct20o6U1MUE4vP6veErMK
of4kZ8PdoMM+Sq1hxMPNtlcVBSP9xMmdSZPlfDYI5VWosOceEcz7XZdjBJKdwKuz70V7eac4
ITSxgNFCTbeJ03zL2MR5s0IvD9ghISAwZ6ieCjU5UATn5+63qpD0nVNLsAdb/UpfvQcKAmvj
0fKlxu/PMVkjBa7/4cfNogYOhWDKUO+1pMaFwvb6/XTo6uMpfQARAQABtCxBbmRyZXcgUnli
Y2hlbmtvIDxhcnliY2hlbmtvQHNvbGFyZmxhcmUuY29tPokCVAQTAQoAPhYhBP6NPgcKRj/Y
X0yXQahue0sAy4m+BQJduvNYAhsDBQkB4TOABQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ
EKhue0sAy4m+t3gP/j1MNc63CEozZo1IZ2UpVPAVWTYbLdPjIRdFqhlwvZYIgGIgIBk3ezKL
K0/oc4ZeIwL6wQ5+V24ahuXvvcxLlKxfbJ6lo2iQGC7GLGhsDG9Y2k6sW13/sTJB/XuR2yov
k5FtIgJ+aHa1PDZnepnGGOt9ka9n/Jzrc9WKYapOIIyLRe9U26ikoVgyqsD37PVeq5tLWHHA
NGTUKupe9G6DFWidxx0KzyMoWDTbW2AWYcEmV2eQsgRT094AZwLFN5ErfefYzsGdO8TAUU9X
YTiQN2MvP1pBxY/r0/5UfwV4UKBcR0S3ZvzyvrPoYER2Kxdf/qurx0Mn7StiCQ/JlNZb/GWQ
TQ7huduuZHNQKWm7ufbqvKSfbPYvfl3akj7Wl8/zXhYdLqb5mmK45HXrgYGEqPN53OnK2Ngx
IgYKEWr05KNv09097jLT5ONgYvszflqlLIzC4dV245g7ucuf9fYmsvmM1p/gFnOJBJL18YE5
P1fuGYNfLP+qp4WMiDqXlzaJfB4JcinyU49BXUj3Utd6f6sNBsO8YWcLbKBV9WmA324S3+wj
f4NPRp3A5E+6OmTVMLWire2ZvnYp3YvifUj1r8lhoZ2B2vKuWwiTlHOKYBEjnOQJQnqYZEF0
JQQ1xzVDBQKE01BPlA3vy6BGWe6I4psBVqMOB9lAev/H+xa4u6Z3uQINBF269JsBEAC2KB3W
8JES/fh74avN7LOSdK4QA7gFIUQ4egVL81KnxquLzzilABuOhmZf3Rq6rMHSM8xmUAWa7Dkt
YtzXStjEBI/uF0mAR3mMz1RcL2Wp+WD/15HjVpA7hPjXSEsWY0K2ymPerK4yrLcfFTHdMonY
JfuACCC9NtOZxrWHOJoUS+RT7AWk80q/6D2iwQ47/2dBTznVG+gSeHSes9l91TB09w6f9JX/
sT+Ud0NQfm7HJ7t2pmGI9O6Po/NLZsDogmnIpJp/WwYOZN9JK7u2FyX2UyRzR8jK42aJkRsh
DXs16Cc2/eYGakjrdO3x9a+RoxN7EuFtYhGR1PzMXdUiB5i+FyddYXkYUyO43QE/3VPA5l1v
TUOagzZq6aONsdNonGJkV3TIG3JmUNtM+D/+r6QKzmgoJ8w576JxEZI09I/ZFN+g7BnUmlMx
6Z3IUOXVX/SWfGFga0YajwajHz03IBhChEbYbbqndVhmshu2GFURxrfUPYWdDXEqkh+08a5U
Didia9jm2Opv4oE1e1TXAePyYJl/Zyps4Cv00GObAxibvMBQCUZQ+IBnNldRBOwXXRQV2xpx
P+9iO1VYA/QXn0KqRK+SH1JGRXbJYi42YFaW1gE0EU0fiR2Wb9pK+doNEjjOhlzUGuvOEAUS
+4m0m3dlfEvpCV9GMr7ERRpZzh9QkQARAQABiQI8BBgBCgAmFiEE/o0+BwpGP9hfTJdBqG57
SwDLib4FAl269JsCGwwFCQlmAYAACgkQqG57SwDLib7x6g//e+eCtNnJz7qFGbjWRJYNLCe5
gQwkhdyEGk4omr3VmjGj3z9kNFy/muh4pmHUngSAnnpwZggx14N4hhKf9y8G4Dwvsqa6b1zB
Jq/c4t/SBDtGW4M/E331N04PaQZpcrbTfp1KqHNknk2N7yOk4CcoLVuIZmA5tPguASV8aAfz
ZwhWAwn6vUEw9552eXEAnGFGDTCbyryNwzB5jtVQOEEDjTxcCkpcXMB45Tb1QUslRTu/sBAe
HhPCQSUcJHR+KOq+P6yKICGAr291PZd6Qc7C3UyE+A3pY/UfdEVWj0STBWx1qvYLaHLrI4O9
KXDgh7luLjZZafcueCaPYmNo4V2lmNb3+7S4TvqhoZS+wN+9ldRQ4gH3wmRZybN6Y/ZCqxol
RaZpE3AqdWsGvIgAkD0FpmtZNii9s2pnrhw0K6S4t4tYgXGTossxNSJUltfFQZdXM1xkZhtv
dBZuUEectbZWuviGvQXahOMuH2pM64mx2hpdZzPcI2beeJNHkAsGT2KcaMETgvtHUBFRlLVB
YxsUYz3UZmi2JSua4tbcGd6iWVN90eb8CxszYtivfpz6o2nPSjNwg0NaVGSHXjAK0tdByZ9t
SkwjC3tEPljVycRSDpbauogOiAkvjENfaPd/H26V5hY822kaclaKDAW6ZG9UKiMijcAgb9u5
CJoOyqE8aGS5Ag0EXbr1RwEQAMXZHbafqmZiu6Kudp+Filgdkj2/XJva5Elv3fLfpXvhVt0Y
if5Rzds3RpffoLQZk9nPwK8TbZFqNXPu7HSgg9AY7UdCM94WRFTkUCGKzbgiqGdXZ7Vyc8cy
teGW+BcdfQycDvjfy50T3fO4kJNVp2LDNdknPaZVe8HJ80Od63+9ksB6Ni+EijMkh6Uk3ulB
CSLnT4iFV57KgU2IsxOQVLnm+0bcsWMcCnGfphkY0yKP+aJ6MfmZkEeaDa7kf24N14ktg50m
vOGDitcxA/+XXQXOsOIDJx1VeidxYsQ2FfsKu1G8+G6ejuaLf4rV5MI/+B/tfLbbOdikM5PF
pxZVgTir9q13qHumMxdme7w5c7hybW412yWAe9TsrlXktFmFjRSFzAAxQhQSQxArS6db4oBk
yeYJ59mW52i4occkimPWSm/raSgdSM+0P6zdWUlxxj+r1qiLgCYvruzLNtp5Nts5tR/HRQjE
/ohQYaWDSVJEsc/4eGmgwzHzmvHtXeKkasn01381A1Lv3xwtpnfwERMAhxBZ8EGKEkc5gNdk
vIPhknnGgPXqKmE1aWu8LcHiY+RHAF8gYPCDMuwyzBYnbiosKcicuIUp0Fj8XIaPao6F+WTi
In4UOrqrYhsaCUvhVjsTBbNphGih9xbFJ8E+lkTLL8P3umtTcMPnpsB4xqcDABEBAAGJBHIE
GAEKACYWIQT+jT4HCkY/2F9Ml0GobntLAMuJvgUCXbr1RwIbAgUJCWYBgAJACRCobntLAMuJ
vsF0IAQZAQoAHRYhBNTYjdjWgdaEN5MrAN+9UR5r/4d3BQJduvVHAAoJEN+9UR5r/4d3EiQP
/3lyby6v49HTU94Q2Fn2Xat6uifR7kWE5SO/1pUwYzx6v+z5K2jqPgqUYmuNoejcGl0CTNhg
LbsxzUmAuf1OTAdE+ZYvOAjjKQhY4haxHc4enby/ltnHfWJYWJZ9UN5SsIQLvITvYu6rqthO
CYjpXJhwkj3ODmC9H1TrvjrBGc6i7CTnR8RCjMEwCs2LI2frHa4R6imViEr9ScMfUnzdABMQ
B0T5MOg8NX92/FRjTldU2KovG0ML9mSveSvVHAoEBLy4UIs5nEDdNiO1opJgKb5CXvWQugub
7AR52phNdKVdEB0S4tigJT4NalyTaPiUhFEm+CzZpMQDJ5E+/OowaPRfN4HeJX+c8sB+vUAZ
mkAaG75N+IEk5JKFK9Z+bBYgPgaBDFZYdWDB/TMH0ANt+KI5uYg0i12TB4M8pwKG1DEPUmWc
F2YpvB3jnbwzsOpSFiJOOlSs6nOB0Sb5GRtPOO3h6XGj+6mzQd6tcL63c9TrrUkjq7LDkxCz
SJ2hTYRC8WNX8Uw9skWo5728JNrXdazEYCenUWmYiKLNKLslXCFodUCRDh/sUiyqRwS7PHEA
LYC/UIWLMomI0Yvju3KA5v3RQVXhL+Gx2CzSj3GDz9xxGhJB2LfRfjzPbTR/Z27UpjCkd8z0
Ro3Ypmi1FLQwnRgoOKDbetTAIhugEShaLTITzJAP/iRDJCQsrZah5tE8oIl81qKEmBJEGcdt
HYikbpQe7ydcXhqTj7+IECa3O7azI5OhCxUH2jNyonJ/phUslHH2G1TTBZK8y4Hrx5RpuRNS
esn3P9uKu9DHqBAL7DMsCPwb2p1VNnapD72DBmRhzS/e6zS2R4+r9yNv03Hv7VCxKkmtE63H
qpS//qpjfrtsIcHAjnKDaDtL1LYCtHoweI+DOpKKULSAYp/JE6F8LNibPQ0/P3S5ZIJNC4QZ
uESjFOalJwFIqGQdkQB7ltRNJENLrHc+2jKGOuyFHm/Sbvp5EMGdaeQ0+u8CY0P+y6oXenwx
7WrJz/GvbNoFhJoJ6RzxCMQrFgxrssVZ7w5HcUj94lbnJ6osdYE/WpSd50B6jet6LKh5revg
u9XI9CoqsPQ1V4wKYYdllPuogCye7KNYNKuiiuSNpaF4gHq1ZWGArwZtWHjgc2v3LegOpRQF
SwOskMKmWsUyHIRMG1p8RpkBQTqY2rGSeUqPSvaqjT0nq+SUEM6qxEXD/2Wqri/X6bamuPDb
S0PkBvFD2+0zr5Bc2YkMGPBYPNGZiTp3UjmZlLfn3TiBKIC92jherY563CULjSsiBEJCOSvv
4VPLn5aAcfbCXJnE3IGCp/hPl50iQqu7BPOYBbWXeb9ptDjGCAThNxSz0WAXkmcjAFE8gdE6 Znk9
Message-ID: <54556a1d-b30a-8032-eca9-8d84c7036f00@solarflare.com>
Date: Wed, 6 May 2020 17:25:51 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20200506123627.22340-2-wisamm@mellanox.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.17.10.39]
X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To
ukex01.SolarFlarecom.com (10.17.10.4)
X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1020-25402.001
X-TM-AS-Result: No-12.435200-8.000000-10
X-TMASE-MatchedRID: 1ZHks2aQIkjmLzc6AOD8DfHkpkyUphL9NV9S7O+u3KaLpJo1lI9JPWt3
XuGO9TptM22M43riQ2qQKl4RwWngioyEjCdqw8f7T7O/YHJhINBLXPA26IG0hN9RlPzeVuQQFSx
iD1T+DkGmetUkUbFUWFlvisljT6pveg7nwmtcFgdqZ6OipRp3esG1o1Ri9o2EDlLOAk1ICsso5c
kMUU4549jrGJWvvRFdAG6+QM9NR6jpZjhn1xhQXEhwlOfYeSqxO4NrJdLQuoFXwSAPS85a5Kph1
iI3bpfXvvJoxo0uTMROPTaCZM51XStlmMVXRNpfW1M77Gh1ugYCn5QffvZFlRwj+lmz7HEvXWjv
A8TpWFhfcFe+9WeqONnl43V4kx2l7EeIa6DkuX2628cXbnOhT0qAhuLHn5fEH1bhq4z+yfS6oET
kkHtXERKxKu0tNopoVnyQq4nIFItLCiMVfxYIMHV7tdtvoibaL1eX+z9B1QxXsxBNtOXTb2lys1
PDhWLofqEVNiWxkpGktBPUVh2tm5wZRjFC2Tk9IAjxomarSPDdYVrFVbszaLobGHR5ejtrvaMTU
CzrBGYX+qvsE8ezmyaYRYCvh+oDF/SOqDyCKWnD0ZWEZr/ntpyqUJ2uHKFAFBQ5IKls/A5+6cSo
WGNdJ+pYfg37pXOzSkuSn28laKSluxoAAQHm8r9fDAbrSP02IiTd2l7lf6EPIbBu4llm3jBXXb/
qS2632E6HipP5OtKRk6XtYogiau9c69BWUTGwVnRXm1iHN1bEQdG7H66TyH4gKq42LRYkjcSGV4
WIbI1p1l7Al3DOKL4tSLEVXRDdjwNkbN4Xq0x+3BndfXUhXQ==
X-TM-AS-User-Approved-Sender: Yes
X-TM-AS-User-Blocked-Sender: No
X-TMASE-Result: 10--12.435200-8.000000
X-TMASE-Version: SMEX-12.5.0.1300-8.5.1020-25402.001
X-MDID: 1588775172-cQX8nAmNJ3Tk
Subject: Re: [dpdk-dev] [PATCH v5 1/5] app/flow-perf: add flow performance
skeleton
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 5/6/20 3:36 PM, Wisam Jaddo wrote:
> Add flow performance application skeleton.
>
> Signed-off-by: Wisam Jaddo <wisamm@mellanox.com>
> ---
[snip]
> diff --git a/app/test-flow-perf/main.c b/app/test-flow-perf/main.c
> new file mode 100644
> index 000000000..7a924cdb7
> --- /dev/null
> +++ b/app/test-flow-perf/main.c
> @@ -0,0 +1,200 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright 2020 Mellanox Technologies, Ltd
> + *
> + * This file contain the application main file
> + * This application provides the user the ability to test the
> + * insertion rate for specific rte_flow rule under stress state ~4M rule/
> + *
> + * Then it will also provide packet per second measurement after installing
> + * all rules, the user may send traffic to test the PPS that match the rules
> + * after all rules are installed, to check performance or functionality after
> + * the stress.
> + *
> + * The flows insertion will go for all ports first, then it will print the
> + * results, after that the application will go into forwarding packets mode
> + * it will start receiving traffic if any and then forwarding it back and
> + * gives packet per second measurement.
> + */
> +
> +#include <stdio.h>
> +#include <stdlib.h>
> +#include <string.h>
> +#include <stdint.h>
> +#include <inttypes.h>
> +#include <stdarg.h>
> +#include <errno.h>
> +#include <getopt.h>
> +#include <signal.h>
> +#include <stdbool.h>
> +#include <sys/time.h>
> +
> +#include <rte_malloc.h>
> +#include <rte_mempool.h>
> +#include <rte_mbuf.h>
> +#include <rte_ethdev.h>
> +#include <rte_flow.h>
> +
> +#include "config.h"
> +
> +static uint32_t nb_lcores;
> +static struct rte_mempool *mbuf_mp;
> +
> +static void
> +usage(char *progname)
> +{
> + printf("\nusage: %s\n", progname);
> +}
> +
> +static void
> +args_parse(int argc, char **argv)
> +{
> + char **argvopt;
> + int opt;
> + int opt_idx;
> + static struct option lgopts[] = {
> + /* Control */
> + { "help", 0, 0, 0 },
> + };
> +
> + argvopt = argv;
> +
> + while ((opt = getopt_long(argc, argvopt, "",
> + lgopts, &opt_idx)) != EOF) {
> + switch (opt) {
> + case 0:
> + if (!strcmp(lgopts[opt_idx].name, "help")) {
DPDK coding style recommends to compare vs 0 instead of logical
not.
> + usage(argv[0]);
> + rte_exit(EXIT_SUCCESS, "Displayed help\n");
> + }
> + break;
> + default:
> + printf("Invalid option: %s\n", argv[optind]);
Again, sorry if I missed reply: Why error is not logged to
stderr?
> + usage(argv[0]);
> + rte_exit(EXIT_SUCCESS, "Invalid option\n");
> + break;
> + }
> + }
> +}
> +
> +static void
> +init_port(void)
> +{
> + int ret;
> + uint16_t i;
> + uint16_t port_id;
> + uint16_t nr_ports;
> + struct rte_eth_conf port_conf = {
> + .rx_adv_conf = {
> + .rss_conf.rss_hf =
> + ETH_RSS_IP |
> + ETH_RSS_TCP,
> + }
> + };
> + struct rte_eth_txconf txq_conf;
> + struct rte_eth_rxconf rxq_conf;
> + struct rte_eth_dev_info dev_info;
> +
> + nr_ports = rte_eth_dev_count_avail();
> + if (nr_ports == 0)
> + rte_exit(EXIT_FAILURE, "Error: no port detected\n");
> +
> + mbuf_mp = rte_pktmbuf_pool_create("mbuf_pool",
> + TOTAL_MBUF_NUM, MBUF_CACHE_SIZE,
> + 0, MBUF_SIZE,
> + rte_socket_id());
> + if (mbuf_mp == NULL)
> + rte_exit(EXIT_FAILURE, "Error: can't init mbuf pool\n");
> +
> + for (port_id = 0; port_id < nr_ports; port_id++) {
> + ret = rte_eth_dev_info_get(port_id, &dev_info);
> + if (ret != 0)
> + rte_exit(EXIT_FAILURE,
> + "Error during getting device"
> + " (port %u) info: %s\n",
> + port_id, strerror(-ret));
> +
> + port_conf.txmode.offloads &= dev_info.tx_offload_capa;
> + port_conf.rxmode.offloads &= dev_info.rx_offload_capa;
> +
> + printf(":: initializing port: %d\n", port_id);
> +
> + ret = rte_eth_dev_configure(port_id, RXQ_NUM,
> + TXQ_NUM, &port_conf);
> + if (ret < 0)
> + rte_exit(EXIT_FAILURE,
> + ":: cannot configure device: err=%d, port=%u\n",
> + ret, port_id);
> +
> + rxq_conf = dev_info.default_rxconf;
> + rxq_conf.offloads = port_conf.rxmode.offloads;
As far as I know there is no necessity to repeat port offlaod
on queue level. So, the line is not necesary.
> +
> + for (i = 0; i < RXQ_NUM; i++) {
> + ret = rte_eth_rx_queue_setup(port_id, i, NR_RXD,
> + rte_eth_dev_socket_id(port_id),
> + &rxq_conf,
> + mbuf_mp);
> + if (ret < 0)
> + rte_exit(EXIT_FAILURE,
> + ":: Rx queue setup failed: err=%d, port=%u\n",
> + ret, port_id);
> + }
> +
> + txq_conf = dev_info.default_txconf;
> + txq_conf.offloads = port_conf.txmode.offloads;
As far as I know there is no necessity to repeat port offlaod
on queue level. So, the line is not necesary.
> +
> + for (i = 0; i < TXQ_NUM; i++) {
> + ret = rte_eth_tx_queue_setup(port_id, i, NR_TXD,
> + rte_eth_dev_socket_id(port_id),
> + &txq_conf);
> + if (ret < 0)
> + rte_exit(EXIT_FAILURE,
> + ":: Tx queue setup failed: err=%d, port=%u\n",
> + ret, port_id);
> + }
> +
> + /* Catch all packets from traffic generator. */
> + ret = rte_eth_promiscuous_enable(port_id);
> + if (ret != 0)
> + rte_exit(EXIT_FAILURE,
> + ":: promiscuous mode enable failed: err=%s, port=%u\n",
> + rte_strerror(-ret), port_id);
> +
> + ret = rte_eth_dev_start(port_id);
> + if (ret < 0)
> + rte_exit(EXIT_FAILURE,
> + "rte_eth_dev_start:err=%d, port=%u\n",
> + ret, port_id);
> +
> + printf(":: initializing port: %d done\n", port_id);
> + }
> +}
> +
> +int
> +main(int argc, char **argv)
> +{
> + int ret;
> + uint16_t port;
> + struct rte_flow_error error;
> +
> + ret = rte_eal_init(argc, argv);
> + if (ret < 0)
> + rte_exit(EXIT_FAILURE, "EAL init failed\n");
> +
> + argc -= ret;
> + argv += ret;
> + if (argc > 1)
> + args_parse(argc, argv);
> +
> + init_port();
> +
> + nb_lcores = rte_lcore_count();
> + if (nb_lcores <= 1)
> + rte_exit(EXIT_FAILURE, "This app needs at least two cores\n");
> +
> + RTE_ETH_FOREACH_DEV(port) {
> + rte_flow_flush(port, &error);
> + rte_eth_dev_stop(port);
> + rte_eth_dev_close(port);
> + }
> + return 0;
> +}
[snip]
> diff --git a/config/common_base b/config/common_base
> index 14000ba07..b2edd5267 100644
> diff --git a/doc/guides/rel_notes/release_20_05.rst b/doc/guides/rel_notes/release_20_05.rst
> index b124c3f28..258b1e03e 100644
> --- a/doc/guides/rel_notes/release_20_05.rst
> +++ b/doc/guides/rel_notes/release_20_05.rst
> @@ -212,6 +212,16 @@ New Features
> * Added IPsec inbound load-distribution support for ipsec-secgw application
> using NIC load distribution feature(Flow Director).
>
> +* **Added flow performance application.**
> +
> + Add new application to test rte_flow performance.
> +
> + Application features:
> + * Measure rte_flow insertion rate.
> + * Measure rte_flow deletion rate.
> + * Dump rte_flow memory consumption.
> + * Measure packet per second forwarding.
I think above lines should be added in appropriate patches
which really do it.
> +
>
> Removed Items
> -------------
[snip]