From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 551B45A98
 for <dev@dpdk.org>; Thu, 20 Apr 2017 00:21:50 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id D311520C7F;
 Wed, 19 Apr 2017 18:21:49 -0400 (EDT)
Received: from frontend1 ([10.202.2.160])
 by compute1.internal (MEProxy); Wed, 19 Apr 2017 18:21:49 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=ZEAXk1CdvYRuwfN
 CTzNLcZABdkPhA0j5aIB7oBs29+M=; b=LX0aGFekCoqeX87xLYlTMyjod3M52M8
 YvuhYQxN/aKsZQECz1yj9AuppZYwfrOZg8D/9g0NDsHSWmEIDbGMPMJyVttKfgXw
 pqH7HyzA4Ukwt865xJQBEbajSJftw199EsNFf39CkQYanaPuBQxtZz9ZphOTqnOw
 5tVs3SHOLd+E=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=
 fm1; bh=ZEAXk1CdvYRuwfNCTzNLcZABdkPhA0j5aIB7oBs29+M=; b=jE5wyNhB
 UotvEc0H+Fh+WlSVrS6cjbtUQe90eyidPGlMnM/nlqdkXPiBRhgGu+NMS9nhLok2
 XghhwLnS6Y9XBFrX2g6Z021cMkCoPPTT9HqUalNhI6bit1ZjZ+Phb8iJuh3z5T+i
 KZuK2XSTNLbrehIEzUuA8GrrLNJCdlZqRAxnatnqkaAaPwR/1FFbIqi8dWcpKVcy
 /wiTmuZWBX2m2GQRo15XnOyINt6ECklZTdNSEIn9naQuBmiujoIMSyDH3FsFTqKV
 R70ZEXlh4eanQqXDq2i7JQ8MTxRw8joRYTt1VCyhDgE0zd8oSVbhh1lwJcssUIOC
 xlaY86yXRWEi1w==
X-ME-Sender: <xms:_eL3WK0vTa38FgZw4PinnrmdN_iMnTi5kMMPbvkX_hRsIQhxS1C-NQ>
X-Sasl-enc: /Q2v6irC4slRTChg+nducnz58Nm8EiWUzQrJrj2g6Ihk 1492640509
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 881B77E2B0;
 Wed, 19 Apr 2017 18:21:49 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Harry van Haaren <harry.van.haaren@intel.com>
Cc: dev@dpdk.org, Jerin Jacob <jerin.jacob@caviumnetworks.com>,
 ferruh.yigit@intel.com
Date: Thu, 20 Apr 2017 00:21:48 +0200
Message-ID: <5459454.5IYbonOstQ@xps>
In-Reply-To: <20170415045811.GA9449@jerin>
References: <1492185898-43547-1-git-send-email-harry.van.haaren@intel.com>
 <20170415045811.GA9449@jerin>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] eventdev: fix dequeue timeout bitmask
	brackets
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Apr 2017 22:21:50 -0000

> > Fix brackets around the & operator to first mask a single bit
> > and then perform the not operator. Previously the result was
> > not as expected, due to the ! operator being performed first.
> > 
> > As noted on list[1] Clang 4.0 warns about a possible bug for
> > 
> > this type of line:
> > 	if (!variable & FLAG) {
> > 
> > Fixes: 4f0804bbdfb9 ("eventdev: implement the northbound APIs")
> > 
> > Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> 
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

A similar patch has been applied, sorry:
	http://dpdk.org/commit/27e9fb84