From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08905A04B1; Sun, 22 Nov 2020 18:57:45 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C0CB872DD; Sun, 22 Nov 2020 18:57:43 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 458FA72D8; Sun, 22 Nov 2020 18:57:41 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id C58B45C0131; Sun, 22 Nov 2020 12:57:39 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 22 Nov 2020 12:57:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= drcj0ug8k1UpncVEMGrrGerNaCGR9kQ3zjhZAgyxpAM=; b=fSQiZbW7pD3i2MYL 63FR7IdmMVTd84IpiJXIG53oml04jnW9OAWFgUAvCV+wT/MQK9/LnFlK7CC/KINn CuCdHcuVAoJynAdi6UV48Fks+jOfyYgRom3fSjgWqRBMY26Jd1HqgrFGI90kMCD9 x2g6xsx5TcBWtCBxAq3z+v32EobvcZD2DAYBeUhgnrDzs1Y/TlMWPqMyj211jrO/ GMpYOOW/hv5gVJ1D6wMyfhezu8EqG4KxMJzczCsEzGNb53qCjBIvFSPGNGwHEbg/ V//8L9yKJ4D7ZZu0QbIaXg/nKcqha5yQiuiY4TJCSIwRw+xZ6mc8m+IuLooTl+Kf an5WFw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=drcj0ug8k1UpncVEMGrrGerNaCGR9kQ3zjhZAgyxp AM=; b=O7QR660P5vmnnhKGU+jY5iZUgmnxettTSdzwjsqCfnfSxrgblcpQvHZ10 FCTVi/feeIMgBQXMYyT0slxhbV0TAf6iUSaXqEzxoGKW51g5pTF/9PvFDQdfe0Ly 8muozXLQhsewGlNzRROB2L/iieHpP1tz5G8H1poiuYrlfHvWQcQ+Acb5CcBnmIbw ZOxkVoUZhRyDjvSCajwGSbTJnaGdOhbafz2ssmFwJwANTbdp6rAxYtZIYWMQWBHD ElOdybzkTtrPLvl0Izm9AbdYo9MjBajNeBoud/c4TE8pvx53f5XjiyWvd03M3x2E ugvriK1oVkUnzDoCKyBX7d+xGUH7A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeggedguddutdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 488FD328005A; Sun, 22 Nov 2020 12:57:38 -0500 (EST) From: Thomas Monjalon To: Nick Connolly Cc: Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , stable@dpdk.org, "dev@dpdk.org" , Tal Shnaiderman Date: Sun, 22 Nov 2020 18:57:36 +0100 Message-ID: <5460782.JXDLM6G52u@thomas> In-Reply-To: References: <20201120211255.24803-1-nick.connolly@mayadata.io> <20201122084515.26348-1-nick.connolly@mayadata.io> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3] eal/windows: fix link error with MinGW X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > Linking with the 'pci' driver when building with MinGW on Windows fails with > > undefined symbol 'GUID_DEVCLASS_NET'. > > This occurs because devguid.h is included in rte_windows.h before INITGUID > > is defined. > > > > Move the include of devguid.h after the definition of INITGUID. > > > > Fixes: b762221ac24f ("bus/pci: support Windows with bifurcated drivers") > > Cc: stable@dpdk.org > > > > Signed-off-by: Nick Connolly > > Reviewed-by: Tal Shnaiderman Applied, thanks