From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id C1B901B6CB; Wed, 17 Apr 2019 16:59:55 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 44CC521FFC; Wed, 17 Apr 2019 10:59:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 17 Apr 2019 10:59:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=W+Cv/EuxJpe0wshKp6vkwmKzdqahW1O4s8aSPmv9oxA=; b=Pf78hquvCNa6 ySy1GuFn+n1qqtHUKNwByApd5zhketr6ZG+UrHPnlX49VzKk/6hx8zMtZrBF1YpY vSE0ahwqsbM4h/PEbv4tTosR52gjQvomhPu8pIExn4XOp3IKlmzUQWXKmtDoj7mT LtEpye+tVSpuM7x8JTiGMDLLGp66nGw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=W+Cv/EuxJpe0wshKp6vkwmKzdqahW1O4s8aSPmv9o xA=; b=C+2UPbpZcBLe4dSOgkrqtUd+e5sQfFvijV9dO+4s+Wk68gj4PParvBBG9 AOp0gI8BucUeOHIz/0G1fsgjBcGB0xg/ZV7Xe6o5AAa+qbl4Q1ZZQdj/M20XX3bD g/PCVoUVbTmtWAxh4spFwb4ZGFGQqlIdbI8wv7jIejnAXINr5M4nCVSgAbkEhANC tJxHHWeT2Bqtl8hRndwpn7rjC09JUdXep/vexdajUB9XuWWX9y9v+bL3dSdP10BB N/Jh3ljQsYKdC7KBnKZ6mI0j/htfkYlelqTXcR6UHLe1PmrQt5MA22oQTt08xe19 XoWLkhE9BXbdAxbDjhDZVNROgKW/g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrfeefgdekvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 36722103CB; Wed, 17 Apr 2019 10:59:54 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: stable@dpdk.org, dev@dpdk.org Date: Wed, 17 Apr 2019 16:59:53 +0200 Message-ID: <5465672.Kypt5CsLy1@xps> In-Reply-To: <20190410205224.69977-2-bruce.richardson@intel.com> References: <20190410205224.69977-1-bruce.richardson@intel.com> <20190410205224.69977-2-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 1/3] devtools/test-meson-builds: skip missing compilers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Apr 2019 14:59:56 -0000 10/04/2019 22:52, Bruce Richardson: > if either gcc or clang are missing, skip doing those builds. > This allows a setup to only do, e.g. gcc tests. > > CC: stable@dpdk.org > Signed-off-by: Bruce Richardson > --- > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > # shared and static linked builds with gcc and clang > for c in gcc clang ; do > - for s in static shared ; do > - export CC="ccache $c" > - build build-$c-$s --default-library=$s > - done > + if command -v $c >/dev/null 2>&1 ; then > + for s in static shared ; do > + export CC="ccache $c" > + build build-$c-$s --default-library=$s > + done > + fi May I suggest this oneline change instead? command -v $c >/dev/null 2>&1 || continue From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 47258A00E6 for ; Wed, 17 Apr 2019 16:59:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 02AFC1B6CC; Wed, 17 Apr 2019 16:59:57 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id C1B901B6CB; Wed, 17 Apr 2019 16:59:55 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 44CC521FFC; Wed, 17 Apr 2019 10:59:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 17 Apr 2019 10:59:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=W+Cv/EuxJpe0wshKp6vkwmKzdqahW1O4s8aSPmv9oxA=; b=Pf78hquvCNa6 ySy1GuFn+n1qqtHUKNwByApd5zhketr6ZG+UrHPnlX49VzKk/6hx8zMtZrBF1YpY vSE0ahwqsbM4h/PEbv4tTosR52gjQvomhPu8pIExn4XOp3IKlmzUQWXKmtDoj7mT LtEpye+tVSpuM7x8JTiGMDLLGp66nGw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=W+Cv/EuxJpe0wshKp6vkwmKzdqahW1O4s8aSPmv9o xA=; b=C+2UPbpZcBLe4dSOgkrqtUd+e5sQfFvijV9dO+4s+Wk68gj4PParvBBG9 AOp0gI8BucUeOHIz/0G1fsgjBcGB0xg/ZV7Xe6o5AAa+qbl4Q1ZZQdj/M20XX3bD g/PCVoUVbTmtWAxh4spFwb4ZGFGQqlIdbI8wv7jIejnAXINr5M4nCVSgAbkEhANC tJxHHWeT2Bqtl8hRndwpn7rjC09JUdXep/vexdajUB9XuWWX9y9v+bL3dSdP10BB N/Jh3ljQsYKdC7KBnKZ6mI0j/htfkYlelqTXcR6UHLe1PmrQt5MA22oQTt08xe19 XoWLkhE9BXbdAxbDjhDZVNROgKW/g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrfeefgdekvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 36722103CB; Wed, 17 Apr 2019 10:59:54 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: stable@dpdk.org, dev@dpdk.org Date: Wed, 17 Apr 2019 16:59:53 +0200 Message-ID: <5465672.Kypt5CsLy1@xps> In-Reply-To: <20190410205224.69977-2-bruce.richardson@intel.com> References: <20190410205224.69977-1-bruce.richardson@intel.com> <20190410205224.69977-2-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 1/3] devtools/test-meson-builds: skip missing compilers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190417145953.45CfNAztlLnxbC2xJzTKho7E1WgGq-5A1tGmkAiH4-s@z> 10/04/2019 22:52, Bruce Richardson: > if either gcc or clang are missing, skip doing those builds. > This allows a setup to only do, e.g. gcc tests. > > CC: stable@dpdk.org > Signed-off-by: Bruce Richardson > --- > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > # shared and static linked builds with gcc and clang > for c in gcc clang ; do > - for s in static shared ; do > - export CC="ccache $c" > - build build-$c-$s --default-library=$s > - done > + if command -v $c >/dev/null 2>&1 ; then > + for s in static shared ; do > + export CC="ccache $c" > + build build-$c-$s --default-library=$s > + done > + fi May I suggest this oneline change instead? command -v $c >/dev/null 2>&1 || continue