Re: [dpdk-dev] [PATCH v6 0/9] virtio 1.0 enabling for virtio pmd driver

[Thomas Monjalon <thomas.monjalon@6wind.com>]

Hi Yuanhan,

I wanted to apply these patches but I see few checkpatch warnings,
inluding a typo.
Sometimes I fix them myself but I guess you would prefer checking it.

### PATCH v6 4_9

CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#571: FILE: drivers/net/virtio/virtio_pci.c:361:
+               left = &ptr[n+1];
                             ^
WARNING:NAKED_SSCANF: unchecked sscanf return value
#582: FILE: drivers/net/virtio/virtio_pci.c:372:
+                       sscanf(ptr, "%04hx-%04hx", &start, &end);

### PATCH v6 5_9

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#79: FILE: drivers/net/virtio/virtio_ethdev.c:937:
+       PMD_INIT_LOG(DEBUG, "guest_features before negotiate = %"PRIx64,

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#85: FILE: drivers/net/virtio/virtio_ethdev.c:942:
+       PMD_INIT_LOG(DEBUG, "host_features before negotiate = %"PRIx64,

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#94: FILE: drivers/net/virtio/virtio_ethdev.c:950:
+       PMD_INIT_LOG(DEBUG, "features after negotiate = %"PRIx64,

### PATCH v6 7_9

WARNING:BAD_SIGN_OFF: 'Tested-by:' is the preferred signature form
#63: 
Tested-By: Santosh Shukla <sshukla@mvista.com>

### PATCH v6 8_9

CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#396: FILE: drivers/net/virtio/virtio_pci.c:620:
+       PMD_INIT_LOG(DEBUG, "\t desc_addr: %"PRIx64, desc_addr);

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#396: FILE: drivers/net/virtio/virtio_pci.c:620:
+       PMD_INIT_LOG(DEBUG, "\t desc_addr: %"PRIx64, desc_addr);

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#397: FILE: drivers/net/virtio/virtio_pci.c:621:
+       PMD_INIT_LOG(DEBUG, "\t aval_addr: %"PRIx64, avail_addr);

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#398: FILE: drivers/net/virtio/virtio_pci.c:622:
+       PMD_INIT_LOG(DEBUG, "\t used_addr: %"PRIx64, used_addr);

WARNING:TYPO_SPELLING: 'lenght' may be misspelled - perhaps 'length'?
#475: FILE: drivers/net/virtio/virtio_pci.c:751:
+               PMD_INIT_LOG(ERR, "offset(%u) + lenght(%u) overflows",

CHECK:CAMELCASE: Avoid CamelCase: <PRIu64>
#482: FILE: drivers/net/virtio/virtio_pci.c:758:
+                       "invalid cap: overflows bar space: %u > %"PRIu64,

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#482: FILE: drivers/net/virtio/virtio_pci.c:758:
+                       "invalid cap: overflows bar space: %u > %"PRIu64,

WARNING:INDENTED_LABEL: labels should not be indented
#550: FILE: drivers/net/virtio/virtio_pci.c:826:
+       next: