From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 713AE93F6 for ; Tue, 2 Feb 2016 11:48:06 +0100 (CET) Received: by mail-wm0-f53.google.com with SMTP id p63so111417565wmp.1 for ; Tue, 02 Feb 2016 02:48:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=5KpoaPSDvhL58wD83fwDkuh4twJuojTajhzBs/q35q8=; b=c4OlKSP1a11JZsbcDyKvW3No7XpHhaw87ZXWl88IlzBGzq0B5UtYt0DuK43dVEVWMQ JwMJHezxXr1gR0BX0TT7OM/kZ7UK6nF0HCUkjGDW7Cx+BdPnsstovhjSHH7EUsKwaJJo inwgOGr/kfDNXzYSPsuOV2mA9MwSWti+dfHNeeHNK/a7Ad3nGRZKpbNL1ch0EhVdzPRr uYnjKDI5dY799wC5jKcOQyHQdKUtEjZ2J+G1872bVG9LyCJWiXE1bPZTRHxSXHEg6UV9 r4xBDR/bFzfy44wiNFnQvbDsx+ko74nGFKiKlBn9zxH7IxfK0v0GJemmbF18XABKX3MU RKfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=5KpoaPSDvhL58wD83fwDkuh4twJuojTajhzBs/q35q8=; b=UKlwZfwyBSszJ2Lph2rv5t/zJDoqb/HEJsyTsY9T11Wlx9v3K2QmFk5swCOsERKe2H bQTT2X0EXWkPuh5oRwaqXurDHfv25qEZeKRBzwmsvCplhAThVEYoRzxIraIbEFgw6Z8Y i86XkF9PYWxYrmyjQAgRBp06DAohzEAHEY/tPzEOe+8Xtu8K4oueQHXvrwsFqEui+5vP aUTgIy1QGgcpr6qCuq+l5RxF6HPWy6PXcGWq8Jakok6U9+BAS5ZtSeV+vWCqlWdaV3yk 6Wum30Ui3KJn3igOe8SaZGda5iYjL0rNLT+lo6zua/cSjJzntsJ1J61vNnURBhzOQ10S uzSw== X-Gm-Message-State: AG10YOTT5OJbIhsScTC5oPTlKD7nn4HV8kXU6tvQ1GU8Qd/63hkRDzCT8psXT4129w+h8AKz X-Received: by 10.28.72.197 with SMTP id v188mr11721884wma.34.1454410086205; Tue, 02 Feb 2016 02:48:06 -0800 (PST) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id i12sm2282878wmf.10.2016.02.02.02.48.04 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 02 Feb 2016 02:48:05 -0800 (PST) From: Thomas Monjalon To: Yuanhan Liu Date: Tue, 02 Feb 2016 11:46:54 +0100 Message-ID: <5469935.ICjYsKyfSi@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1453967697-3757-1-git-send-email-yuanhan.liu@linux.intel.com> References: <1453191125-26335-1-git-send-email-yuanhan.liu@linux.intel.com> <1453967697-3757-1-git-send-email-yuanhan.liu@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 0/9] virtio 1.0 enabling for virtio pmd driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Feb 2016 10:48:06 -0000 Hi Yuanhan, I wanted to apply these patches but I see few checkpatch warnings, inluding a typo. Sometimes I fix them myself but I guess you would prefer checking it. ### PATCH v6 4_9 CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #571: FILE: drivers/net/virtio/virtio_pci.c:361: + left = &ptr[n+1]; ^ WARNING:NAKED_SSCANF: unchecked sscanf return value #582: FILE: drivers/net/virtio/virtio_pci.c:372: + sscanf(ptr, "%04hx-%04hx", &start, &end); ### PATCH v6 5_9 CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #79: FILE: drivers/net/virtio/virtio_ethdev.c:937: + PMD_INIT_LOG(DEBUG, "guest_features before negotiate = %"PRIx64, CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #85: FILE: drivers/net/virtio/virtio_ethdev.c:942: + PMD_INIT_LOG(DEBUG, "host_features before negotiate = %"PRIx64, CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #94: FILE: drivers/net/virtio/virtio_ethdev.c:950: + PMD_INIT_LOG(DEBUG, "features after negotiate = %"PRIx64, ### PATCH v6 7_9 WARNING:BAD_SIGN_OFF: 'Tested-by:' is the preferred signature form #63: Tested-By: Santosh Shukla ### PATCH v6 8_9 CHECK:CAMELCASE: Avoid CamelCase: #396: FILE: drivers/net/virtio/virtio_pci.c:620: + PMD_INIT_LOG(DEBUG, "\t desc_addr: %"PRIx64, desc_addr); CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #396: FILE: drivers/net/virtio/virtio_pci.c:620: + PMD_INIT_LOG(DEBUG, "\t desc_addr: %"PRIx64, desc_addr); CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #397: FILE: drivers/net/virtio/virtio_pci.c:621: + PMD_INIT_LOG(DEBUG, "\t aval_addr: %"PRIx64, avail_addr); CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #398: FILE: drivers/net/virtio/virtio_pci.c:622: + PMD_INIT_LOG(DEBUG, "\t used_addr: %"PRIx64, used_addr); WARNING:TYPO_SPELLING: 'lenght' may be misspelled - perhaps 'length'? #475: FILE: drivers/net/virtio/virtio_pci.c:751: + PMD_INIT_LOG(ERR, "offset(%u) + lenght(%u) overflows", CHECK:CAMELCASE: Avoid CamelCase: #482: FILE: drivers/net/virtio/virtio_pci.c:758: + "invalid cap: overflows bar space: %u > %"PRIu64, CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #482: FILE: drivers/net/virtio/virtio_pci.c:758: + "invalid cap: overflows bar space: %u > %"PRIu64, WARNING:INDENTED_LABEL: labels should not be indented #550: FILE: drivers/net/virtio/virtio_pci.c:826: + next: