From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09C56A034E; Tue, 19 Nov 2019 16:48:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D7A08A69; Tue, 19 Nov 2019 16:48:52 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 773C29E4 for ; Tue, 19 Nov 2019 16:48:51 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Nov 2019 07:48:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,324,1569308400"; d="scan'208";a="196535456" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.251.95.85]) ([10.251.95.85]) by orsmga007.jf.intel.com with ESMTP; 19 Nov 2019 07:48:48 -0800 To: Thomas Monjalon , Marcin Baran Cc: dev@dpdk.org, Bruce Richardson , john.mcnamara@intel.com, ray.kinsella@intel.com, david.marchand@redhat.com, Pawel Modrak References: <24aae2ed616a13f9597cc6059f0288ddd91bf359.1573230233.git.anatoly.burakov@intel.com> <2160256.76SxUoF7Yy@xps> From: "Burakov, Anatoly" Message-ID: <5471ce24-41d5-6eec-9ca1-0c157b760eb8@intel.com> Date: Tue, 19 Nov 2019 15:48:47 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <2160256.76SxUoF7Yy@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v7 01/10] config: change ABI versioning to global X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 19-Nov-19 1:53 PM, Thomas Monjalon wrote: > 08/11/2019 17:25, Anatoly Burakov: >> From: Marcin Baran >> >> As per new ABI policy, all of the libraries are now versioned using >> one global ABI version. Changes in this patch implement the >> necessary steps to enable that. > > For the history, would be nice to describe the "why" of each change here. Here and other review comments: I never really touched this script because my meson-foo and ABI-foo is non-existent. I would really appreciate some help here on what the changes are supposed to do (esp. with regards to ABI versioning mechanics), because i understand very little of what this patch does. > Please do not be lazy :) Says the guy who waited until last moment to review it! -- Thanks, Anatoly