From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 165C6431EF; Tue, 24 Oct 2023 12:22:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 06C10410DD; Tue, 24 Oct 2023 12:22:45 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mails.dpdk.org (Postfix) with ESMTP id BF33E402BE; Tue, 24 Oct 2023 12:22:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698142963; x=1729678963; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=gi1YTdhckYKtr8UlZOGlOXUiwsG587ykal1EirowMpM=; b=bKTf+fjP7wchkPtMyn+zkLHaXjV2q106IzmBGErMz4Q5fnugiQQT92yQ 1XAXMn2NyZ6uSvqZ6NuRwI7dYoFHkC3GukYPZksNUP+cjkKK7uzlnWU6U /DHFqlkig3HLAsFQ40EDjwcYoOaVtEhg7+LcixjEL4CW+ljxYBWEvsHue F8QkQr4BqnkNhTznLj3g2ZAgh0KwIdmyllajf/TOr4cHlrIGGdfMNZZZY f6cCX8PnG+5KqGh4fO0Hqbx480TbeRJrvawfa7yodopsCd8Y7JlRTUO6x qwAddHSCV/2bT7wrpVqxsUzkEkZ+wKJ6xkCMJH94ZarSYjxNDhWlM95v+ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10872"; a="5651923" X-IronPort-AV: E=Sophos;i="6.03,247,1694761200"; d="scan'208";a="5651923" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2023 03:22:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10872"; a="828778113" X-IronPort-AV: E=Sophos;i="6.03,247,1694761200"; d="scan'208";a="828778113" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 24 Oct 2023 03:22:41 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 24 Oct 2023 03:22:40 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Tue, 24 Oct 2023 03:22:40 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Tue, 24 Oct 2023 03:22:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Io6mUfZoSZgWNfbLN96jSteD5v11dkfos9iMWKRBmKRDZTfkxiP4AA1xrWOIIVAF+nV6FKU/qt2FO073PtQyU9ayhuJnmWLtLTcEBseInQvSTBUpBj2XeM2+eTbhPQq58PkM9jCVvS2WoHuIja7YLq+mQeEjUaOehhqpecAnEaLrbetM6BzujT53wqwOyh2dACB8KhG5bGxa3U0ViHmvCnYzo4JmQCKR3RSuXSmsoBPsrxFvUdQDIoP1yVWJFfDr22JheBIf9fX7Wnrc4KHHP3TX8zgJJRj7vbuEB/CzPEvpGwCJ50gkuHrXsNIAMI4WqeCl4arWTgoiXEawQkQZRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BepAUmDVrdCHXgbkI4rrYJDliZf5OU4JK6J40UkllIQ=; b=PXF8kTC5O9vOEarh3WOHA8gF5qoo03FMsruX2ICQdZoOYgVD86Y4Qjwi8b3EmaHLmtGIabejZagm4DLoKAS12hieC8L81pndLiXQQ6+APhC7NOxb27/B9EVWdH0bW9IyHoj/gGcwAf10m9YdVGfDwJr8w5eV4qWd5ZcqNC8Gj7MEcKoWgWQlO8jEPF5Jww5j2sZoILNsZpITIGdEmzW2xsJCTQjcB2h4nRhY0R7gD6Toz5UN0Yn65dOJhuwxkKDtquntbEOW/W6WuIh+MFyIJA8QLgWR8jYAAZ8J2Ng35JEDqjLXgoruYAwBq1jhgdBaFmaATr4QXeyZWpq2G+q9kQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM8PR11MB5653.namprd11.prod.outlook.com (2603:10b6:8:25::8) by PH7PR11MB7498.namprd11.prod.outlook.com (2603:10b6:510:276::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.26; Tue, 24 Oct 2023 10:22:37 +0000 Received: from DM8PR11MB5653.namprd11.prod.outlook.com ([fe80::9818:3765:1b10:1c5a]) by DM8PR11MB5653.namprd11.prod.outlook.com ([fe80::9818:3765:1b10:1c5a%7]) with mapi id 15.20.6907.032; Tue, 24 Oct 2023 10:22:37 +0000 Message-ID: <54859de7-c108-8389-43bc-9602a9897afc@intel.com> Date: Tue, 24 Oct 2023 11:22:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] net/iavf: fix IAVF_TX_OFFLOAD_MASK definition To: David Marchand CC: Jingjing Wu , Beilei Xing , , References: <20231024091328.11933-1-radu.nicolau@intel.com> Content-Language: en-US From: Radu Nicolau In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU2PR04CA0295.eurprd04.prod.outlook.com (2603:10a6:10:28c::30) To DM8PR11MB5653.namprd11.prod.outlook.com (2603:10b6:8:25::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM8PR11MB5653:EE_|PH7PR11MB7498:EE_ X-MS-Office365-Filtering-Correlation-Id: 951deffc-28c1-45eb-0fa6-08dbd47b24f3 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dclxspQVptlsJfzx9/kDMA/TGuJ/qcF/MifoCIkJwa4ZAdKDj9G8GAMjevIZizTwrMZen1SkTkzUaSTVr5952Qi6cKWhNGWsG2xCvN1qYSuMUEma8vd64673BY6FmQkSrtaB+kRWei7uAd2xZNmz9y0H2HyUhSZK7PaFLe47Mryv1cadSieZg8ePFQglFQSWUBrpDwnZsZcw3+fgfyQxTVE+ytv1h0ibtYnlQaoIUWIF847A2cdyT6HgmkV8sMn0iZYGFa7bfFkb6pZhHP6sgtYEcht9zR2rSYnOgGmh/a8MY4iLi2h/T23jjvPfkIn9J8B7u7lAg6bOCHSxEO8Yu6iHprvSkk0UtzfQvAyka7THs72zjeQTcoNnemBeL9b1U0a8FkT9BCZwtYR6G5SroSfvxYhz/xh476/GMjnUHHRCSxOrKqInP2/dkGuIrbNUbEuWSZIGzKjF6rROAXxVZIte0vdk0yNpbCN5C+ZkEj9VWqFKmkRM5kls3E+cvr4lEFZINKehTx9kjamaGcKDdm8mu+FBrFFqndiUBZTIWERIFYTGP77lnZa6vKoek2h5Y1gHb0bcXUvRXuDh3OkpH8tFyp+RlMQhj22jQs0ac4xRwE4e1+5GERTDcQ2gu3hsLDikIId/NGtAiNBcPUklnw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5653.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(136003)(376002)(366004)(39860400002)(346002)(230922051799003)(64100799003)(186009)(1800799009)(451199024)(31686004)(6506007)(31696002)(2906002)(38100700002)(41300700001)(86362001)(36756003)(26005)(4326008)(82960400001)(2616005)(83380400001)(8676002)(53546011)(55236004)(6512007)(66556008)(44832011)(4744005)(6486002)(8936002)(5660300002)(316002)(6916009)(6666004)(478600001)(66946007)(66476007)(54906003)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NWZCVElyMDlxL1BjZnRHY01ZR0NaYWsvd2w4amlYTC9VNytOU0F4QXlpa0ly?= =?utf-8?B?Z0tabGZyWXRMZnhVaU9oR3czb3FBa2s3RDd3cml3b2dZV3lIeGROcGJWTlda?= =?utf-8?B?SkFVcjRIQXA3RmFLN1d1dFdtOGVOZ1hsQ2RmbmNxa0ZLa3Zob3p1c3NhQ0xz?= =?utf-8?B?UDFVZ1NrYS9UZDd6NnE2eGVqczlSQWFwV2JJTUI1eVpYSmxYQTZWcTFMdkt1?= =?utf-8?B?eXBSaWc1WUQ5Yjg0ZkswTWc4V2V5WFNlb0RzcEhCTVVDZ1MreXM5eGJNT1Na?= =?utf-8?B?emFCMGNYRElrNFVhVlBvc3VmOS82M0ZvVlF1YjNjT1dJdG9WT0ltL2d2b2F3?= =?utf-8?B?Z0tKU0tuZVUxSkVHR3hFZWZjZFBYZGlIMzBuZ2xXMGhIbWhwbytLNnkrUEJM?= =?utf-8?B?YXNxRS8rMUcyaVAxVzlpSTRUZjJOdFYrd0lNbWJMb0hvNUFseGJlSkM5dG5t?= =?utf-8?B?TUwvUUpjV3p0NlloRTRwTmhtSXlFd0dXOU9PMG5iS0xHMHJxYTNhbnNEakRT?= =?utf-8?B?bEg1ZXZITytHeS8xYnlVM3drNkgweVpsRktuRUtXM3pzMWpBTENuaTkvYUtU?= =?utf-8?B?c2t4QXZScDV5ejNqamNZT2ppZnJEbm1pWWF4aFJ4N211KzFtZDg1UTlTczRp?= =?utf-8?B?LzQ1YTltMDBtaWhuSUZUa05WV2JhdjMvSWlISVovMjRBQkwwRTV0aEI5emFn?= =?utf-8?B?aFhxNzJzYzB0TERmenJGV0ZRR1gwbjJhY1JGemlUaUpXZFNRMndrd3BiMSs3?= =?utf-8?B?THYrM0RDRjlJWmJQTlNYMXpKRzhEVHphYXFMcmdXaVRSTTh6Z1hmbE1xZVpQ?= =?utf-8?B?TnVOZFV2UC9RQ2d3aGZQVHhEY0crSzVwMGFOaFFqY1p5b0hkRmdJM0sySWds?= =?utf-8?B?WWM3K1lSZ1ZYTy9UMXNCdWdEUUlNNDNaaExWeTdENmY3VTVRUXV2aGhoWGNj?= =?utf-8?B?VlJoSkJocGpBRVdTMjVueDI4aHhDTjVRSTBZM3dUNUtIdmJJOGFhMmgxQk1G?= =?utf-8?B?dURTWnYvT1RPYnlpSHJQTjM5QmoxMGFXVWJEZUxiV2M0MkpUUDFWS0wyNzRz?= =?utf-8?B?SU42ZHAxVmNKWDV1S0M2UWVNNFJ0eGliYTRVbDhwc2g2WHpmSnRNNEtCRzJw?= =?utf-8?B?MVhUTDJKUU9lZHNZV3p3Q2pMQVJlVlA3c3F6WmxrTXFSUDM3VU1oUEtQSldz?= =?utf-8?B?SSttOGk3SnM5dmorUE9WbTlQWVBuYlQvamxUYXZLWjdnMXpzQlhCdGRPQmdU?= =?utf-8?B?SVEvNlEwcXhGeHZmK3Y2NDY5SUFNNHI2aDNrTEllYVJFdUNvMkVBVTJQMUxP?= =?utf-8?B?VHorNi9hR2ZTU0J0V0tnSVdvYXNlSzZzWE5MYXBkMzc5RzYybGZkcnNWblF3?= =?utf-8?B?TnZoNGQ4NzI3ellPNDNwWVFBZEwyTkVONjRpa3NVd0YzaTFIZ2ZvcWtwNFp2?= =?utf-8?B?N1ExemRWWnhkcmg2S2JuN0NlOUVyNnpUdWVEaUg5UERPdWJSVEFGOGV6NmVx?= =?utf-8?B?ZkN4Y3k0Z0dIRXhSUFZreFBERjFZV0RJN0twaWI5RUVRZ0dFTWg0VEdSMldp?= =?utf-8?B?bTczQ0xjY1lpUlNYRlBYdHZKNFg2cGVidWVzRVI2S1RqQzA0d0VzbUpBcG9E?= =?utf-8?B?dnlTNVpHYzVibGRWeGo5c3BQMmc3VDNOc2RvWmFmanV2OFFEM0NCV3MzaStm?= =?utf-8?B?ZmJlMlIzMCtHK0FneWs5YXJWb3J5c3VMeVpNY3dYWlprNkFkUTkyZ3VTckxW?= =?utf-8?B?alBkTFlHaWpwN1hCR0FvazlqdmUyZ1ludVFsNmVnQVVnMjVMY3J2L2lEZUFh?= =?utf-8?B?Y3BYaHhXYytHbDVZdzBJZHhrUTR1Mkw4MlZpcXZFN0hOVVAxYWlDSWF0WGZh?= =?utf-8?B?SjVCT0k4TWRKVmVIQkdBWEFpZFpEMW5mUWFKV05IeTkrMUNiV2tmQ09sVmFB?= =?utf-8?B?RCtMMk9Qd0p0ZDB3OGdNVDRIMzhueDhaR3czek9zVDFLZlAwNnRYQXRnK3Va?= =?utf-8?B?TXBBSUtoWTNtQzY0dmpqMUFtR3cvRFFYZ2dkM2hGakJTY1pYcHgwWmdBVUVS?= =?utf-8?B?b3dOcy90NDN6VGk0SklWQmxXWlcxamwvcksyUkNDS2lXTjFVL0ZSLy84YnBt?= =?utf-8?B?V3pkM2RjNlhGb0d1cDFuUGd3SUxZMCtrVit5ZlROamlqZlhrSEdRc2tBa1ly?= =?utf-8?B?SVE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 951deffc-28c1-45eb-0fa6-08dbd47b24f3 X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5653.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2023 10:22:37.1604 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZBQrmvJn63EK0SXrwjwSxCrBkhvmvfhoutH6yOlCiekcznzHIgB8PFpBcsdPXg8OkuV8hRV4H85IrLKx9Iz3bA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7498 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 24-Oct-23 10:49 AM, David Marchand wrote: > On Tue, Oct 24, 2023 at 11:13 AM Radu Nicolau wrote: >> IAVF_TX_OFFLOAD_MASK definition contained >> RTE_ETH_TX_OFFLOAD_SECURITY instead of >> RTE_MBUF_F_TX_SEC_OFFLOAD. >> >> Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto") >> Cc: stable@dpdk.org >> >> Signed-off-by: Radu Nicolau > Something is not clear to me. > How was the IPsec inline crypto feature supposed to work with this > driver so far? > > Any packet with the RTE_MBUF_F_TX_SEC_OFFLOAD flag should have been > refused in iavf_prep_pkts. > It worked because the IPsec sample app doesn't call rte_eth_tx_prepare, and from what I can see no other sample app does.