From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 3C74C2B98 for ; Wed, 24 Feb 2016 12:47:16 +0100 (CET) Received: by mail-wm0-f43.google.com with SMTP id a4so25853737wme.1 for ; Wed, 24 Feb 2016 03:47:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=qDie3mlGoMnmgx3rIap2ruPUvgQFGi5pDwMmKwwQ8j0=; b=x36HINck8mjudgcQVQ8bMJNQsaNLY/AtLozUMSBlp8C+Mvs6zd+V8X43X0O1T2subf d2wWEJpkpviFeXBU+JE/ZTAe4PBrteaI1Rluh72u2Tt1K0KiE+BDAzDroi7Zp22Pr6ke GT6BhK0X4sVgCIhyQIuR7J7Qp8QytUbyUAaWxd+qQPy3fdQn2vM9682pXdBxX7wwb691 Zsgw9Z13QGjTWoh/MsOtbPDSfsZbQ6piBkrY5m3stTWu9j5SOt46zrhwPPypKUjq0wBK V8IwiO4mweCcjp0XrKphlMuXUP/QTdbKVXARI+f1gEE4qBYc64HVYCasvy49C9udPTQ5 5x6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=qDie3mlGoMnmgx3rIap2ruPUvgQFGi5pDwMmKwwQ8j0=; b=OiE0bCnV4Et7fLP5A9NSuX9JnBim6z4yOj+7yvawsdnhLuNhPY68QuEK3T/JlKrujr CQhG0LkTfkiGh9UQtDgGoie086kZDViLLpVkETIXOoZdmzKFgENgcGg+M6K8VotiYJOO XUFDrfPpOjlOxqWmWoweVyFQ/jjEumUaMG5uQfZF2bvJPXhNhrLqzef//v/2RHR6fqFz oMMf0ESdSlhJLjUe5McMoPLCswN052hri8i79UvNwbFAz8wsz4ybL903b5ZBmk/W140a nR6E+ihBW1Sw9E9PB3+b0PCsl5VafOCnKrePn6np+e1l/uofK0/1UhIwv542/0OK2Wgq 2znA== X-Gm-Message-State: AG10YOQyeBfqqpdC7ZadoLp4MeRa1Ppler+dw0m27v8/Z3OOEJAwac/Onxvq8aFnnK7swBeb X-Received: by 10.28.9.71 with SMTP id 68mr23187399wmj.33.1456314435986; Wed, 24 Feb 2016 03:47:15 -0800 (PST) Received: from xps13.localnet (171.36.101.84.rev.sfr.net. [84.101.36.171]) by smtp.gmail.com with ESMTPSA id j18sm31061762wmd.2.2016.02.24.03.47.14 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 24 Feb 2016 03:47:15 -0800 (PST) From: Thomas Monjalon To: "Ananyev, Konstantin" Date: Wed, 24 Feb 2016 12:45:40 +0100 Message-ID: <5486342.uyFgSA1Ajk@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <2601191342CEEE43887BDE71AB97725836B0AB6C@irsmsx105.ger.corp.intel.com> References: <1520606.5uKYNpmzaU@xps13> <2601191342CEEE43887BDE71AB97725836B0AB6C@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, "Kantecki, Tomasz" Subject: Re: [dpdk-dev] [PATCH] eal: Initial implementation of PQoS EAL extension X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Feb 2016 11:47:16 -0000 2016-02-24 11:21, Ananyev, Konstantin: > > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Wednesday, February 24, 2016 10:35 AM > > To: Ananyev, Konstantin > > Cc: Richardson, Bruce; dev@dpdk.org; Kantecki, Tomasz > > Subject: Re: [dpdk-dev] [PATCH] eal: Initial implementation of PQoS EAL extension > > > > 2016-02-24 10:22, Ananyev, Konstantin: > > > > > > > -----Original Message----- > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > > > > Sent: Wednesday, February 24, 2016 10:10 AM > > > > To: Thomas Monjalon > > > > Cc: dev@dpdk.org; Kantecki, Tomasz > > > > Subject: Re: [dpdk-dev] [PATCH] eal: Initial implementation of PQoS EAL extension > > > > > > > > On Wed, Feb 24, 2016 at 09:24:33AM +0100, Thomas Monjalon wrote: > > > > > 2016-02-23 23:03, Kantecki, Tomasz: > > > > > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > > > > > If there is nothing specific in DPDK for PQos, why writing an example in > > > > > > > DPDK? > > > > > > The example makes it much easier to use the technology with DPDK. > > > > > > > > > > > > > Maybe the example should be better in the library itself. > > > > > > The library in question (https://github.com/01org/intel-cmt-cat) has a couple of examples but none of them refers to DPDK. > > > > > > > > > > > > > I suggest to mention the library in > > > > > > > doc/guides/linux_gsg/nic_perf_intel_platform.rst > > > > > > Ok it can be added to this document. Does it imply -1 for the sample code idea? > > > > > > > > > > I may be wrong but I have the feeling the example is more about PQoS than DPDK. > > > > > So yes, I would vote -1. > > > > > > > > > Well, the intersection of DPDK and PQoS is what the example is really all about, > > > > and as such it is relevant to both DPDK and the library itself. Platform QoS > > > > can be of great use to packet processing applications for helping to ensure that > > > > the app gets the resources it needed - especially in a virtualised world - and > > > > so we believe that having an example in DPDK showing how to use PQoS with DPDK > > > > is well worthwhile having. It's more effective than a simple doc update in > > > > raising awareness of the existence of the feature, and also provides for DPDK > > > > users a readily available app for the user to start playing with to evaluate > > > > PQoS for their own use-cases. > > > > > > +1 > > > I also think it is a good thing to have. > > > Again user don't have to trust the whitepapers - instead he can run the app > > > and measure performance gain on his particular platform. > > > > I totally agree the example is good to have. > > Konstantin, are you thinking it must be hosted in the PQoS lib repository? > > Personally I prefer it to be part of dpdk samples. > DPDK IO code path is a bit different from what the 'classical' user app usually does - > a lot of polling, avoid system calls, etc. > Also it would probably have much better visibility here. > Again, as Bruce already mentioned, we have QAT & TAP samples, why we can't have PQoS too. Indeed the DPDK policies are really flexible. How would you suggest to decide which examples can enter in DPDK? Examples: what about a zip compression in the forwarding plane? What about a VM2VM failover synchronization?