From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f43.google.com (mail-pa0-f43.google.com [209.85.220.43]) by dpdk.org (Postfix) with ESMTP id 14F30959 for ; Mon, 15 Dec 2014 06:26:16 +0100 (CET) Received: by mail-pa0-f43.google.com with SMTP id kx10so11147576pab.2 for ; Sun, 14 Dec 2014 21:26:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=moEc5qa5b9YO6CCn2aM4Vqo6PMDuHvCa8eLhOjAuM1g=; b=ULBT/dyNl5eI9pESPJQcWpOX7HYgek46Wpyg/FIGIEtlt14k2YkXzKbD82uynRnCr8 IRnXElNNbK9lpS8JfvFgzEbX+zxHziGWcbf47walWW/rXh64GRj31EEJS8RwE7PX9zP0 MXQ0K1JSgQMHkAnJpbs3/5/DmaAihAONpchuk4qWz44jou+9vZBmJvppjEgRfNKzcJqx uAsZJpPkECwMiRE2tY9LBg3YHDqWbJbtea2/poCD95KKut0K8vmyinfGRFoMJAk5+tBi 6CVNSylcH9H7OdKR+jEAEhnClp593Jh4NtKC58xyeCWvphu/8atFnMyzVEl4Jw4XFyxW x6WQ== X-Gm-Message-State: ALoCoQmpza1LgtWGxbypv4/OlUxxdV3b4slUufHRQmgS8VlIwHhKx5gPqP5raLOtU8IcLJVyCfrj X-Received: by 10.68.131.3 with SMTP id oi3mr29462211pbb.27.1418621175264; Sun, 14 Dec 2014 21:26:15 -0800 (PST) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by mx.google.com with ESMTPSA id u4sm7917455pbs.60.2014.12.14.21.26.13 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 14 Dec 2014 21:26:14 -0800 (PST) Message-ID: <548E70F6.30807@igel.co.jp> Date: Mon, 15 Dec 2014 14:26:14 +0900 From: Tetsuya Mukawa User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Huawei Xie , dev@dpdk.org References: <1418247477-13920-1-git-send-email-huawei.xie@intel.com> In-Reply-To: <1418247477-13920-1-git-send-email-huawei.xie@intel.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Cc: haifeng.lin@intel.com Subject: Re: [dpdk-dev] [PATCH RFC v2 00/12] lib/librte_vhost: vhost-user support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Dec 2014 05:26:16 -0000 Hi Xie, I've got warnings from checkpatch.pl. Mostly 'over 80 characters' warnings. (But I know these are come from original vhost-example code sometimes.) So far, your patches are RFC, so I haven't check these strictly. Thanks, Tetsuya (2014/12/11 6:37), Huawei Xie wrote: > This patchset refines vhost library to support both vhost-cuse and vhost-user. > > > Huawei Xie (12): > create vhost_cuse directory and move vhost-net-cdev.c to vhost_cuse directory > rename vhost-net-cdev.h as vhost-net.h > move eventfd_copy logic out from virtio-net.c to vhost-net-cdev.c > exact copy of host_memory_map from virtio-net.c to new file > virtio-net-cdev.c > host_memory_map refine: map partial memory of target process into current process > cuse_set_memory_table is the VHOST_SET_MEMORY_TABLE message handler for cuse > fd management for vhost user > vhost-user support > minor fix > vhost-user memory region map/unmap > kick/callfd fix > cleanup when vhost user connection is closed > > lib/librte_vhost/Makefile | 5 +- > lib/librte_vhost/rte_virtio_net.h | 2 + > lib/librte_vhost/vhost-net-cdev.c | 389 ---------------------- > lib/librte_vhost/vhost-net-cdev.h | 113 ------- > lib/librte_vhost/vhost-net.h | 117 +++++++ > lib/librte_vhost/vhost_cuse/vhost-net-cdev.c | 452 ++++++++++++++++++++++++++ > lib/librte_vhost/vhost_cuse/virtio-net-cdev.c | 349 ++++++++++++++++++++ > lib/librte_vhost/vhost_cuse/virtio-net-cdev.h | 45 +++ > lib/librte_vhost/vhost_rxtx.c | 2 +- > lib/librte_vhost/vhost_user/fd_man.c | 205 ++++++++++++ > lib/librte_vhost/vhost_user/fd_man.h | 64 ++++ > lib/librte_vhost/vhost_user/vhost-net-user.c | 423 ++++++++++++++++++++++++ > lib/librte_vhost/vhost_user/vhost-net-user.h | 107 ++++++ > lib/librte_vhost/vhost_user/virtio-net-user.c | 313 ++++++++++++++++++ > lib/librte_vhost/vhost_user/virtio-net-user.h | 49 +++ > lib/librte_vhost/virtio-net.c | 394 ++-------------------- > lib/librte_vhost/virtio-net.h | 43 +++ > 17 files changed, 2199 insertions(+), 873 deletions(-) > delete mode 100644 lib/librte_vhost/vhost-net-cdev.c > delete mode 100644 lib/librte_vhost/vhost-net-cdev.h > create mode 100644 lib/librte_vhost/vhost-net.h > create mode 100644 lib/librte_vhost/vhost_cuse/vhost-net-cdev.c > create mode 100644 lib/librte_vhost/vhost_cuse/virtio-net-cdev.c > create mode 100644 lib/librte_vhost/vhost_cuse/virtio-net-cdev.h > create mode 100644 lib/librte_vhost/vhost_user/fd_man.c > create mode 100644 lib/librte_vhost/vhost_user/fd_man.h > create mode 100644 lib/librte_vhost/vhost_user/vhost-net-user.c > create mode 100644 lib/librte_vhost/vhost_user/vhost-net-user.h > create mode 100644 lib/librte_vhost/vhost_user/virtio-net-user.c > create mode 100644 lib/librte_vhost/vhost_user/virtio-net-user.h > create mode 100644 lib/librte_vhost/virtio-net.h >