From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 17DC33F9 for ; Wed, 17 Dec 2014 04:29:14 +0100 (CET) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sBH3TB68015853 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 16 Dec 2014 22:29:11 -0500 Received: from dhcp-66-71-51.eng.nay.redhat.com (dhcp-66-71-51.eng.nay.redhat.com [10.66.71.51] (may be forged)) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sBH3T8ts012318; Tue, 16 Dec 2014 22:29:09 -0500 Message-ID: <5490F801.3020807@redhat.com> Date: Wed, 17 Dec 2014 11:26:57 +0800 From: Jincheng Miao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Thomas Monjalon References: <1418275627-17145-1-git-send-email-jmiao@redhat.com> <4943955.d3ixVqDNjM@xps13> In-Reply-To: <4943955.d3ixVqDNjM@xps13> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] kni: fix build on RHEL6.5 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Dec 2014 03:29:15 -0000 On 12/16/2014 11:21 PM, Thomas Monjalon wrote: > 2014-12-11 13:27, Jincheng Miao: >> RHEL6.5 kernel is based on 2.6.32. But there are two changing >> from 2.6.35: >> 1. socket struct is changed >> It wrappered previous wait_queue_head_t of socket to >> struct socket_wq. So for the kernel older than 2.6.35, we should >> directly use socket->wait instead. >> >> 2. new function sk_sleep() >> This function is implemented from 2.6.35 to obtain wait queue >> from struct sock. This patch adds a macro in kni/compat.h >> to be compatible with older kernels. > I don't understand the relation between RHEL-6.5 and the kernel 2.6.35. > The patch seems not related to RHEL at all. > Please start your explanations by describing what is the problem > you want to solve. Hi Thomas, This patch is working for resolving the problem I found on RHEL6.5: http://dpdk.org/ml/archives/dev/2014-December/009827.html Because the root cause is socket struct change from 2.6.35, so this patch also fits for all kernels older than 2.6.35. Sorry for the ambiguous description, I think the title should be: "kni: more compatibility for kernel older than 2.6.35" Regards, Jincheng Miao > > Thanks