From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 258BF559A for ; Tue, 25 Apr 2017 18:22:19 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B44BF209E6; Tue, 25 Apr 2017 12:22:18 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 25 Apr 2017 12:22:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=m2M4ya5/CVVgOU4 cRKD1tanA2KmbaoGL2hJOV3ohh/E=; b=aU88EM6oY3iCFuhA9B2ktkonMvxAvUd h7thwDT+YuCqYjbldpxcimDc7zoeRwtqlYdTtGiGcFl+xtkSIRduLETMEfz10LOr ebQ6xcsISwViCQPh/Ad9J6/2HMqrR4KwYjHF4lvs28FG58xkYdLswxyjUPptXvZv TXVEdVUl4JQ8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=m2M4ya5/CVVgOU4cRKD1tanA2KmbaoGL2hJOV3ohh/E=; b=miq83bPs Hagyah7FZ4H4zzsZtGGpFnH+YP0dSImhWZaFIjIcKe79RfpiRKtUdhJPpD/+zjRD TuaZ7K7hwU/WXiy/U7TIXiSbZMlFbjtlV3zBaFwqPRvXq9Sp8FyvLXugfYqGBK4c Min3TOYVMmUkRnLnJNG/WGD3gqNWp/EvIrjVzqO7EtBcRvkwmIQoptb7s2eyfBeC Y3lmzmDvJKGn7TH8ux+CyAvFMurhOgR9BzFOVEScSZr90SlHP0J3Uw8l+6vadYNr JfDYRYJpCX6F6+Os2YL5LgTlfQuallFpgKw4jkX/2jZYiIKpAZl1R2RvhSv03iEo Q+mGz7sAGtnGTQ== X-ME-Sender: X-Sasl-enc: j9sFypbrNUT5NjXKi/WlgFo4uul1awkMD1BXD9iCPujU 1493137338 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4271224774; Tue, 25 Apr 2017 12:22:18 -0400 (EDT) From: Thomas Monjalon To: "Wu, Jingjing" Cc: dev@dpdk.org, Oleg Kuporosov , olivier.matz@6wind.com Date: Tue, 25 Apr 2017 18:22:17 +0200 Message-ID: <5493210.cW0TSkhqM8@xps> In-Reply-To: <9BB6961774997848B5B42BEC655768F810D4D536@SHSMSX103.ccr.corp.intel.com> References: <1476369308-17021-1-git-send-email-olegk@mellanox.com> <1476369308-17021-3-git-send-email-olegk@mellanox.com> <9BB6961774997848B5B42BEC655768F810D4D536@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/3] app/testpmd: enabled control for packet timestamps X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Apr 2017 16:22:19 -0000 Hi, 25/04/2017 16:02, Wu, Jingjing: > From: Oleg Kuporosov > > Implemented two methods of control > > > > - by --enable-timestamps CL testpmd application we can enable timestamping > > for all ports; > > - in interactive mode port config timestamps on|off is able to > > configure timestamping per specific port. > > > > The control doesn't interact with IEEE1588 PTP implementation there as it is > > under macro compilation but can be extended in the future. > > > > This feature is required for debugging/testing purposes for real time HW packet > > timestamping. > > We have ieee1588fwd.c to demo the timesync enable/disable, can we reuse > The fwd engine instead of defining new commands? Yes for IEEE1588 feature, we should use app/test-pmd/ieee1588fwd.c. There is more to say about this feature. The main goal of this patchset was to add a timestamp in the mbuf. It has been done by another patchset in 17.05. Do we know how to test this timestamp in testpmd? About IEEE1588 feature, why is there a config option? CONFIG_RTE_LIBRTE_IEEE1588 A feature should never be disabled at compile time. There is also a runtime enablement with rte_eth_timesync_enable(). I think we need some discussions here. Thanks