From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <vladz@cloudius-systems.com> Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 7E5E4689B for <dev@dpdk.org>; Wed, 24 Dec 2014 09:01:41 +0100 (CET) Received: by mail-wg0-f45.google.com with SMTP id b13so10897499wgh.18 for <dev@dpdk.org>; Wed, 24 Dec 2014 00:01:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type; bh=d3ybF88z79GcEjGLPXam0vp6yOYUY0p0wp6WsVtjGpE=; b=B/oDZhh674+ajUFUSq5aSPWR81dsx/qeh1z8LkarV+sGkzmPxdAK8tFJaG6zc+Iv9B gCaoRYJuskOTzUubWnYP+lpUyARutXvVbmYVX1XqvsTWRv44+YQIMXzvMg+0SmYaITwR MaQxSxCsUQAGG8mj3gAMzZe9dcob7w0n7aKwsHbFVBHeb7FVe961+g34cS2Xp1/wdc82 wproESynYN2k9NQ+6a95yOw+RvjG1h4xfFyM4vdfZkuZy2/wWSV0krWXT7G4qQpP539/ L6RH05rBdjMrGG0CPSe7LdpVTIdLB5imCZOHLfG7+5Dhe0gfxwKte0DZjUmZPTyX+Kpe iUfg== X-Gm-Message-State: ALoCoQnXNSWge7piyP0lgK2QJ5uBp/BgemqyhFAOQcv8a3NsUmA/Ld3c1lXAcogCWMmmKdVSU/Kh X-Received: by 10.194.61.168 with SMTP id q8mr59686245wjr.53.1419408101282; Wed, 24 Dec 2014 00:01:41 -0800 (PST) Received: from [10.0.0.1] (bzq-79-178-154-55.red.bezeqint.net. [79.178.154.55]) by mx.google.com with ESMTPSA id e7sm30631243wjx.31.2014.12.24.00.01.40 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Dec 2014 00:01:40 -0800 (PST) Message-ID: <549A72E3.9060606@cloudius-systems.com> Date: Wed, 24 Dec 2014 10:01:39 +0200 From: Vlad Zolotarov <vladz@cloudius-systems.com> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: "Ouyang, Changchun" <changchun.ouyang@intel.com> References: <1418897516-25918-1-git-send-email-vladz@cloudius-systems.com> <5492D13C.4020006@cloudius-systems.com> <F52918179C57134FAEC9EA62FA2F9625119489D9@shsmsx102.ccr.corp.intel.com> <CAOYyTHbin=bRTB4EOn8egG1rfCZUc31DmWr7+VcPcfh-qCH_fg@mail.gmail.com> <F52918179C57134FAEC9EA62FA2F96251194A2D2@shsmsx102.ccr.corp.intel.com> In-Reply-To: <F52918179C57134FAEC9EA62FA2F96251194A2D2@shsmsx102.ccr.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH 0/6] Enable VF RSS for Niantic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 24 Dec 2014 08:01:41 -0000 On 12/24/14 08:37, Ouyang, Changchun wrote: > > Hi, > > I have v3 patch for this to resolve your comments, > > We can discuss on v3 patch if there are further comments. > I'm looking at your v3 patchset right now... ;) > Thanks > > Changchun > > *From:*Vladislav Zolotarov [mailto:vladz@cloudius-systems.com] > *Sent:* Sunday, December 21, 2014 4:02 PM > *To:* Ouyang, Changchun > *Cc:* dev@dpdk.org > *Subject:* RE: [PATCH 0/6] Enable VF RSS for Niantic > > > On Dec 19, 2014 3:35 AM, "Ouyang, Changchun" > <changchun.ouyang@intel.com <mailto:changchun.ouyang@intel.com>> wrote: > > > > My response as below. > > > > > > > > From: Vlad Zolotarov [mailto:vladz@cloudius-systems.com > <mailto:vladz@cloudius-systems.com>] > > Sent: Thursday, December 18, 2014 9:06 PM > > To: dev@dpdk.org <mailto:dev@dpdk.org>; Ouyang, Changchun > > Subject: Re: [PATCH 0/6] Enable VF RSS for Niantic > > > > > > > > > > > > On 12/18/14 12:11, Vlad Zolotarov wrote: > >> > >> From: Changchun Ouyang <changchun.ouyang@intel.com > <mailto:changchun.ouyang@intel.com>> > >> > >> > >> > >> This patch enables VF RSS for Niantic, which allow each VF having > at most 4 queues. > >> > >> The actual queue number per VF depends on the number of VF: > >> > >> VF number from 1~32: 4 queues per VF; > >> > >> VF number from 33~max vf num: 2 queues per VF; > >> > >> > >> > >> On host, to enable VF RSS functionality, mq mode should be set as > ETH_MQ_RX_VMDQ_RSS > >> > >> or ETH_MQ_RX_RSS mode, and SRIOV mode should be activated. > >> > >> It also needs config VF RSS information like hash function, RSS > key, RSS key length. > > > > > > This patch series is missing a few things: > > > > Taking into the consideration the number of Rx queues requested by a > user in the rte_eth_dev_configure(). > > > > Changchun: yes, will have a v2 to consider it, as I say in my > previous response. > > I must have joined the mailing list after your v2 series. I'll take a > look in the web for it. > > > > > dev->dev_ops->reta_query used by a rte_eth_dev_rss_reta_query() is > still not initialized for a VF. Thus there is no way to query the RSS > table > > > > Changchun: do you mean query rss table on guest? > > Of course. > > Niantic doesn’t have separate reta for a specific vf, the reta is > shared by pf and all vf. > > AFAIK the reta is statically divided between all available functions. > > So, first of all we need a way to know that is the size of a single VF > partition in order to know how many RSS queues may be configured. > > Then we need an ability to query/set the contents of the corresponding > reta partition like we can for PF. > > > > > Do you think of returning all reta contents for each vf make sense? > Or any other insight here? > > > > rte_eth_dev_info_get() returns reta_size == 0 when called for a VF > function. > > > > Changchun: same as above. > > > > Your insight here are welcome here. > > > > thanks > > > > Changchun > > > > >