From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id D95645952 for ; Sun, 4 Jan 2015 09:40:08 +0100 (CET) Received: by mail-wg0-f45.google.com with SMTP id b13so26235685wgh.18 for ; Sun, 04 Jan 2015 00:40:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=6Zwo+Suk4zLMlWA6tPDGF+7zb2cp44A7dlSQcYNTL8g=; b=CnlmGGXwmVNEnnT3WKd65Jyz4eB4OfYTX31j1bAwyBVOe5UxlQPMQ/q13I/itxbvJ5 OR/cN8fvOW3p/ItPW90Ln3h+x6sQaTaTxQv7cgGYdYPzO1Duu1IcuGcRgailUK+blh3t GQuKWdDYJf8B6vYmTEADvZWB14Wbd1UJZx92cI8zfM851e+r0X+3DeMVGqlZDdQzHKxh DcGt61n6lVn8Lznh+7XBkRQc0ZBN0E7b4AvvQZ78xt4C/d6Cr2iUQugMdw4RXbW2Ym5C VRfrSDqiHia7MTRy8XIfDocaTPvjrIZLuQ4f6tKNZLCvtRqEcOMuQx3W3XI/Vta1teAp +J5Q== X-Gm-Message-State: ALoCoQnEJ8ermcf8p9r0lC9uQq0gTJl1ZAAF75TcSE1p7v3m4pQ8UwnMzwey0pOl6GDXiWKLIjrQ X-Received: by 10.194.92.116 with SMTP id cl20mr170584184wjb.71.1420360808794; Sun, 04 Jan 2015 00:40:08 -0800 (PST) Received: from [10.0.0.3] (bzq-79-179-0-199.red.bezeqint.net. [79.179.0.199]) by mx.google.com with ESMTPSA id td6sm5261467wic.15.2015.01.04.00.40.07 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Jan 2015 00:40:08 -0800 (PST) Message-ID: <54A8FC66.8070109@cloudius-systems.com> Date: Sun, 04 Jan 2015 10:40:06 +0200 From: Vlad Zolotarov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: "Ouyang, Changchun" , "dev@dpdk.org" References: <1419398584-19520-1-git-send-email-changchun.ouyang@intel.com> <1420355937-18484-1-git-send-email-changchun.ouyang@intel.com> <1420355937-18484-3-git-send-email-changchun.ouyang@intel.com> <54A8F93F.4080402@cloudius-systems.com> <54A8FA23.1090802@cloudius-systems.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 2/6] ixgbe: Negotiate VF API version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Jan 2015 08:40:09 -0000 On 01/04/15 10:37, Ouyang, Changchun wrote: > Hi Vlad, > >> -----Original Message----- >> From: Vlad Zolotarov [mailto:vladz@cloudius-systems.com] >> Sent: Sunday, January 4, 2015 4:30 PM >> To: Ouyang, Changchun; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v4 2/6] ixgbe: Negotiate VF API version >> >> >> On 01/04/15 10:26, Vlad Zolotarov wrote: >>> On 01/04/15 09:18, Ouyang Changchun wrote: >>>> Negotiate API version with VF when receiving the >>>> IXGBE_VF_API_NEGOTIATE message. >>>> >>>> Signed-off-by: Changchun Ouyang >>> Reviewed-by: Vlad Zolotarov > Thanks for your reviewing. > >> One small remark below. >> >>>> --- >>>> lib/librte_pmd_ixgbe/ixgbe_ethdev.h | 1 + >>>> lib/librte_pmd_ixgbe/ixgbe_pf.c | 25 +++++++++++++++++++++++++ >>>> 2 files changed, 26 insertions(+) >>>> >>>> diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.h >>>> b/lib/librte_pmd_ixgbe/ixgbe_ethdev.h >>>> index ca99170..730098d 100644 >>>> --- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.h >>>> +++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.h >>>> @@ -159,6 +159,7 @@ struct ixgbe_vf_info { >>>> uint16_t tx_rate[IXGBE_MAX_QUEUE_NUM_PER_VF]; >>>> uint16_t vlan_count; >>>> uint8_t spoofchk_enabled; >>>> + uint8_t api_version; >>>> }; >>>> /* >>>> diff --git a/lib/librte_pmd_ixgbe/ixgbe_pf.c >>>> b/lib/librte_pmd_ixgbe/ixgbe_pf.c index 51da1fd..495aff5 100644 >>>> --- a/lib/librte_pmd_ixgbe/ixgbe_pf.c >>>> +++ b/lib/librte_pmd_ixgbe/ixgbe_pf.c >>>> @@ -469,6 +469,28 @@ ixgbe_set_vf_lpe(struct rte_eth_dev *dev, >>>> __rte_unused uint32_t vf, uint32_t *ms >>>> } >>>> static int >>>> +ixgbe_negotiate_vf_api(struct rte_eth_dev *dev, uint32_t vf, >>>> uint32_t *msgbuf) >>>> +{ >>>> + uint32_t api_version = msgbuf[1]; >>>> + struct ixgbe_vf_info *vfinfo = >>>> + *IXGBE_DEV_PRIVATE_TO_P_VFDATA(dev->data->dev_private); >>>> + >>>> + switch (api_version) { >>>> + case ixgbe_mbox_api_10: >>>> + case ixgbe_mbox_api_11: >> Why version 2.0 is not negotiated? >> > Because it doesn't fully support 2.0 features yet. Well, it that case u should not support 2.0 in patch 3 as well. > > Thanks > Changchun >