From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <vladz@cloudius-systems.com>
Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com
[209.85.212.180]) by dpdk.org (Postfix) with ESMTP id 8BEA019F5
for <dev@dpdk.org>; Thu, 8 Jan 2015 10:46:14 +0100 (CET)
Received: by mail-wi0-f180.google.com with SMTP id n3so2078213wiv.1
for <dev@dpdk.org>; Thu, 08 Jan 2015 01:46:14 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to
:subject:references:in-reply-to:content-type
:content-transfer-encoding;
bh=yya9W4zTN+0ff0y0+dy8y0lDpEYuuAnfJ9+HYxRKwas=;
b=Y66Po1xeBBDbcMkE0Aft9pUaUY+GkItxznICaD3NTDg6Umoi3UaoRec59ELKUmhirq
q2Llb4+E85vu3yu3YcaRvh91Ltjsa3swOsfesydneI7xcb2XyfVc9FNOeD1kmaPobKLF
17JOEkfCiJvPjADoeTYNFDr8LkGem223XlU6ZEWv9OVGz8MsvPjPeHYBeWN1WtzADL6l
Le2nNmWBwGL7AXubWMcpjROB+YCO/xN4B+CpCCAhJux7nwKNRVjktSxIQyttvyGE5Hla
ZD7GJxjvE3uJkNrq6JwsJztqLdMM52BkC0SUrld8zY/C8cgwBAr3C69akie68nGa9KfN
hjPA==
X-Gm-Message-State: ALoCoQnuAvpiIC44GRuNwJKLMssUv0kb7tmNLrr86jgVYnclbBG9FUBKtZL3luPHKcFfkAFcoHVG
X-Received: by 10.180.205.163 with SMTP id lh3mr59514657wic.63.1420710374288;
Thu, 08 Jan 2015 01:46:14 -0800 (PST)
Received: from [10.0.0.4] ([109.66.137.113])
by mx.google.com with ESMTPSA id hz9sm5420808wjb.17.2015.01.08.01.46.13
(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Thu, 08 Jan 2015 01:46:13 -0800 (PST)
Message-ID: <54AE51E4.5050709@cloudius-systems.com>
Date: Thu, 08 Jan 2015 11:46:12 +0200
From: Vlad Zolotarov <vladz@cloudius-systems.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: Ouyang Changchun <changchun.ouyang@intel.com>, dev@dpdk.org
References: <1420355937-18484-1-git-send-email-changchun.ouyang@intel.com>
<1420612355-6666-1-git-send-email-changchun.ouyang@intel.com>
<1420612355-6666-7-git-send-email-changchun.ouyang@intel.com>
In-Reply-To: <1420612355-6666-7-git-send-email-changchun.ouyang@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v5 6/6] testpmd: Set Rx VMDq RSS mode
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Jan 2015 09:46:15 -0000
On 01/07/15 08:32, Ouyang Changchun wrote:
> Set VMDq RSS mode if it has VF(VF number is more than 1) and has RSS information.
>
> Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
Reviewed-by: Vlad Zolotarov <vladz@cloudius-systems.com>
Some nitpicking below... ;)
>
> changes in v5
> - Assign txmode.mq_mode with ETH_MQ_TX_NONE explicitly;
> - Remove one line wrong comment.
>
> ---
> app/test-pmd/testpmd.c | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index 8c69756..64fd4ee 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -1700,7 +1700,6 @@ init_port_config(void)
> port->dev_conf.rx_adv_conf.rss_conf.rss_hf = 0;
> }
>
> - /* In SR-IOV mode, RSS mode is not available */
> if (port->dcb_flag == 0 && port->dev_info.max_vfs == 0) {
> if( port->dev_conf.rx_adv_conf.rss_conf.rss_hf != 0)
> port->dev_conf.rxmode.mq_mode = ETH_MQ_RX_RSS;
> @@ -1708,6 +1707,20 @@ init_port_config(void)
> port->dev_conf.rxmode.mq_mode = ETH_MQ_RX_NONE;
> }
>
> + if (port->dev_info.max_vfs != 0) {
> + if (port->dev_conf.rx_adv_conf.rss_conf.rss_hf != 0) {
> + port->dev_conf.rxmode.mq_mode =
> + ETH_MQ_RX_VMDQ_RSS;
> + port->dev_conf.txmode.mq_mode =
> + ETH_MQ_TX_NONE;
> + } else {
> + port->dev_conf.rxmode.mq_mode =
> + ETH_MQ_RX_NONE;
> + port->dev_conf.txmode.mq_mode =
> + ETH_MQ_TX_NONE;
It seems that txmode.mq_mode assignment may be taken out of the
"if-else" statement here... ;)
> + }
> + }
> +
> port->rx_conf.rx_thresh = rx_thresh;
> port->rx_conf.rx_free_thresh = rx_free_thresh;
> port->rx_conf.rx_drop_en = rx_drop_en;