From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 09E1B5B0B
 for <dev@dpdk.org>; Fri, 23 Jan 2015 18:49:59 +0100 (CET)
Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214]
 helo=[192.168.0.10])
 by mail.droids-corp.org with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128)
 (Exim 4.80) (envelope-from <olivier.matz@6wind.com>)
 id 1YEiQI-0000lO-JH; Fri, 23 Jan 2015 18:53:37 +0100
Message-ID: <54C289BD.70601@6wind.com>
Date: Fri, 23 Jan 2015 18:49:49 +0100
From: Olivier MATZ <olivier.matz@6wind.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Icedove/31.3.0
MIME-Version: 1.0
To: "Liu, Jijiang" <jijiang.liu@intel.com>
References: <1421883395-27235-1-git-send-email-olivier.matz@6wind.com>
 <1421883395-27235-12-git-send-email-olivier.matz@6wind.com>
 <1ED644BD7E0A5F4091CF203DAFB8E4CC01DB6402@SHSMSX101.ccr.corp.intel.com>
In-Reply-To: <1ED644BD7E0A5F4091CF203DAFB8E4CC01DB6402@SHSMSX101.ccr.corp.intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RFC 11/16] testpmd: rename vxlan in outer_ip in
	csum commands
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Jan 2015 17:49:59 -0000

Hi Jijiang,

On 01/23/2015 12:21 PM, Liu, Jijiang wrote:
>>  static void
>>  pkt_burst_checksum_forward(struct fwd_stream *fs) @@ -432,18 +435,18 @@
>> pkt_burst_checksum_forward(struct fwd_stream *fs)
>>  		/* step 4: fill the mbuf meta data (flags and header lengths) */
>>
>>  		if (tunnel == 1) {
>> -			if (testpmd_ol_flags &
>> TESTPMD_TX_OFFLOAD_VXLAN_CKSUM) {
>> +			if (testpmd_ol_flags &
>> TESTPMD_TX_OFFLOAD_OUTER_IP_CKSUM) {
>>  				m->outer_l2_len = outer_l2_len;
>>  				m->outer_l3_len = outer_l3_len;
>>  				m->l2_len = l4_tun_len + l2_len;
>>  				m->l3_len = l3_len;
> 
> There should be m->l4_len = l4_len here.

Right, thank you for reporting it.

I'll fix that (but not in this patch which is just a renaming
of another part of the code).


Regards,
Olivier