From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <declan.doherty@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 3A662234
 for <dev@dpdk.org>; Fri, 30 Jan 2015 12:39:56 +0100 (CET)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga101.fm.intel.com with ESMTP; 30 Jan 2015 03:39:53 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.09,491,1418112000"; d="scan'208";a="678518412"
Received: from dwdohert-dpdk-fedora-20.ir.intel.com ([163.33.213.98])
 by orsmga002.jf.intel.com with ESMTP; 30 Jan 2015 03:39:54 -0800
Message-ID: <54CB6E1F.6040907@intel.com>
Date: Fri, 30 Jan 2015 11:42:23 +0000
From: Declan Doherty <declan.doherty@intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: "Wodkowski, PawelX" <pawelx.wodkowski@intel.com>, 
 Thomas Monjalon <thomas.monjalon@6wind.com>
References: <1422362703-18868-1-git-send-email-pawelx.wodkowski@intel.com>
 <3047657.sxLCa6eQXg@xps13>
 <F6F2A6264E145F47A18AB6DF8E87425D12B8FDC6@IRSMSX102.ger.corp.intel.com>
In-Reply-To: <F6F2A6264E145F47A18AB6DF8E87425D12B8FDC6@IRSMSX102.ger.corp.intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] Added missing extern 'C' decls in mode4
 header files
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Jan 2015 11:39:56 -0000

On 30/01/15 10:56, Wodkowski, PawelX wrote:
>> -----Original Message-----
>> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
>> Sent: Friday, January 30, 2015 11:21 AM
>> To: Wodkowski, PawelX
>> Cc: dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH] Added missing extern 'C' decls in mode4 header
>> files
>>
>> Hi Pawel,
>>
>>> Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
>>> ---
>>>   lib/librte_pmd_bond/rte_eth_bond_8023ad.h         |    8 ++++++++
>>>   lib/librte_pmd_bond/rte_eth_bond_8023ad_private.h |    8 ++++++++
>>
>> Why adding extern C in a private header file?
>>
>> --
>> Thomas
>
> To be consistent with rte_eth_bond_private.h where it is included.
>
>

We only need the decls on the public headers exported by the 
librte_pmd_bond makefile, so there is no need to modify 
rte_eth_bond_private.h as it should never be linked to directly by 
external code.