From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id C99FD2B9F for ; Fri, 5 May 2017 11:28:52 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 May 2017 02:28:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,291,1491289200"; d="scan'208";a="98002766" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga006.fm.intel.com with ESMTP; 05 May 2017 02:28:50 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX154.ger.corp.intel.com (163.33.192.96) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 5 May 2017 10:28:49 +0100 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.241]) by irsmsx112.ger.corp.intel.com ([169.254.1.61]) with mapi id 14.03.0319.002; Fri, 5 May 2017 10:28:49 +0100 From: "Singh, Jasvinder" To: "Richardson, Bruce" , "dev@dpdk.org" CC: "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH 07/10] net: fix missing break inside conditional compile block Thread-Index: AQHSxOzMBscSozJVPES8OToSIzKBKKHleWKA Date: Fri, 5 May 2017 09:28:49 +0000 Message-ID: <54CBAA185211B4429112C315DA58FF6D31B5E773@IRSMSX103.ger.corp.intel.com> References: <20170504153822.19461-1-bruce.richardson@intel.com> <20170504153822.19461-8-bruce.richardson@intel.com> In-Reply-To: <20170504153822.19461-8-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYThiN2ZhMDctNThjNi00NWZmLWExMTItMmFjZDIxMmYyZDg0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Im5qandHMWFYbzdWMDNQNExQTkU0Nk1EVXQwRHFjZjFjQnFEaGlZQzhYUGM9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 07/10] net: fix missing break inside conditional compile block X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 May 2017 09:28:53 -0000 -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson Sent: Thursday, May 4, 2017 4:38 PM To: dev@dpdk.org Cc: Richardson, Bruce Subject: [dpdk-dev] [PATCH 07/10] net: fix missing break inside conditional= compile block The #ifdef only had the break in the else leg rather than in the first leg,= leading to the value set their being overridden on fall-through. Fixes: 986ff526fb84 ("net: add CRC computation API") Signed-off-by: Bruce Richardson Acked-by: Jasvinder Singh