From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id B92DB29AC for ; Thu, 28 Sep 2017 10:14:50 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP; 28 Sep 2017 01:14:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,449,1500966000"; d="scan'208";a="1019355624" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga003.jf.intel.com with ESMTP; 28 Sep 2017 01:14:48 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.49]) by IRSMSX153.ger.corp.intel.com ([169.254.9.34]) with mapi id 14.03.0319.002; Thu, 28 Sep 2017 09:14:48 +0100 From: "Singh, Jasvinder" To: "Lu, Wenzhuo" , "dev@dpdk.org" CC: "Dumitrescu, Cristian" , "Yigit, Ferruh" , "thomas@monjalon.net" Thread-Topic: [dpdk-dev] [PATCH v4 2/4] net/softnic: add traffic management support Thread-Index: AQHTMFxbYrs1PUy6WESygbMA39yGo6LE0h2AgAUwfXA= Date: Thu, 28 Sep 2017 08:14:47 +0000 Message-ID: <54CBAA185211B4429112C315DA58FF6D3325C53D@IRSMSX103.ger.corp.intel.com> References: <20170811124929.118564-2-jasvinder.singh@intel.com> <20170918091015.82824-1-jasvinder.singh@intel.com> <20170918091015.82824-3-jasvinder.singh@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B6BD0F3@shsmsx102.ccr.corp.intel.com> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B6BD0F3@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmYzNjJlN2MtMWZiMy00MDdjLTkwOTgtODM4ODg3ZGFhYjdkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkNwT2FraFlUQzFGQU8xcVk0ck9TeVN5c2pnMGdocmxyd0dTT0JWbHVHUDQ9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 2/4] net/softnic: add traffic management support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Sep 2017 08:14:51 -0000 >=20 > Hi Jasvinder, >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jasvinder Singh > > Sent: Monday, September 18, 2017 5:10 PM > > To: dev@dpdk.org > > Cc: Dumitrescu, Cristian ; Yigit, > > Ferruh ; thomas@monjalon.net > > Subject: [dpdk-dev] [PATCH v4 2/4] net/softnic: add traffic management > > support > > > > Add ethdev Traffic Management API support to SoftNIC PMD. > > > > Signed-off-by: Cristian Dumitrescu > > Signed-off-by: Jasvinder Singh > > --- > > v3 changes: > > - add more confguration parameters (tm rate, tm queue sizes) > > > > drivers/net/softnic/Makefile | 1 + > > drivers/net/softnic/rte_eth_softnic.c | 252 > > +++++++++++++++++++++++- > > drivers/net/softnic/rte_eth_softnic.h | 16 ++ > > drivers/net/softnic/rte_eth_softnic_internals.h | 106 +++++++++- > > drivers/net/softnic/rte_eth_softnic_tm.c | 181 ++++++++++++++++= + > > 5 files changed, 553 insertions(+), 3 deletions(-) create mode > > 100644 drivers/net/softnic/rte_eth_softnic_tm.c >=20 >=20 >=20 > > > > static void > > @@ -293,6 +325,77 @@ rte_pmd_softnic_run_default(struct rte_eth_dev > > *dev) > > return 0; > > } > > > > +static __rte_always_inline int > > +rte_pmd_softnic_run_tm(struct rte_eth_dev *dev) { > This function name seems a little misleading. If it's a inline function n= ot an > API, better just name it 'softnic_run_tm". > And a common comments for the names, like, pmd_feature, > tm_params_check, tm_init ... if they're only for soft nic, better add the= prefix > 'softnc_' for them. Ok, will change the above function name for clarity. Thanks.