From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jasvinder.singh@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id A051E2B99
 for <dev@dpdk.org>; Thu, 28 Sep 2017 10:16:38 +0200 (CEST)
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
 by orsmga105.jf.intel.com with ESMTP; 28 Sep 2017 01:16:37 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.42,449,1500966000"; d="scan'208";a="156469371"
Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153])
 by fmsmga005.fm.intel.com with ESMTP; 28 Sep 2017 01:16:36 -0700
Received: from irsmsx103.ger.corp.intel.com ([169.254.3.49]) by
 IRSMSX101.ger.corp.intel.com ([169.254.1.22]) with mapi id 14.03.0319.002;
 Thu, 28 Sep 2017 09:16:35 +0100
From: "Singh, Jasvinder" <jasvinder.singh@intel.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>, "Yigit, Ferruh"
 <ferruh.yigit@intel.com>, "thomas@monjalon.net" <thomas@monjalon.net>
Thread-Topic: [dpdk-dev] [PATCH v4 3/4] net/softnic: add TM capabilities ops
Thread-Index: AQHTMFxuVRugTOdZuE2n3lbJ14eFVaLE28+AgAUnNVA=
Date: Thu, 28 Sep 2017 08:16:35 +0000
Message-ID: <54CBAA185211B4429112C315DA58FF6D3325C5EF@IRSMSX103.ger.corp.intel.com>
References: <20170811124929.118564-2-jasvinder.singh@intel.com>
 <20170918091015.82824-1-jasvinder.singh@intel.com>
 <20170918091015.82824-4-jasvinder.singh@intel.com>
 <6A0DE07E22DDAD4C9103DF62FEBC09093B6BD155@shsmsx102.ccr.corp.intel.com>
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B6BD155@shsmsx102.ccr.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDAzZDNmMGQtMjFiNS00ZDg2LWE0MmItYzM5YWU1OGZhMDQ3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InFCWTRwcTB6NHRmRlVNVmdGcGVKRkxYaFZ5TlFib1dhXC9iUnY5R2tXblF3PSJ9
x-ctpclassification: CTP_IC
dlp-product: dlpe-windows
dlp-version: 11.0.0.116
dlp-reaction: no-action
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v4 3/4] net/softnic: add TM capabilities ops
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Sep 2017 08:16:39 -0000


> Hi Jasvinder,
>=20
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jasvinder Singh
> > Sent: Monday, September 18, 2017 5:10 PM
> > To: dev@dpdk.org
> > Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Yigit,
> > Ferruh <ferruh.yigit@intel.com>; thomas@monjalon.net
> > Subject: [dpdk-dev] [PATCH v4 3/4] net/softnic: add TM capabilities
> > ops
> >
> > Implement ethdev TM capability APIs in SoftNIC PMD.
> >
> > Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > ---
> >  drivers/net/softnic/rte_eth_softnic.c           |  12 +-
> >  drivers/net/softnic/rte_eth_softnic_internals.h |  32 ++
> >  drivers/net/softnic/rte_eth_softnic_tm.c        | 500
> > ++++++++++++++++++++++++
> >  3 files changed, 543 insertions(+), 1 deletion(-)
> The same concern of the naming as patch 2.The function and structure
> names are too common. Better add the prefix 'softnic_' too.
> Except that, the patch looks good to me.

Ok, Thanks. Will clarity and add comments as well.