From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 3BB559FE for ; Mon, 11 Dec 2017 16:55:23 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2017 07:55:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,392,1508828400"; d="scan'208";a="1559943" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga007.fm.intel.com with ESMTP; 11 Dec 2017 07:55:21 -0800 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.49]) by IRSMSX102.ger.corp.intel.com ([169.254.2.180]) with mapi id 14.03.0319.002; Mon, 11 Dec 2017 15:53:20 +0000 From: "Singh, Jasvinder" To: "Mcnamara, John" , "dev@dpdk.org" CC: "Iremonger, Bernard" Thread-Topic: [dpdk-dev] [PATCH 3/3] doc: update documentation for flow classify lib Thread-Index: AQHTZE0KJvk2OOfxC0urVJ15ubVqFKM+V1kAgAAQLMA= Date: Mon, 11 Dec 2017 15:53:19 +0000 Message-ID: <54CBAA185211B4429112C315DA58FF6D33298A45@IRSMSX103.ger.corp.intel.com> References: <20171123113215.64757-1-jasvinder.singh@intel.com> <20171123113215.64757-3-jasvinder.singh@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzk3ZDRjMmItMGYwMC00YTk5LTgzOTgtZWIwMzA3YjU1YjViIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Iktnbld1ODhac3Q0cXA0aytOR0M1bGxkR25Cc3VBOW9LSjBoK0UzUHBMVEE9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 3/3] doc: update documentation for flow classify lib X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Dec 2017 15:55:24 -0000 > -----Original Message----- > From: Mcnamara, John > Sent: Monday, December 11, 2017 2:55 PM > To: Singh, Jasvinder ; dev@dpdk.org > Cc: Iremonger, Bernard > Subject: RE: [dpdk-dev] [PATCH 3/3] doc: update documentation for flow > classify lib >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jasvinder Singh > > Sent: Thursday, November 23, 2017 11:32 AM > > To: dev@dpdk.org > > Cc: Iremonger, Bernard > > Subject: [dpdk-dev] [PATCH 3/3] doc: update documentation for flow > > classify lib > > > > Updates the documentation for flow classification library and sample > > application. > > > > Signed-off-by: Jasvinder Singh >=20 >=20 > > > > +370,24 @@ parses the Flow rule. > > > > struct rte_flow_classify { > > uint32_t id; /* unique ID of classify object */ > > - struct rte_flow_action action; /* action when match found */ > > - struct classify_rules rules; /* union of rules */ > > + enum rte_flow_classify_table_type tbl_type; /* rule table */ > > + struct classify_rules rules; /* union of rules */ > > union { > > struct acl_keys key; > > } u; > > int key_found; /* rule key found in table */ > > - void *entry; /* pointer to buffer to hold rule meta data */ > > - void *entry_ptr; /* handle to the table entry for rule meta da= ta > > */ > > + struct rte_flow_classify_table_entry entry; /* rule meta data= */ > > + void *entry_ptr; /* handle to the table entry for rule meta > > + data >=20 >=20 > The last line here is indented less than the others. Also there is a stra= y tab a > few lines above it (in the existing text). Can you replace that as well. >=20 Will fix this in the next version. Thank you. Jasvinder